From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E16C77B7C for ; Fri, 5 May 2023 08:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231147AbjEEI6e (ORCPT ); Fri, 5 May 2023 04:58:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230055AbjEEI6d (ORCPT ); Fri, 5 May 2023 04:58:33 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B95713C22 for ; Fri, 5 May 2023 01:58:32 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 69C326605707; Fri, 5 May 2023 09:58:30 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1683277110; bh=vSczuqXRpd27PzucATAReL2YOYyw2x1YPKAjkBTjN64=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oaoXmrUzdzITM48AWpt/7Rw6iDm1F/bQqkqPra2cYr3ETQDKIbUYbfpGlqc1zTRMg 3Bh4vBXQSvmRwcOJi82tYqy1xa16Ngqim9nKWEe9ep2eezCctvEsIFGmabjboUavqy hVMwLq+15Yt5jbySK8yduGPVkVg3JM6E/yYilQBz9si6ho+zakOAU5DHF83PDRuEax Vkxb2x6sUP+mZm7vTkSf/VuQwLW1dbg+ri9yGk19GpV979TkVVoLwM3+iZWWHWpXQe cuuiHVDup1QO/jZE8AhmUwc6gPWnMCa6x0UT5IHKGPNkbUyGWXgUq12yBfo9BrNmgz DCQvp6pm6JueQ== Message-ID: Date: Fri, 5 May 2023 10:58:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 06/18] remoteproc: mtk_scp: Convert to platform remove callback returning void To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Bjorn Andersson , Mathieu Poirier , Matthias Brugger Cc: linux-remoteproc@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230504194453.1150368-1-u.kleine-koenig@pengutronix.de> <20230504194453.1150368-7-u.kleine-koenig@pengutronix.de> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <20230504194453.1150368-7-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Il 04/05/23 21:44, Uwe Kleine-König ha scritto: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Reviewed-by: AngeloGioacchino Del Regno From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E60C3C77B7D for ; Fri, 5 May 2023 08:59:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4YR7NZQ8tQOTP+3Q1Yl9SRX+3zvXmdu8NVFnbyJZK+k=; b=ZVhDBfjpNb7Ppe Y830U8Ztfuoh4mboYIw5rQ29igUibaLdTK6r1++V5rtxMW7DE1DLUyfA/aBr5CmK6WYSTC8o0k0kS KsCPYcunQtZt2rG1JpHVNU+G4+QDM7/75BAPaq9oAmZYCL2pJl/aF2IWU7ea463oc2UCCM83TyD4o jH7mJmRgT1MAZqFgp5WF0JO+a0m+pD5d7jy54nSVatFBa0nFY8mdZRiU/0+hjESViRk/17nAyodz4 7bFsrtnEerBjVjnJIGqTMrTN9l0AmsxQzsi+aBfgb5Tb77rY+AIjpKQDSO6Ab1yy74QeW3RFPTeiP QsKk5r3L0QgthdEGHFxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1purGu-00A4Y4-30; Fri, 05 May 2023 08:58:36 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1purGr-00A4XX-3D; Fri, 05 May 2023 08:58:35 +0000 Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 69C326605707; Fri, 5 May 2023 09:58:30 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1683277110; bh=vSczuqXRpd27PzucATAReL2YOYyw2x1YPKAjkBTjN64=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oaoXmrUzdzITM48AWpt/7Rw6iDm1F/bQqkqPra2cYr3ETQDKIbUYbfpGlqc1zTRMg 3Bh4vBXQSvmRwcOJi82tYqy1xa16Ngqim9nKWEe9ep2eezCctvEsIFGmabjboUavqy hVMwLq+15Yt5jbySK8yduGPVkVg3JM6E/yYilQBz9si6ho+zakOAU5DHF83PDRuEax Vkxb2x6sUP+mZm7vTkSf/VuQwLW1dbg+ri9yGk19GpV979TkVVoLwM3+iZWWHWpXQe cuuiHVDup1QO/jZE8AhmUwc6gPWnMCa6x0UT5IHKGPNkbUyGWXgUq12yBfo9BrNmgz DCQvp6pm6JueQ== Message-ID: Date: Fri, 5 May 2023 10:58:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 06/18] remoteproc: mtk_scp: Convert to platform remove callback returning void To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Bjorn Andersson , Mathieu Poirier , Matthias Brugger Cc: linux-remoteproc@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230504194453.1150368-1-u.kleine-koenig@pengutronix.de> <20230504194453.1150368-7-u.kleine-koenig@pengutronix.de> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <20230504194453.1150368-7-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230505_015834_191242_FDBE9DDF X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMDQvMDUvMjMgMjE6NDQsIFV3ZSBLbGVpbmUtS8O2bmlnIGhhIHNjcml0dG86Cj4gVGhlIC5y ZW1vdmUoKSBjYWxsYmFjayBmb3IgYSBwbGF0Zm9ybSBkcml2ZXIgcmV0dXJucyBhbiBpbnQgd2hp Y2ggbWFrZXMKPiBtYW55IGRyaXZlciBhdXRob3JzIHdyb25nbHkgYXNzdW1lIGl0J3MgcG9zc2li bGUgdG8gZG8gZXJyb3IgaGFuZGxpbmcgYnkKPiByZXR1cm5pbmcgYW4gZXJyb3IgY29kZS4gSG93 ZXZlciB0aGUgdmFsdWUgcmV0dXJuZWQgaXMgKG1vc3RseSkgaWdub3JlZAo+IGFuZCB0aGlzIHR5 cGljYWxseSByZXN1bHRzIGluIHJlc291cmNlIGxlYWtzLiBUbyBpbXByb3ZlIGhlcmUgdGhlcmUg aXMgYQo+IHF1ZXN0IHRvIG1ha2UgdGhlIHJlbW92ZSBjYWxsYmFjayByZXR1cm4gdm9pZC4gSW4g dGhlIGZpcnN0IHN0ZXAgb2YgdGhpcwo+IHF1ZXN0IGFsbCBkcml2ZXJzIGFyZSBjb252ZXJ0ZWQg dG8gLnJlbW92ZV9uZXcoKSB3aGljaCBhbHJlYWR5IHJldHVybnMKPiB2b2lkLgo+IAo+IFRyaXZp YWxseSBjb252ZXJ0IHRoaXMgZHJpdmVyIGZyb20gYWx3YXlzIHJldHVybmluZyB6ZXJvIGluIHRo ZSByZW1vdmUKPiBjYWxsYmFjayB0byB0aGUgdm9pZCByZXR1cm5pbmcgdmFyaWFudC4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJv bml4LmRlPgoKUmV2aWV3ZWQtYnk6IEFuZ2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25vIDxhbmdlbG9n aW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxhYm9yYS5jb20+CgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK