All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Julia Lawall <Julia.Lawall@inria.fr>,
	Cezary Rojewski <cezary.rojewski@intel.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>,
	Jie Yang <yang.jie@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] ASoC: Intel: bytcr_wm5102: use GFP_KERNEL
Date: Fri, 11 Feb 2022 08:43:09 +0100	[thread overview]
Message-ID: <d4425819-78c0-ad53-841d-fd59a59c2736@redhat.com> (raw)
In-Reply-To: <d26561a1-ddd4-aea0-792d-efce104ad44f@linux.intel.com>

Hi,

On 2/11/22 01:20, Pierre-Louis Bossart wrote:
> 
> 
> On 2/10/22 14:42, Julia Lawall wrote:
>> Platform_driver probe functions aren't called with locks held
>> and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.
>>
>> Problem found with Coccinelle.
> 
> Thanks Julia, indeed it's the only case where GFP_ATOMIC is used for
> machine drivers.
> 
> This was already present in the initial Android driver from Intel (2013)
> [1] and missed in the multiple passes to get this upstream.
> 
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Yeah I should have caught this when I upstreamed the machine driver:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> 
> [1]
> https://github.com/lenovo-yt2-dev/android_kernel_lenovo_baytrail/blob/cm-12.1/sound/soc/intel/board/byt_bl_wm5102.c
> 
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>>
>> ---
>>  sound/soc/intel/boards/bytcr_wm5102.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c
>> index 504ef4cab111..8d8e96e3cd2d 100644
>> --- a/sound/soc/intel/boards/bytcr_wm5102.c
>> +++ b/sound/soc/intel/boards/bytcr_wm5102.c
>> @@ -389,7 +389,7 @@ static int snd_byt_wm5102_mc_probe(struct platform_device *pdev)
>>  	bool sof_parent;
>>  	int ret;
>>  
>> -	priv = devm_kzalloc(dev, sizeof(*priv), GFP_ATOMIC);
>> +	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
>>  	if (!priv)
>>  		return -ENOMEM;
>>  
>>
> 


WARNING: multiple messages have this Message-ID
From: Hans de Goede <hdegoede@redhat.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Julia Lawall <Julia.Lawall@inria.fr>,
	Cezary Rojewski <cezary.rojewski@intel.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
	Jie Yang <yang.jie@linux.intel.com>,
	Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 3/9] ASoC: Intel: bytcr_wm5102: use GFP_KERNEL
Date: Fri, 11 Feb 2022 08:43:09 +0100	[thread overview]
Message-ID: <d4425819-78c0-ad53-841d-fd59a59c2736@redhat.com> (raw)
In-Reply-To: <d26561a1-ddd4-aea0-792d-efce104ad44f@linux.intel.com>

Hi,

On 2/11/22 01:20, Pierre-Louis Bossart wrote:
> 
> 
> On 2/10/22 14:42, Julia Lawall wrote:
>> Platform_driver probe functions aren't called with locks held
>> and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.
>>
>> Problem found with Coccinelle.
> 
> Thanks Julia, indeed it's the only case where GFP_ATOMIC is used for
> machine drivers.
> 
> This was already present in the initial Android driver from Intel (2013)
> [1] and missed in the multiple passes to get this upstream.
> 
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Yeah I should have caught this when I upstreamed the machine driver:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> 
> [1]
> https://github.com/lenovo-yt2-dev/android_kernel_lenovo_baytrail/blob/cm-12.1/sound/soc/intel/board/byt_bl_wm5102.c
> 
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>>
>> ---
>>  sound/soc/intel/boards/bytcr_wm5102.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c
>> index 504ef4cab111..8d8e96e3cd2d 100644
>> --- a/sound/soc/intel/boards/bytcr_wm5102.c
>> +++ b/sound/soc/intel/boards/bytcr_wm5102.c
>> @@ -389,7 +389,7 @@ static int snd_byt_wm5102_mc_probe(struct platform_device *pdev)
>>  	bool sof_parent;
>>  	int ret;
>>  
>> -	priv = devm_kzalloc(dev, sizeof(*priv), GFP_ATOMIC);
>> +	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
>>  	if (!priv)
>>  		return -ENOMEM;
>>  
>>
> 


  reply	other threads:[~2022-02-11  7:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 20:42 [PATCH 0/9] use GFP_KERNEL Julia Lawall
2022-02-10 20:42 ` Julia Lawall
2022-02-10 20:42 ` Julia Lawall
2022-02-10 20:42 ` [PATCH 1/9] net: moxa: " Julia Lawall
2022-02-10 20:42 ` [PATCH 2/9] media: cx18: " Julia Lawall
2022-02-18 12:26   ` Dan Carpenter
2022-02-10 20:42 ` [PATCH 3/9] ASoC: Intel: bytcr_wm5102: " Julia Lawall
2022-02-10 20:42   ` Julia Lawall
2022-02-11  0:20   ` Pierre-Louis Bossart
2022-02-11  0:20     ` Pierre-Louis Bossart
2022-02-11  7:43     ` Hans de Goede [this message]
2022-02-11  7:43       ` Hans de Goede
2022-02-10 20:42 ` [PATCH 4/9] crypto: " Julia Lawall
2022-02-18  5:37   ` Herbert Xu
2022-02-10 20:42 ` [PATCH 5/9] pata_mpc52xx: " Julia Lawall
2022-02-10 20:45   ` Sergey Shtylyov
2022-02-11  7:43   ` Damien Le Moal
2022-02-10 20:42 ` [PATCH 6/9] media: fsl-viu: " Julia Lawall
2022-02-10 20:42 ` [PATCH 7/9] mtd: spear_smi: " Julia Lawall
2022-02-10 20:42   ` Julia Lawall
2022-02-18 14:32   ` Miquel Raynal
2022-02-18 14:32     ` Miquel Raynal
2022-02-10 20:42 ` [PATCH 8/9] [SCSI] mptfusion: " Julia Lawall
2022-02-11 22:10   ` Martin K. Petersen
2022-02-10 20:42 ` [PATCH 9/9] mfd: sta2x11: " Julia Lawall
2022-02-15 13:22   ` Lee Jones
2022-02-12  0:20 ` [PATCH 0/9] " patchwork-bot+netdevbpf
2022-02-12  0:20   ` patchwork-bot+netdevbpf
2022-02-14 12:54 ` (subset) " Mark Brown
2022-02-14 12:54   ` Mark Brown
2022-02-14 12:54   ` Mark Brown
2022-02-15  3:19 ` Martin K. Petersen
2022-02-15  3:19   ` Martin K. Petersen
2022-02-15  3:19   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4425819-78c0-ad53-841d-fd59a59c2736@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.