From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB45FC433F5 for ; Fri, 11 Feb 2022 07:43:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347783AbiBKHnR (ORCPT ); Fri, 11 Feb 2022 02:43:17 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:51132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347777AbiBKHnP (ORCPT ); Fri, 11 Feb 2022 02:43:15 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 74A892E9 for ; Thu, 10 Feb 2022 23:43:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644565393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q+JoBX4dv2Ujy4kHFl4q2D9yIGmIdd5volu8AUosqWE=; b=RdUhG+Hyq2LpweCA5pPN7RiZhctVT43Bxc9M2053mC39yhfl2J1kE3oZc7IPhh9VJJzpvV FzbkkfLl8F+xuoxf3QX3BnU8RtY+zZBT5fDGfoim533yFV6SSX0+JyOeUWwt19CFA4myT/ ujPhZ3S8qumHSO+oOJMovj0E8yPh/VU= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-282-S-OgPcbMPEyu1Si4IEHX9A-1; Fri, 11 Feb 2022 02:43:12 -0500 X-MC-Unique: S-OgPcbMPEyu1Si4IEHX9A-1 Received: by mail-ej1-f71.google.com with SMTP id ky6-20020a170907778600b0068e4bd99fd1so3725789ejc.15 for ; Thu, 10 Feb 2022 23:43:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Q+JoBX4dv2Ujy4kHFl4q2D9yIGmIdd5volu8AUosqWE=; b=5MXtkSWHEs7XPgENYcgEmFPmnoi+Dv3QDTE9K3ib7RsjXdzzCS3+CwcMl2LHNiNNuB tWlq6CNoeiJMORsTASWyk+/WYpJE8KB7uFLVOlShOHz5oiLV91hc7nNTmjtwDkLUJoTo vN4FfESb9GJlnnBF0QE5ctJicw+uhaQf02+2wtHcAxIqk1ByOkaUgKYrKGP1Z0ic82ou g2huh2KTiTGDTV8oooO5rqL8RI4fomZ3GzNptevxi9SWqbIsJKDWE/5suSotiiVwrpGx YH8fmCekqLrl6WW1Cx7abnw5qfd0MsK4k/INbZ7RjXe5MJ1XRy6wYBvkIZRSEyekkIpW zNFw== X-Gm-Message-State: AOAM531d3/HXvwTIdcGDmtWDsr8fJ3HtyCQ7wXZJPGgOlBTLeRXkqTwE NXpq9hCpIk22GYF5zrnqHTEqD2CB+nphIi/sC+LQb+FLhHTTIBcXfOCjca8l9HPrFQa6GfsoKhm pEsHXzDvNrs2J3Efy2NYPXTI/ X-Received: by 2002:a17:906:5d14:: with SMTP id g20mr322475ejt.37.1644565391013; Thu, 10 Feb 2022 23:43:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEfQpRtLobU4UAs4SWOVNcJDhEjOkbQmmbly0Xr2tW7hupHSA1QdZZhCzrr2fKvmPOHvfu0w== X-Received: by 2002:a17:906:5d14:: with SMTP id g20mr322469ejt.37.1644565390811; Thu, 10 Feb 2022 23:43:10 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id g15sm4632241edz.100.2022.02.10.23.43.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 23:43:10 -0800 (PST) Message-ID: Date: Fri, 11 Feb 2022 08:43:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 3/9] ASoC: Intel: bytcr_wm5102: use GFP_KERNEL Content-Language: en-US To: Pierre-Louis Bossart , Julia Lawall , Cezary Rojewski Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Jie Yang , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org References: <20220210204223.104181-1-Julia.Lawall@inria.fr> <20220210204223.104181-4-Julia.Lawall@inria.fr> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2/11/22 01:20, Pierre-Louis Bossart wrote: > > > On 2/10/22 14:42, Julia Lawall wrote: >> Platform_driver probe functions aren't called with locks held >> and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead. >> >> Problem found with Coccinelle. > > Thanks Julia, indeed it's the only case where GFP_ATOMIC is used for > machine drivers. > > This was already present in the initial Android driver from Intel (2013) > [1] and missed in the multiple passes to get this upstream. > > Acked-by: Pierre-Louis Bossart Yeah I should have caught this when I upstreamed the machine driver: Reviewed-by: Hans de Goede Regards, Hans > > [1] > https://github.com/lenovo-yt2-dev/android_kernel_lenovo_baytrail/blob/cm-12.1/sound/soc/intel/board/byt_bl_wm5102.c > >> >> Signed-off-by: Julia Lawall >> >> --- >> sound/soc/intel/boards/bytcr_wm5102.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c >> index 504ef4cab111..8d8e96e3cd2d 100644 >> --- a/sound/soc/intel/boards/bytcr_wm5102.c >> +++ b/sound/soc/intel/boards/bytcr_wm5102.c >> @@ -389,7 +389,7 @@ static int snd_byt_wm5102_mc_probe(struct platform_device *pdev) >> bool sof_parent; >> int ret; >> >> - priv = devm_kzalloc(dev, sizeof(*priv), GFP_ATOMIC); >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); >> if (!priv) >> return -ENOMEM; >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C554C433F5 for ; Fri, 11 Feb 2022 07:44:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 832951884; Fri, 11 Feb 2022 08:43:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 832951884 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1644565457; bh=g7Ug7dLxyn2Fq1ichXaivbLK5yRLWUTThKIlBpaO79c=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IxXjR1VVOlSbU2C/qKSbWPNVIVJVsyWr67f0LUzzgyF/0cfunyxhL1L4dzCJNunYM /OCEdQ0E/RoZGega8ZaxUK112MqNmmEublFzD+XjO05UGarQcq/lgSSLXQDIeF+mSH E7HLDOsYcd0Chw5Wnt5eZ9ldtqp6steqxU9iG67s= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 09AF1F800B0; Fri, 11 Feb 2022 08:43:27 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BE350F80125; Fri, 11 Feb 2022 08:43:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1A363F80125 for ; Fri, 11 Feb 2022 08:43:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1A363F80125 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ha+F/6T3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644565395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q+JoBX4dv2Ujy4kHFl4q2D9yIGmIdd5volu8AUosqWE=; b=ha+F/6T3htbpCetzvgXWoOy/M93Uaf+bB8W3FgRmCBkuNDviial83WHWpbBOA87C9NgUbn OoxYcJryHfwxDraKtfPwZWINUMLIjSuScEQ9ALnPHFgUrqpmb+e/AMh7mtfSxh+EKk42vf b/hRlM49R9Byj5bneFUng4qiUX9psaY= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-Cw407PM0Otu0god3Yel5hA-1; Fri, 11 Feb 2022 02:43:12 -0500 X-MC-Unique: Cw407PM0Otu0god3Yel5hA-1 Received: by mail-ej1-f70.google.com with SMTP id l18-20020a1709063d3200b006a93f7d4941so3756388ejf.1 for ; Thu, 10 Feb 2022 23:43:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Q+JoBX4dv2Ujy4kHFl4q2D9yIGmIdd5volu8AUosqWE=; b=NJMvquDqsEiuCDYBTIlbl7MqUwy3ChvKCfyHqaU5RR2hFfKJlHPi8JPRVgmTQBVtd2 4tfWrcqcLCC+XAnglg6Up46UV7XL5ZKe8sRKwkPwk7fGYgpH9jPuR6oQdH6lf20gCZmn 6MShC8hHO+oSQGu7QyZVRClL85Us5mYkdb+kdl8SByTkpNFS3pbYBmJfGwBa5eRUSSxM OlTXL1lLSsMfZW3KPqPOT8MCmyRFAk7gVUq5cKRGbmALrcjZLqpSvPVl2OW7eJ3O05hW QHx+o758fYbpCi7vvOaHN3HW7Ra05yfBj5ERqEfjHLZgRMVJifwnzYFPui6hyqMcQcvc x2Qg== X-Gm-Message-State: AOAM532lI3uGaCfpf1x0BQ8l+l57biDWu17WIB4BasPHEoxVHd1Pt1+j PdtdOC0sToCv6eVchTdpOUdYcH/kw6g68DBPrINcKQm0HdZwWeZIHW8FnMhhmo3LAv6YoN/CTll xmcFulzGdti8m6pVQy8+kSfA= X-Received: by 2002:a17:906:5d14:: with SMTP id g20mr322474ejt.37.1644565391012; Thu, 10 Feb 2022 23:43:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEfQpRtLobU4UAs4SWOVNcJDhEjOkbQmmbly0Xr2tW7hupHSA1QdZZhCzrr2fKvmPOHvfu0w== X-Received: by 2002:a17:906:5d14:: with SMTP id g20mr322469ejt.37.1644565390811; Thu, 10 Feb 2022 23:43:10 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id g15sm4632241edz.100.2022.02.10.23.43.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 23:43:10 -0800 (PST) Message-ID: Date: Fri, 11 Feb 2022 08:43:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 3/9] ASoC: Intel: bytcr_wm5102: use GFP_KERNEL To: Pierre-Louis Bossart , Julia Lawall , Cezary Rojewski References: <20220210204223.104181-1-Julia.Lawall@inria.fr> <20220210204223.104181-4-Julia.Lawall@inria.fr> From: Hans de Goede In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Jie Yang , Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, On 2/11/22 01:20, Pierre-Louis Bossart wrote: > > > On 2/10/22 14:42, Julia Lawall wrote: >> Platform_driver probe functions aren't called with locks held >> and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead. >> >> Problem found with Coccinelle. > > Thanks Julia, indeed it's the only case where GFP_ATOMIC is used for > machine drivers. > > This was already present in the initial Android driver from Intel (2013) > [1] and missed in the multiple passes to get this upstream. > > Acked-by: Pierre-Louis Bossart Yeah I should have caught this when I upstreamed the machine driver: Reviewed-by: Hans de Goede Regards, Hans > > [1] > https://github.com/lenovo-yt2-dev/android_kernel_lenovo_baytrail/blob/cm-12.1/sound/soc/intel/board/byt_bl_wm5102.c > >> >> Signed-off-by: Julia Lawall >> >> --- >> sound/soc/intel/boards/bytcr_wm5102.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c >> index 504ef4cab111..8d8e96e3cd2d 100644 >> --- a/sound/soc/intel/boards/bytcr_wm5102.c >> +++ b/sound/soc/intel/boards/bytcr_wm5102.c >> @@ -389,7 +389,7 @@ static int snd_byt_wm5102_mc_probe(struct platform_device *pdev) >> bool sof_parent; >> int ret; >> >> - priv = devm_kzalloc(dev, sizeof(*priv), GFP_ATOMIC); >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); >> if (!priv) >> return -ENOMEM; >> >> >