From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D8A3C433EF for ; Fri, 11 Mar 2022 18:41:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4237E8303C; Fri, 11 Mar 2022 19:41:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=akkea.ca header.i=@akkea.ca header.b="qjjVaWcs"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="SiHco0Jj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6E30A81DE9; Fri, 11 Mar 2022 19:41:41 +0100 (CET) Received: from node.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0B30A81F9A for ; Fri, 11 Mar 2022 19:41:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angus@akkea.ca Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 2F2AA4E200C; Fri, 11 Mar 2022 18:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1647024095; bh=rf+o/00ovxf2Nd/F/B45v4rLSvO9O+MduNJv35Ca9zM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=qjjVaWcse6ZbCfqoezSEEWn32YEzj+tYuEvSGWnKyng6Vjba+0Mg7+PtR8iww0iGd wpfgACI/2SWnc100e+OMLjvZxEfHmK7EgP7chaOAJIB/HdF/7/QvNYJ8MHEYkc/q2Y q7Z9aMEZWWPC8JGjdwN1RBeIHTtHq2k2TC10Uz6g= Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NF7Zi6JQik8h; Fri, 11 Mar 2022 18:41:34 +0000 (UTC) Received: from www.akkea.ca (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 1AE524E2003; Fri, 11 Mar 2022 18:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1647024094; bh=rf+o/00ovxf2Nd/F/B45v4rLSvO9O+MduNJv35Ca9zM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=SiHco0Jjb0NCuCU+SC2+roX1Ol+YNsovr/C3C4r3gfjjW+LEXa9FkMV7OUsLB/NR8 rOV3S0GeCD/g7uJewI+lg/HE+/6JUK4/WZcaWqdLuW8HyhIjHO1BjhbeqzMjD2oEOr RXlIme7+PawKw4uwKCdPDfpzfnlgWR6u4n7MsQA0= MIME-Version: 1.0 Date: Fri, 11 Mar 2022 10:41:34 -0800 From: Angus Ainslie To: Marek Vasut Cc: Angus Ainslie , u-boot@lists.denx.de, lukma@denx.de, seanga2@gmail.com, sbabic@denx.de, festevam@gmail.com, kernel@puri.sm, uboot-imx@nxp.com Subject: Re: [PATCH v2 2/2] clk: imx8mq: Add a clock driver for the imx8mq In-Reply-To: References: <20220311163536.1330032-1-angus@akkea.ca> <20220311163536.1330032-3-angus@akkea.ca> <14af7ab4-59a7-1af6-2f53-446eefcb87b5@denx.de> <86e82fc6-4a10-3d7c-19bf-e171815ef0e6@puri.sm> Message-ID: X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.17 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2022-03-11 10:05, Marek Vasut wrote: > On 3/11/22 18:02, Angus Ainslie wrote: >> On 2022-03-11 08:57, Marek Vasut wrote: >>> On 3/11/22 17:35, Angus Ainslie wrote: >>>> All of the PLLs and clocks are initialized so the subsystems below >>>> are >>>> functional and tested. >>>> >>>> 1) USB host and peripheral >>>> 2) ECSPI >>>> 3) UART >>>> 4) I2C all busses >>>> 5) USDHC for eMMC support >>>> 6) USB storage >>>> 7) GPIO >>>> 8) DRAM >>>> >>>> The PLL rate tables are from the kernel >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=43cdaa1567ad3931fbde438853947d45238cc040 >>> >>> That patch is three years old. >>> That patch is for MX8M Mini clock, not for MX8M(Q). >>> >>> You can use the abbreviated commit ID instead: >>> 43cdaa1567ad3 ("clk: imx8mm: Move 1443X/1416X PLL clock structure to >>> common place") >>> But that seems to be the wrong commit. >> >> That's the commit where the imx8m PLL frequency table is moved to a >> common file for use by all of the imx8m variants. The imx8mq linux >> driver does not even use the frequency tables so there is not a >> specific commit for it. > > Isn't large part of this driver coming from these tables ? > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/clk/imx/clk-imx8mq.c When I said tables I was referring to the PLL frequency tables. The driver is modelled after the u-boot imx8mm u-boot driver with register and mux updates from the imx8mq reference manual. Very little comes from the imx8mq kernel driver. Mainly I just verified mux naming and register offsets against that driver. That reminds me that I need to send a kernel patch for the monitor muxes.