All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 1/2] configs/raspberrypi: change deprecated pi3-miniuart-bt option to miniuart-bt
Date: Tue, 3 Dec 2019 21:46:28 +0100	[thread overview]
Message-ID: <d4430993-aaee-7cf4-9290-cb8547022fee@mind.be> (raw)
In-Reply-To: <20191203211204.6c4951f4@gmx.net>



On 03/12/2019 21:12, Peter Seiderer wrote:
> Hello Arthur,
> 
> thanks for the patch, one nitpick below...
> 
> On Tue,  3 Dec 2019 14:26:57 +0100, Arthur Courtel <arthur.courtel@smile.fr> wrote:
> 
>> This option will be used in RPI4 config in order to have a working serial port on gpios.
>> This change makes this option not only RPI3 specific.
>>
>> Signed-off-by: Arthur Courtel <arthur.courtel@smile.fr>
>> ---
>>  board/raspberrypi/post-image.sh      | 8 ++++----
>>  board/raspberrypi/readme.txt         | 2 +-
>>  configs/raspberrypi3_64_defconfig    | 2 +-
>>  configs/raspberrypi3_defconfig       | 2 +-
>>  configs/raspberrypi3_qt5we_defconfig | 2 +-
>>  configs/raspberrypi4_defconfig       | 2 +-
>>  6 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/board/raspberrypi/post-image.sh b/board/raspberrypi/post-image.sh
>> index bbeb0bc721..9dbd98ef9b 100755
>> --- a/board/raspberrypi/post-image.sh
>> +++ b/board/raspberrypi/post-image.sh
>> @@ -10,13 +10,13 @@ GENIMAGE_TMP="${BUILD_DIR}/genimage.tmp"
>>  for arg in "$@"
>>  do
>>  	case "${arg}" in
>> -		--add-pi3-miniuart-bt-overlay)
>> +		--add-miniuart-bt-overlay)
> Maybe keep additional the legacy '--add-pi3-miniuart-bt-overlay' option for people
> using old custom config files?

 I don't think we need to do that. Everything in board/ is supposed to be
internal. If you use one of our defconfigs as inspiration for your own custom
config, you should copy all the support stuff as well.

 Regards,
 Arnout

      reply	other threads:[~2019-12-03 20:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 13:26 [Buildroot] [PATCHv2 1/2] configs/raspberrypi: change deprecated pi3-miniuart-bt option to miniuart-bt Arthur Courtel
2019-12-03 13:26 ` [Buildroot] [PATCHv2 2/2] configs: add raspberrypi4 64bits defconfig Arthur Courtel
2019-12-03 20:16   ` Peter Seiderer
2019-12-04  9:55     ` Arthur COURTEL
2019-12-03 20:12 ` [Buildroot] [PATCHv2 1/2] configs/raspberrypi: change deprecated pi3-miniuart-bt option to miniuart-bt Peter Seiderer
2019-12-03 20:46   ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4430993-aaee-7cf4-9290-cb8547022fee@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.