From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C313CC433F5 for ; Wed, 22 Sep 2021 06:38:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EE9B60EC0 for ; Wed, 22 Sep 2021 06:38:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232808AbhIVGjv (ORCPT ); Wed, 22 Sep 2021 02:39:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51194 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232718AbhIVGjt (ORCPT ); Wed, 22 Sep 2021 02:39:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3XTCa1nu8hCtlYTFFK2GZognBOtLDAkX/kYxcYF1XA=; b=DYR/cNYjYXx0ukC/9ghCQ44fMKmGf4EmHP54m3+KELovum0qTcLDOKnDi2hEmzViIjpX21 HFCodzhVpFmWdtnp2MqpEKrqs+nsEDUdBfT0UZ1NTDzcQYTF6Z0iLqI24GuG2QTaEKtuwN cs3HIsVqwqgI4DMQTgjKzqTbIRJXDu4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-592-CFq32KV0My62Ze-qr0UW3A-1; Wed, 22 Sep 2021 02:38:18 -0400 X-MC-Unique: CFq32KV0My62Ze-qr0UW3A-1 Received: by mail-wr1-f70.google.com with SMTP id z2-20020a5d4c82000000b0015b140e0562so1175755wrs.7 for ; Tue, 21 Sep 2021 23:38:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z3XTCa1nu8hCtlYTFFK2GZognBOtLDAkX/kYxcYF1XA=; b=xJvhw8XZ13EJTaFP+McxJ8i8Y6SH80OI6WkI7k5wriQTViOx1hVTHot1Abf6k7luRZ Wiw8tKwhOrTc7qPomEKvuGt+sqldXbU4YLWycQdfP2F2KQRLqx1Exq1D2sf9VGGA97aQ g52wg95KiZJY9aW3TEIxR8/RETNryhvYhVztx2sqRaVMq8zJdC6c8NfJLgigmyX00tHb Y6xwS2uO5kJzPyorzc9q+vjAfHPK2bNZcENoI+0OTNU27of/XxroFslU5wBf1T5x5rEY S9Y8GoKJ3hjA5x+CQ2xTpLIXuqRTDXIET+atKODNXD9fHXjbOkEmdi7qbX8ElCxr3qaA LWHQ== X-Gm-Message-State: AOAM533IxPjfwjvMGwBSBfQae17ABZksdbVcIvLZ9a7zFMFAOPzlvDRN TCCdv5rBuQXk8jMjt/6siPjKv02VT5twh9DTxZ3sFcWJ0gueY153eqxd7XLFETMTRZ0ieM1N/Jx g1H2fcCs7Id5+ELQw0LzMLxOx X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr8614019wmj.163.1632292697325; Tue, 21 Sep 2021 23:38:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywCmZIrNrFYOLYwz4uLurAI8KkuEnxjxQSJf2bjooMgzy2h0qoOTiWQbU4UgbH2lcfc2iQrA== X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr8613976wmj.163.1632292697089; Tue, 21 Sep 2021 23:38:17 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j21sm1162153wrd.48.2021.09.21.23.38.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:38:16 -0700 (PDT) Subject: Re: [PATCH v3 11/16] KVM: x86: More precisely identify NMI from guest when handling PMI To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Alexandru Elisei , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Artem Kashkanov , Like Xu , Zhu Lingshan References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-12-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Wed, 22 Sep 2021 08:38:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-12-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/21 02:05, Sean Christopherson wrote: > Note, this also doesn't completely prevent false positives if perf > somehow ends up calling into KVM, e.g. an NMI can arrive in host after > KVM sets its flag. s/calling into KVM/being called from KVM/ ? Not sure about what you meant though. The code is nice, so Reviewed-by: Paolo Bonzini Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A3CBC433EF for ; Wed, 22 Sep 2021 06:38:26 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id AAC2E61178 for ; Wed, 22 Sep 2021 06:38:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AAC2E61178 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 35FD14A500; Wed, 22 Sep 2021 02:38:25 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HyNEvAjhnaGh; Wed, 22 Sep 2021 02:38:24 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2542C405A6; Wed, 22 Sep 2021 02:38:24 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2552F405A6 for ; Wed, 22 Sep 2021 02:38:23 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lsTQuuI5-nOm for ; Wed, 22 Sep 2021 02:38:22 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4778540573 for ; Wed, 22 Sep 2021 02:38:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3XTCa1nu8hCtlYTFFK2GZognBOtLDAkX/kYxcYF1XA=; b=NUU64Xb1BcgagGpy9iPM2unKlGXmCCkRfB69KsWkLaF1CANMexfuGIRg2veNeBpU0TlP7C SMmoE3GhDeOg+/rY3Jky4LurhV/dNIJD+g2nyanA45uYOJKrgQ5LdF9C5yl9nWGruU4Fm5 /Fx0zIef1Gp4HywOyr78b6+Q+MzXQk8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-514-ebyn1y4kNWWKRy7HHDUy8A-1; Wed, 22 Sep 2021 02:38:18 -0400 X-MC-Unique: ebyn1y4kNWWKRy7HHDUy8A-1 Received: by mail-wr1-f70.google.com with SMTP id v1-20020adfc401000000b0015e11f71e65so1187018wrf.2 for ; Tue, 21 Sep 2021 23:38:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z3XTCa1nu8hCtlYTFFK2GZognBOtLDAkX/kYxcYF1XA=; b=EMg4T4yP6ORnKXqjWSFxhsE+s6nE1c6tL9Cb0uC9cuUTAxw408hQ3PlcgMx12YDlhN 3hXECzhUKbdZeTwNFUdPcpfF2k/I0QSXvjOQg0CSpWYOfSXbvZf8FsEagFLS6itscc4+ KwBnvYkCsQ+Mhg9o6W+ma1rZpYW0sBfM7RBEAiLGBsT/c4HUgtM/GKSDNuFJ5MOeVuSB SUH1KYim6dy303l2F4zWjzkulsHyuwtzeSwUDGkRw9m8EbxW3d9AAKLBOBy92/2bS856 +WozeMu/nPP9gm3uk8ttTJSXJYkfRQSgG/pAFRlo+SEUHFYcQqRqvOqm03fXv62xyoGo gEhg== X-Gm-Message-State: AOAM530yKICxsFrkikB3r6NfyDSmng4SIfd7aw3Z809gQ0WwG71LQ7GH kaUotqXHpr36dsbTMRHPL3+1BXw4frdHldXJvOoEHZmBJIbNcpG5qcTf7BTAso+PTaS+g0wZJec 1R0tUF2Oa3A4Momf2COlzc8bF X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr8614001wmj.163.1632292697323; Tue, 21 Sep 2021 23:38:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywCmZIrNrFYOLYwz4uLurAI8KkuEnxjxQSJf2bjooMgzy2h0qoOTiWQbU4UgbH2lcfc2iQrA== X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr8613976wmj.163.1632292697089; Tue, 21 Sep 2021 23:38:17 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j21sm1162153wrd.48.2021.09.21.23.38.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:38:16 -0700 (PDT) Subject: Re: [PATCH v3 11/16] KVM: x86: More precisely identify NMI from guest when handling PMI To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-12-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Wed, 22 Sep 2021 08:38:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-12-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Wanpeng Li , kvm@vger.kernel.org, Alexander Shishkin , Vitaly Kuznetsov , linux-riscv@lists.infradead.org, Jiri Olsa , kvmarm@lists.cs.columbia.edu, Stefano Stabellini , Joerg Roedel , linux-csky@vger.kernel.org, xen-devel@lists.xenproject.org, Namhyung Kim , Artem Kashkanov , linux-arm-kernel@lists.infradead.org, Jim Mattson , Like Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Zhu Lingshan X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 22/09/21 02:05, Sean Christopherson wrote: > Note, this also doesn't completely prevent false positives if perf > somehow ends up calling into KVM, e.g. an NMI can arrive in host after > KVM sets its flag. s/calling into KVM/being called from KVM/ ? Not sure about what you meant though. The code is nice, so Reviewed-by: Paolo Bonzini Paolo _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B88A4C433EF for ; Wed, 22 Sep 2021 06:44:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 844AB611B0 for ; Wed, 22 Sep 2021 06:44:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 844AB611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=65XjWbsMlYiVLmtKIFPjIMsLWBvkuOXvLpA+4FUtB8s=; b=2nF4PTN5r5PVZW5tmaulHtrPY+ y3NEddtnIvAPA1fJY9+/mPOusDw8ShloBFTeoRvyktjxjQ/UHKy0ThSyxF+XYQOKD3vMUxna8VhaM Jyd8TPdPXDKFjJey2IHAvbHGVB3fNg+AChq5DVmzWIWI4N151myFHXNSoBVVzSFk1FpB9f3nuUEH0 5J22RbD7z/CgpOdXqXCdagRFloKBEveMX8XSh6pbCj4BvV2QNAKNz6eZzISmqKEWe3I2y9lt+uPz7 +TXokzndS3vP98w3LoskrFOSftWLtVWsJ4JHSa3myIP8ZqtPl3rTnC9z6nMxvAjJiZtHkh9XZZxrR 0rO6lPAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSvz0-0077nW-RK; Wed, 22 Sep 2021 06:43:54 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSvtf-0076TO-79 for linux-riscv@lists.infradead.org; Wed, 22 Sep 2021 06:38:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3XTCa1nu8hCtlYTFFK2GZognBOtLDAkX/kYxcYF1XA=; b=NUU64Xb1BcgagGpy9iPM2unKlGXmCCkRfB69KsWkLaF1CANMexfuGIRg2veNeBpU0TlP7C SMmoE3GhDeOg+/rY3Jky4LurhV/dNIJD+g2nyanA45uYOJKrgQ5LdF9C5yl9nWGruU4Fm5 /Fx0zIef1Gp4HywOyr78b6+Q+MzXQk8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-514-Ni2lkNTUMeaxCgAnic72iQ-1; Wed, 22 Sep 2021 02:38:18 -0400 X-MC-Unique: Ni2lkNTUMeaxCgAnic72iQ-1 Received: by mail-wr1-f69.google.com with SMTP id l9-20020adfc789000000b00160111fd4e8so1137343wrg.17 for ; Tue, 21 Sep 2021 23:38:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z3XTCa1nu8hCtlYTFFK2GZognBOtLDAkX/kYxcYF1XA=; b=t1z4O8IEO+Gk/1e7qjlvXNd5gZcUchlYENucVdy1wonDJcMABz20xFX9/sPcVL8g9m anwtaEDfdQJtIY1Aa9dJqCbHkOwe6MBQos0pLusqEEG/fFcrHFgqCwJPjhyeo1MsjD5k ih2nfxcYKk27jYNveIUJCyHvBXukPPPow36wgfrWIH0BajZC1Hm3J59gduaQsqGbpoTT XYI+NP6LzdOjG96LJlNc9UUgO0eU34+Hkj9XkHP8lyLIJjJkva067M/G5bWYGXBwhf/R HTV2QREBSrkGdFI/VlcA9OY5jPTAeWPy1RfaBLa5rtpaU63wR+6kmlJv5psRt580T07a hMWA== X-Gm-Message-State: AOAM530QtyFnGBMMPt1/glgvp+MCkqo3b87qbPKjFKUCHJ16zrIUph8r Jz2k7e48ysO4YPWWqDBCA1mm0NYc2ynCz3Z7LipqvN1MFTOPx/I/Rfz26QUfWaTdZsL1oSjDqHs 5yixLNxv+oT3ig7pwXAvDr6/DVu1B X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr8613997wmj.163.1632292697322; Tue, 21 Sep 2021 23:38:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywCmZIrNrFYOLYwz4uLurAI8KkuEnxjxQSJf2bjooMgzy2h0qoOTiWQbU4UgbH2lcfc2iQrA== X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr8613976wmj.163.1632292697089; Tue, 21 Sep 2021 23:38:17 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j21sm1162153wrd.48.2021.09.21.23.38.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:38:16 -0700 (PDT) Subject: Re: [PATCH v3 11/16] KVM: x86: More precisely identify NMI from guest when handling PMI To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Alexandru Elisei , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Artem Kashkanov , Like Xu , Zhu Lingshan References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-12-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Wed, 22 Sep 2021 08:38:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-12-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_233823_366328_0CC5DA80 X-CRM114-Status: GOOD ( 10.16 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 22/09/21 02:05, Sean Christopherson wrote: > Note, this also doesn't completely prevent false positives if perf > somehow ends up calling into KVM, e.g. an NMI can arrive in host after > KVM sets its flag. s/calling into KVM/being called from KVM/ ? Not sure about what you meant though. The code is nice, so Reviewed-by: Paolo Bonzini Paolo _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 650ECC433EF for ; Wed, 22 Sep 2021 06:45:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25E99611B0 for ; Wed, 22 Sep 2021 06:45:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 25E99611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EcbXSXtP6pTl2O6WDN2dFZ8/hkHQ4Eq8BNELQx2oFWs=; b=tHm4/tgfvO5ctl7CBbdyBtLnKc eAIQejXxRwYT4ZzRK0Mg3iseyWRo52jGbn8+DGbe1mQXYgJyr8ESqXPj1xH7SHLA9JIw18N0N639g 1LUjpVJrKXgA0QwvXF/UF7euJFM6vB3hNxY3hJTkAG8C4aIUvJ1oodE9CYHXj0+s+l3hyMGpQBuL2 HppUbX0Ahqg5wy7x7qlUC0AAoMIyLfhdhmN0bU7F6RglQE5uvrSpaMMudD8Qvxrk4n/CAGaZHeSC0 pP5PTwR2d/wMl81X6jL0WMa/KHFgSuRtARkI6xcaDwDefk5D8YOq7LHGT1gSJSFhg25tcpDuqyf5l GdzGeEyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSvxp-0077Rv-Kw; Wed, 22 Sep 2021 06:42:44 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSvtd-0076Sc-41 for linux-arm-kernel@lists.infradead.org; Wed, 22 Sep 2021 06:38:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3XTCa1nu8hCtlYTFFK2GZognBOtLDAkX/kYxcYF1XA=; b=DYR/cNYjYXx0ukC/9ghCQ44fMKmGf4EmHP54m3+KELovum0qTcLDOKnDi2hEmzViIjpX21 HFCodzhVpFmWdtnp2MqpEKrqs+nsEDUdBfT0UZ1NTDzcQYTF6Z0iLqI24GuG2QTaEKtuwN cs3HIsVqwqgI4DMQTgjKzqTbIRJXDu4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-249-xfmkrrZ8OtGzdQs41Lj_BA-1; Wed, 22 Sep 2021 02:38:18 -0400 X-MC-Unique: xfmkrrZ8OtGzdQs41Lj_BA-1 Received: by mail-wr1-f71.google.com with SMTP id e1-20020adfa741000000b0015e424fdd01so1154906wrd.11 for ; Tue, 21 Sep 2021 23:38:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z3XTCa1nu8hCtlYTFFK2GZognBOtLDAkX/kYxcYF1XA=; b=peW3g3Ql0fbtpKQbjAEe0Eo034naRFyGyrPGqmjMbFOQ+YbEdr170DSbXuJ9nN9RY5 Sr3P4/5nfANyjrZca2cx0rOzhlxUNdYEhMNC3J4mOAQRQlyZG1kULortxs+zYaQUkUud e4GzOUJLh7IsyIfOQ+ngnS9MfXTQJltJJ4NIIon+Q4SW0FT62zHgsO9urH6ZgqMETuJO WZUftp8nagyQTqR6F1hRjNQKRjlNWnRlN7ZFdePqaMRwwLdJF6nNacoHFtIe4MPlE1l5 bMN4YdTyT0am2MbwmySpV+NLSREsCALcCJ9uxLzSJ1ZoaXIFS6rGS4fcGoaX0Yk8kdfP Rlsw== X-Gm-Message-State: AOAM533rgbhWWJvWnXEkBF6pIVhUPyqyZMB1yOFoSYToDoTRnGFKSYSz tlq+VU1y23TmfRQhi8WJ/alSSr+7HL19s8jU5csblgY1WGWiqENqyKTqhLZgOOkzEqYpKyzRwuY 8gGzlBoIMuSRyOEtW4XESsl5Ky7Yv6n1SZdY= X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr8614009wmj.163.1632292697323; Tue, 21 Sep 2021 23:38:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywCmZIrNrFYOLYwz4uLurAI8KkuEnxjxQSJf2bjooMgzy2h0qoOTiWQbU4UgbH2lcfc2iQrA== X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr8613976wmj.163.1632292697089; Tue, 21 Sep 2021 23:38:17 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j21sm1162153wrd.48.2021.09.21.23.38.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:38:16 -0700 (PDT) Subject: Re: [PATCH v3 11/16] KVM: x86: More precisely identify NMI from guest when handling PMI To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Alexandru Elisei , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Artem Kashkanov , Like Xu , Zhu Lingshan References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-12-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Wed, 22 Sep 2021 08:38:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-12-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_233821_342257_2BDAC564 X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/09/21 02:05, Sean Christopherson wrote: > Note, this also doesn't completely prevent false positives if perf > somehow ends up calling into KVM, e.g. an NMI can arrive in host after > KVM sets its flag. s/calling into KVM/being called from KVM/ ? Not sure about what you meant though. The code is nice, so Reviewed-by: Paolo Bonzini Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel