Re: [PATCH 1/2] drm/i915: Rotated view does not need a fence

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 25/10/2016 15:12, Ville Syrjälä wrote:
> On Tue, Oct 25, 2016 at 03:00:23PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> We do not need to set up a fence for the rotated view.
>>
>> Display does not need it and no one can access it.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Broken by 05a20d098db1 ("drm/i915: Move map-and-fenceable tracking to
> the VMA") ?

Wasn't sure if this is considered a breakage. Will add when you made the 
effort to dig out the commit, thanks!

Regards,

Tvrtko

>
>> ---
>>  drivers/gpu/drm/i915/i915_gem_gtt.h | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h
>> index c241d8143255..c79d7ab75003 100644
>> --- a/drivers/gpu/drm/i915/i915_gem_gtt.h
>> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
>> @@ -251,7 +251,8 @@ static inline bool i915_vma_is_ggtt(const struct i915_vma *vma)
>>
>>  static inline bool i915_vma_is_map_and_fenceable(const struct i915_vma *vma)
>>  {
>> -	return vma->flags & I915_VMA_CAN_FENCE;
>> +	return vma->flags & I915_VMA_CAN_FENCE &&
>> +	       vma->ggtt_view.type != I915_GGTT_VIEW_ROTATED;
>>  }
>>
>>  static inline bool i915_vma_is_closed(const struct i915_vma *vma)
>> --
>> 2.7.4
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx