All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
	David Hildenbrand <david@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Laurent Vivier <laurent@vivier.eu>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v5 3/8] qapi: Restrict balloon-related commands to machine code
Date: Mon, 14 Sep 2020 14:15:17 +0200	[thread overview]
Message-ID: <d446f5a6-2547-b32b-75dd-f38410effc57@redhat.com> (raw)
In-Reply-To: <87lfhcppsx.fsf@dusky.pond.sub.org>

On 9/14/20 1:21 PM, Markus Armbruster wrote:
> David Hildenbrand <david@redhat.com> writes:
> 
>>> Am 14.09.2020 um 11:42 schrieb Philippe Mathieu-Daudé <philmd@redhat.com>:
>>>
>>> +Laurent and David
>>>
>>>> On 9/14/20 11:16 AM, Markus Armbruster wrote:
>>>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>>>
>>>>> Only qemu-system-FOO and qemu-storage-daemon provide QMP
>>>>> monitors, therefore such declarations and definitions are
>>>>> irrelevant for user-mode emulation.
>>>>>
>>>>> Restricting the balloon-related commands to machine.json
>>>>> allows pulling less declarations/definitions to user-mode.
>>>>
>>>> How this affects user mode is not obvious to (ignorant) me.  Can you
>>>> provide a clue?
>>>
>>> I guess this was discussed with David at some point.
>>>
>>> Maybe the QMP commands are not exposed via HMP, making this
>>> code unreachable?
>>>
>>> Anyhow user-mode binaries don't use the memory ballooning feature,
>>> this is specific to system-mode emulation.
>>>
>>> Laurent/David, do you have some more trivial explanation?
>>
>> Agreed.
>>
>> No memory ballooning device -> no memory ballooning :)
> 
> I understand why user mode doesn't need device models.  What I don't
> understand offhand is how balloon-related stuff in misc.json ends up
> pulling "declarations/definitions to user-mode".  What exactly is being
> pulled where before the series, and no more afterwards?
> 
> Is it just the code generated for the QAPI stuff you move, or is it
> more?

As of this series, this is only QAPI generated code.
(code which pulls in unwanted declarations/definitions
that should be poisoned, but we can't because of this).

I didn't feel the need to enumerate what is removed from
user-mode, because from the diff (and no link failure)
I thought it was obvious. I can do, but that would be
simply copy/pasting the QAPI changes.

Part 3 start to remove things, but I kept that separated.



  reply	other threads:[~2020-09-14 12:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-13 19:53 [PATCH v5 0/8] user-mode: Prune build dependencies (part 2) Philippe Mathieu-Daudé
2020-09-13 19:53 ` [PATCH v5 1/8] qapi: Restrict LostTickPolicy enum to machine code Philippe Mathieu-Daudé
2020-09-14  9:14   ` Markus Armbruster
2020-09-14  9:37     ` Philippe Mathieu-Daudé
2020-09-15  6:27       ` Markus Armbruster
2020-09-13 19:53 ` [PATCH v5 2/8] qapi: Correct balloon documentation Philippe Mathieu-Daudé
2020-09-13 19:53 ` [PATCH v5 3/8] qapi: Restrict balloon-related commands to machine code Philippe Mathieu-Daudé
2020-09-14  9:16   ` Markus Armbruster
2020-09-14  9:42     ` Philippe Mathieu-Daudé
2020-09-14  9:48       ` David Hildenbrand
2020-09-14 11:21         ` Markus Armbruster
2020-09-14 12:15           ` Philippe Mathieu-Daudé [this message]
2020-09-15  6:24             ` Markus Armbruster
2020-09-13 19:53 ` [PATCH v5 4/8] qapi: Restrict query-vm-generation-id command " Philippe Mathieu-Daudé
2020-09-13 19:53 ` [PATCH v5 5/8] qapi: Restrict query-uuid " Philippe Mathieu-Daudé
2020-09-13 19:53 ` [PATCH v5 6/8] qapi: Restrict device memory commands " Philippe Mathieu-Daudé
2020-09-13 19:53 ` [PATCH v5 7/8] qapi: Extract ACPI commands to 'acpi.json' Philippe Mathieu-Daudé
2020-09-13 19:53 ` [PATCH v5 8/8] qapi: Extract PCI commands to 'pci.json' Philippe Mathieu-Daudé
2020-09-15  6:29 ` [PATCH v5 0/8] user-mode: Prune build dependencies (part 2) Markus Armbruster
2020-09-15  7:09   ` Philippe Mathieu-Daudé
2020-09-15  8:52 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d446f5a6-2547-b32b-75dd-f38410effc57@redhat.com \
    --to=philmd@redhat.com \
    --cc=armbru@redhat.com \
    --cc=david@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.