From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 253AFC32751 for ; Sat, 10 Aug 2019 19:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E87D7208C3 for ; Sat, 10 Aug 2019 19:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726165AbfHJTU1 (ORCPT ); Sat, 10 Aug 2019 15:20:27 -0400 Received: from smtprelay0069.hostedemail.com ([216.40.44.69]:46310 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726052AbfHJTU1 (ORCPT ); Sat, 10 Aug 2019 15:20:27 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id B155B180A7F88; Sat, 10 Aug 2019 19:20:25 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: war91_78006327e2207 X-Filterd-Recvd-Size: 2979 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Sat, 10 Aug 2019 19:20:24 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 1/2] linux/bits.h: Clarify macro argument names From: Joe Perches To: Masahiro Yamada , Rikard Falkeborn Cc: Andrew Morton , Johannes Berg , Linux Kernel Mailing List Date: Sat, 10 Aug 2019 12:20:23 -0700 In-Reply-To: References: <20190731190309.19909-1-rikard.falkeborn@gmail.com> <20190801230358.4193-1-rikard.falkeborn@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-08-08 at 12:46 +0900, Masahiro Yamada wrote: > On Fri, Aug 2, 2019 at 8:04 AM Rikard Falkeborn > wrote: > > Be a little more verbose to improve readability. > > > > Signed-off-by: Rikard Falkeborn > > BTW, I do not understand what the improvement is. > I tend to regard this as a noise commit. Non verbose naming clarity is good. Perhaps adding kernel-doc is good too. > > > --- > > Changes in v2: > > - This patch is new in v2 > > > > include/linux/bits.h | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/include/linux/bits.h b/include/linux/bits.h > > index 669d69441a62..d4466aa42a9c 100644 > > --- a/include/linux/bits.h > > +++ b/include/linux/bits.h > > @@ -14,16 +14,16 @@ > > #define BITS_PER_BYTE 8 > > > > /* > > - * Create a contiguous bitmask starting at bit position @l and ending at > > - * position @h. For example > > + * Create a contiguous bitmask starting at bit position @low and ending at > > + * position @high. For example > > * GENMASK_ULL(39, 21) gives us the 64bit vector 0x000000ffffe00000. > > */ > > -#define GENMASK(h, l) \ > > - (((~UL(0)) - (UL(1) << (l)) + 1) & \ > > - (~UL(0) >> (BITS_PER_LONG - 1 - (h)))) > > +#define GENMASK(high, low) \ > > + (((~UL(0)) - (UL(1) << (low)) + 1) & \ > > + (~UL(0) >> (BITS_PER_LONG - 1 - (high)))) > > > > -#define GENMASK_ULL(h, l) \ > > - (((~ULL(0)) - (ULL(1) << (l)) + 1) & \ > > - (~ULL(0) >> (BITS_PER_LONG_LONG - 1 - (h)))) > > +#define GENMASK_ULL(high, low) \ > > + (((~ULL(0)) - (ULL(1) << (low)) + 1) & \ > > + (~ULL(0) >> (BITS_PER_LONG_LONG - 1 - (high)))) > > > > #endif /* __LINUX_BITS_H */ > > -- > > 2.22.0 > > > >