Re: [cocci] [v5] coccinelle: Extend address test from ifaddr semantic patch to test expressions

From: Markus Elfring <Markus.Elfring@web.de>
To: "Julia Lawall" <julia.lawall@inria.fr>,
	"Jérémy Lefaure" <jeremy.lefaure@netatmo.com>
Cc: cocci@inria.fr, kernel-janitors@vger.kernel.org,
	Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: [cocci] [v5] coccinelle: Extend address test from ifaddr semantic patch to test expressions
Date: Fri, 1 Jul 2022 23:13:34 +0200	[thread overview]
Message-ID: <d4797cd5-1412-e6af-1f40-d5e094b1acd8@web.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2207011647580.4779@hadrien>

>> Can another SmPL code example help with the clarification of proposed
>> implementation details?
>>
>> @display@
>> expression x;
>> binary operator bo = { ==, != };
>> @@
>> * &x bo NULL
> Markus, did you actually try this?

A command part like “spatch --parse-cocci ….cocci” will show a bit of information
as usual.

> Please try things before suggesting them.

I suggest to take another look also at related SmPL code variations.

> The whole point of the proposed change is to trigger some isomorphisms.
> I really doubt that any isomorphisms will be triggered with
> this suggestion.

Will such a desire influence corresponding descriptions any further?

Would you dare to follow the presented design direction any further
so that even the explicit source code filter for equal/unequal binary operators
could be omitted (according to the combination with the address-of operator)?

Will any related software limitations be adjusted?

Regards,
Markus