From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 463DAC07E96 for ; Thu, 8 Jul 2021 18:38:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 030E561456 for ; Thu, 8 Jul 2021 18:38:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 030E561456 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9EC6B6E95C; Thu, 8 Jul 2021 18:38:14 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C5656E957 for ; Thu, 8 Jul 2021 18:38:13 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="189250438" X-IronPort-AV: E=Sophos;i="5.84,224,1620716400"; d="scan'208";a="189250438" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 11:37:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,224,1620716400"; d="scan'208";a="492233024" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 08 Jul 2021 11:37:51 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 8 Jul 2021 11:37:51 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 8 Jul 2021 11:37:50 -0700 Received: from fmsmsx611.amr.corp.intel.com ([10.18.126.91]) by fmsmsx611.amr.corp.intel.com ([10.18.126.91]) with mapi id 15.01.2242.010; Thu, 8 Jul 2021 11:37:50 -0700 From: "Srivatsa, Anusha" To: Jani Nikula , "Roper, Matthew D" , "intel-gfx@lists.freedesktop.org" Thread-Topic: [PATCH 0/7] Minor revid/stepping and workaround cleanup Thread-Index: AQHXc8t9zMUSV3FY6EWbL+sC8MRy/6s5aIBg Date: Thu, 8 Jul 2021 18:37:50 +0000 Message-ID: References: <20210708053819.2120187-1-matthew.d.roper@intel.com> <87h7h56z11.fsf@intel.com> In-Reply-To: <87h7h56z11.fsf@intel.com> Accept-Language: en-US Content-Language: en-US X-Mentions: matthew.d.roper@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.22.254.132] MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 0/7] Minor revid/stepping and workaround cleanup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > -----Original Message----- > From: Jani Nikula > Sent: Thursday, July 8, 2021 12:33 AM > To: Roper, Matthew D ; intel- > gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha > Subject: Re: [PATCH 0/7] Minor revid/stepping and workaround cleanup > > On Wed, 07 Jul 2021, Matt Roper wrote: > > PCI revision IDs don't always map to GT and display IP steppings in an > > intuitive/sensible way. On many of our recent platforms we've > > switched to using revid->stepping lookup tables with the > > infrastructure in intel_step.c to handle stepping lookups and > > comparisons. Since it's confusing to have some of our platforms using > > the new lookup tables and some still using old revid comparisons, > > let's migrate all the old platforms over to the table approach since > > that's what we want to standardize on going forward. The only place > > that revision ID's should really get used directly now is when > > checking to see if we're running on pre-production hardware. > > Anusha, Matt, please sort this out between the two of you. :) > > https://patchwork.freedesktop.org/series/92257/ > @Roper, Matthew D the series doesn't add the steeping table for BXT and GLK. Anusha > BR, > Jani. > > > > > > Let's also take the opportunity to drop a bit of effectively dead code > > in the workarounds file too. > > > > Cc: Jani Nikula > > > > Matt Roper (7): > > drm/i915: Make pre-production detection use direct revid comparison > > drm/i915/skl: Use revid->stepping tables > > drm/i915/icl: Use revid->stepping tables > > drm/i915/jsl_ehl: Use revid->stepping tables > > drm/i915/rkl: Use revid->stepping tables > > drm/i915/dg1: Use revid->stepping tables > > drm/i915/cnl: Drop all workarounds > > > > .../drm/i915/display/intel_display_power.c | 2 +- > > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- > > drivers/gpu/drm/i915/display/intel_psr.c | 4 +- > > drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +- > > drivers/gpu/drm/i915/gt/intel_workarounds.c | 81 +++---------------- > > drivers/gpu/drm/i915/i915_drv.c | 8 +- > > drivers/gpu/drm/i915/i915_drv.h | 80 +++--------------- > > drivers/gpu/drm/i915/intel_pm.c | 2 +- > > drivers/gpu/drm/i915/intel_step.c | 72 +++++++++++++++-- > > drivers/gpu/drm/i915/intel_step.h | 7 ++ > > 10 files changed, 107 insertions(+), 153 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx