All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Aditya Pakki <pakki001@umn.edu>
Cc: kjlu@umn.edu, Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: RDMA/srpt: remove unnecessary assertion in srpt_queue_response
Date: Tue, 17 Dec 2019 12:34:44 -0800	[thread overview]
Message-ID: <d497d620-9aff-616c-67ae-bfb93f39b926@acm.org> (raw)
In-Reply-To: <20191217194437.25568-1-pakki001@umn.edu>

On 12/17/19 11:44 AM, Aditya Pakki wrote:
> Currently, BUG_ON in srpt_queue_response, is used as an assertion for
> empty rdma channel. However, if the channel is NULL, the call trace
> on console is sufficient for diagnosis.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> v1: Avoid potential NULL pointer derefernce of ch. Current fix
> suggested by Bart Van Assche
> ---
>   drivers/infiniband/ulp/srpt/ib_srpt.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 23c782e3d49a..98552749d71c 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -2810,8 +2810,6 @@ static void srpt_queue_response(struct se_cmd *cmd)
>   	int resp_len, ret, i;
>   	u8 srp_tm_status;
>   
> -	BUG_ON(!ch);
> -
>   	state = ioctx->state;
>   	switch (state) {
>   	case SRPT_STATE_NEW:

I think the description of this patch should also mention that this 
patch removes a check of a pointer after it has already been 
dereferenced. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Aditya Pakki <pakki001@umn.edu>
Cc: kjlu@umn.edu, Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: RDMA/srpt: remove unnecessary assertion in srpt_queue_response
Date: Tue, 17 Dec 2019 20:34:44 +0000	[thread overview]
Message-ID: <d497d620-9aff-616c-67ae-bfb93f39b926@acm.org> (raw)
In-Reply-To: <20191217194437.25568-1-pakki001@umn.edu>

On 12/17/19 11:44 AM, Aditya Pakki wrote:
> Currently, BUG_ON in srpt_queue_response, is used as an assertion for
> empty rdma channel. However, if the channel is NULL, the call trace
> on console is sufficient for diagnosis.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> v1: Avoid potential NULL pointer derefernce of ch. Current fix
> suggested by Bart Van Assche
> ---
>   drivers/infiniband/ulp/srpt/ib_srpt.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 23c782e3d49a..98552749d71c 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -2810,8 +2810,6 @@ static void srpt_queue_response(struct se_cmd *cmd)
>   	int resp_len, ret, i;
>   	u8 srp_tm_status;
>   
> -	BUG_ON(!ch);
> -
>   	state = ioctx->state;
>   	switch (state) {
>   	case SRPT_STATE_NEW:

I think the description of this patch should also mention that this 
patch removes a check of a pointer after it has already been 
dereferenced. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

  reply	other threads:[~2019-12-17 20:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 19:44 [PATCH v2] scsi: RDMA/srpt: remove unnecessary assertion in srpt_queue_response Aditya Pakki
2019-12-17 19:44 ` Aditya Pakki
2019-12-17 20:34 ` Bart Van Assche [this message]
2019-12-17 20:34   ` Bart Van Assche
2020-01-03 20:23 ` Jason Gunthorpe
2020-01-03 20:23   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d497d620-9aff-616c-67ae-bfb93f39b926@acm.org \
    --to=bvanassche@acm.org \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kjlu@umn.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=pakki001@umn.edu \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.