All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH 3/5] usb: host: dwc2: force reset assert
Date: Tue, 15 Oct 2019 01:29:57 +0200	[thread overview]
Message-ID: <d4a847ac-b675-6a85-4320-c4f3800c18b1@denx.de> (raw)
In-Reply-To: <20191014080025.11245-4-patrick.delaunay@st.com>

On 10/14/19 10:00 AM, Patrick Delaunay wrote:
> Assert reset before deassert in dwc2_reset;
> It should be more safe for DWC2.

Can you be more descriptive about this issue ? I have no idea what this
patch does or fixes from the description.

> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> 
>  drivers/usb/host/dwc2.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/host/dwc2.c b/drivers/usb/host/dwc2.c
> index 51023b0c2c..3086411fc4 100644
> --- a/drivers/usb/host/dwc2.c
> +++ b/drivers/usb/host/dwc2.c
> @@ -1149,6 +1149,8 @@ static int dwc2_reset(struct udevice *dev)
>  			return ret;
>  	}
>  
> +	reset_assert_bulk(&priv->resets);
> +	udelay(2);

Why is there a 2 uS delay ?

>  	ret = reset_deassert_bulk(&priv->resets);
>  	if (ret) {
>  		reset_release_bulk(&priv->resets);
> 

[...]

  reply	other threads:[~2019-10-14 23:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14  8:00 [U-Boot] [RESEND PATCH 0/5] usb: host: dwc2: use driver model for PHY and CLOCK Patrick Delaunay
2019-10-14  8:00 ` [U-Boot] [RESEND PATCH 1/5] usb: host: dwc2: add phy support Patrick Delaunay
2019-10-14 23:26   ` Marek Vasut
2019-11-06 17:40     ` Patrick DELAUNAY
2019-11-06 21:55       ` Marek Vasut
2019-11-08 13:25         ` Patrick DELAUNAY
2019-11-08 15:41           ` Marek Vasut
2019-10-14  8:00 ` [U-Boot] [RESEND PATCH 2/5] usb: host: dwc2: add support for clk Patrick Delaunay
2019-10-14 23:28   ` Marek Vasut
2019-11-06 18:03     ` Patrick DELAUNAY
2019-11-06 21:59       ` Marek Vasut
2019-10-14  8:00 ` [U-Boot] [RESEND PATCH 3/5] usb: host: dwc2: force reset assert Patrick Delaunay
2019-10-14 23:29   ` Marek Vasut [this message]
2019-11-06 18:27     ` Patrick DELAUNAY
2019-11-06 22:00       ` Marek Vasut
2019-11-08  9:53         ` Patrick DELAUNAY
2019-11-08  9:55           ` Marek Vasut
2019-11-08 10:51             ` Patrick DELAUNAY
2019-11-08 10:52               ` Marek Vasut
2019-10-14  8:00 ` [U-Boot] [RESEND PATCH 4/5] usb: host: dwc2: add usb33d supply support for stm32mp1 Patrick Delaunay
2019-10-14 23:31   ` Marek Vasut
2019-11-06 18:42     ` Patrick DELAUNAY
2019-10-14  8:00 ` [U-Boot] [RESEND PATCH 5/5] usb: host: dwc2: add trace to have clean usb start Patrick Delaunay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4a847ac-b675-6a85-4320-c4f3800c18b1@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.