From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 15 Oct 2019 01:29:57 +0200 Subject: [U-Boot] [RESEND PATCH 3/5] usb: host: dwc2: force reset assert In-Reply-To: <20191014080025.11245-4-patrick.delaunay@st.com> References: <20191014080025.11245-1-patrick.delaunay@st.com> <20191014080025.11245-4-patrick.delaunay@st.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/14/19 10:00 AM, Patrick Delaunay wrote: > Assert reset before deassert in dwc2_reset; > It should be more safe for DWC2. Can you be more descriptive about this issue ? I have no idea what this patch does or fixes from the description. > Signed-off-by: Patrick Delaunay > --- > > drivers/usb/host/dwc2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/host/dwc2.c b/drivers/usb/host/dwc2.c > index 51023b0c2c..3086411fc4 100644 > --- a/drivers/usb/host/dwc2.c > +++ b/drivers/usb/host/dwc2.c > @@ -1149,6 +1149,8 @@ static int dwc2_reset(struct udevice *dev) > return ret; > } > > + reset_assert_bulk(&priv->resets); > + udelay(2); Why is there a 2 uS delay ? > ret = reset_deassert_bulk(&priv->resets); > if (ret) { > reset_release_bulk(&priv->resets); > [...]