From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE3EC4361A for ; Thu, 3 Dec 2020 16:23:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B99D1207A5 for ; Thu, 3 Dec 2020 16:23:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436800AbgLCQXT (ORCPT ); Thu, 3 Dec 2020 11:23:19 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:55826 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436766AbgLCQXS (ORCPT ); Thu, 3 Dec 2020 11:23:18 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0B3GM93X012653; Thu, 3 Dec 2020 10:22:09 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1607012529; bh=S3AFaUzJoub60vRRyYRzulKzsuGYCd0b4YS/6BXU4Dc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=hwn3l4YL0YRj6YxNfaNfh5x4GsJiSCeWKe3dY0HiyfLmlAnxmzk1vEIsL5lxONW+G n95O7cNzNnq37qxWEQb9In92+gOcg0BF6gp0Os6UGEXQcbvHUyJOyh/Fx7v8ZMoKM0 llqiXQOwNhBzyZFxNySYLG/UGhdB5RsGoE7i1ouA= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0B3GM8aR127125 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Dec 2020 10:22:08 -0600 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 3 Dec 2020 10:22:07 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 3 Dec 2020 10:22:07 -0600 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0B3GM5r6078920; Thu, 3 Dec 2020 10:22:06 -0600 Subject: Re: [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support To: Andrew Lunn , Vignesh Raghavendra CC: "David S . Miller" , Jakub Kicinski , Jonathan Corbet , Jiri Pirko , , , , Linux ARM Mailing List References: <20201130082046.16292-1-vigneshr@ti.com> <20201130082046.16292-2-vigneshr@ti.com> <20201130155044.GE2073444@lunn.ch> <20201203141838.GE2333853@lunn.ch> From: Grygorii Strashko Message-ID: Date: Thu, 3 Dec 2020 18:22:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201203141838.GE2333853@lunn.ch> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/12/2020 16:18, Andrew Lunn wrote: >> We don't want to enable HW based switch support unless explicitly >> asked by user. > > This is the key point. Why? Does individual ports when passed through > the switch not work properly? Does it add extra latency/jitter? When switch mode is enabled the forwarding is enabled by default and can't be completely disabled, while in multi port mode every port and switch tables (ALE) configured so no packet leaking between ports is happen. The multi port is the requirement for us to have as default mode no mater to what upper interface ports are attached to LAG, LRE (HSR/PRP) or bridge. Switching between modes required significant Port and ALE reconfiguration there for technical decision made and implemented to use parameter for mode change (by using devlink). It also allows to keep user interface similar to what was implements for previous generation of TI CPSW (am3/4/5). -- Best regards, grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18401C433FE for ; Thu, 3 Dec 2020 16:23:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1DB0207B8 for ; Thu, 3 Dec 2020 16:23:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1DB0207B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=49G1y5Y4JrF8C135QJxGUPsrPOV+hUTepK6LTvWcfSM=; b=zBF9Om3Tea12fVp1bIDeIh226 CpWjFxoX4tf1weLZbLvh29tVznBz4CwFkxUAcyk83/DHeoNQ0SulyAVVRIb72+Uzp19mEYQvbpSIl sU81g9GftjqL2LqOJ+SXmNf96jM4PHD8Jri++Bhf41IMs8+cdMh23sEsLnoj9+p+I1UPAXn/Vvpti Fs6H9ISc3MHQFBs7+dFOvHlCa7WwJyqbX4fdLUh0UjqFLymFIPJQZpYAAmTqz8M3ji9aKDwHJm0dv cdUgPPgQbr1Ga8/8OSfKw3VwyvutEDq6OQY+bKYOQvJvv8WV1JKP/vD8q8oNBUqKlhh0KwyYhokMU ZiusS5ETA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkrN5-0004zT-D4; Thu, 03 Dec 2020 16:22:19 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkrN0-0004yf-Rq for linux-arm-kernel@lists.infradead.org; Thu, 03 Dec 2020 16:22:17 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0B3GM93X012653; Thu, 3 Dec 2020 10:22:09 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1607012529; bh=S3AFaUzJoub60vRRyYRzulKzsuGYCd0b4YS/6BXU4Dc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=hwn3l4YL0YRj6YxNfaNfh5x4GsJiSCeWKe3dY0HiyfLmlAnxmzk1vEIsL5lxONW+G n95O7cNzNnq37qxWEQb9In92+gOcg0BF6gp0Os6UGEXQcbvHUyJOyh/Fx7v8ZMoKM0 llqiXQOwNhBzyZFxNySYLG/UGhdB5RsGoE7i1ouA= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0B3GM8aR127125 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Dec 2020 10:22:08 -0600 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 3 Dec 2020 10:22:07 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 3 Dec 2020 10:22:07 -0600 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0B3GM5r6078920; Thu, 3 Dec 2020 10:22:06 -0600 Subject: Re: [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support To: Andrew Lunn , Vignesh Raghavendra References: <20201130082046.16292-1-vigneshr@ti.com> <20201130082046.16292-2-vigneshr@ti.com> <20201130155044.GE2073444@lunn.ch> <20201203141838.GE2333853@lunn.ch> From: Grygorii Strashko Message-ID: Date: Thu, 3 Dec 2020 18:22:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201203141838.GE2333853@lunn.ch> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201203_112215_101269_0BBB26A4 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, netdev@vger.kernel.org, Jonathan Corbet , linux-kernel@vger.kernel.org, Jiri Pirko , Jakub Kicinski , "David S . Miller" , Linux ARM Mailing List Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/12/2020 16:18, Andrew Lunn wrote: >> We don't want to enable HW based switch support unless explicitly >> asked by user. > > This is the key point. Why? Does individual ports when passed through > the switch not work properly? Does it add extra latency/jitter? When switch mode is enabled the forwarding is enabled by default and can't be completely disabled, while in multi port mode every port and switch tables (ALE) configured so no packet leaking between ports is happen. The multi port is the requirement for us to have as default mode no mater to what upper interface ports are attached to LAG, LRE (HSR/PRP) or bridge. Switching between modes required significant Port and ALE reconfiguration there for technical decision made and implemented to use parameter for mode change (by using devlink). It also allows to keep user interface similar to what was implements for previous generation of TI CPSW (am3/4/5). -- Best regards, grygorii _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel