From: Michael Heinemann <posted@heine.so>
To: Phil Reid <preid@electromag.com.au>
Cc: sre@kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/4] power: supply: sbs-battery: sort includes
Date: Tue, 11 Jul 2017 10:37:16 +0200 [thread overview]
Message-ID: <d4bd4cfbbbb4e26b62bc78f3f4c40ad1@heine.so> (raw)
In-Reply-To: <1499667800-69055-3-git-send-email-preid@electromag.com.au>
On 2017-07-10 08:23, Phil Reid wrote:
> Sort the header includes prior to adding to the list.
>
> Signed-off-by: Phil Reid <preid@electromag.com.au>
> ---
> drivers/power/supply/sbs-battery.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/power/supply/sbs-battery.c
> b/drivers/power/supply/sbs-battery.c
> index 15873df..4594ed1 100644
> --- a/drivers/power/supply/sbs-battery.c
> +++ b/drivers/power/supply/sbs-battery.c
> @@ -14,19 +14,18 @@
> * more details.
> */
>
> -#include <linux/init.h>
> -#include <linux/module.h>
> -#include <linux/kernel.h>
> #include <linux/err.h>
> -#include <linux/power_supply.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/i2c.h>
> -#include <linux/slab.h>
> +#include <linux/init.h>
> #include <linux/interrupt.h>
> -#include <linux/gpio/consumer.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/stat.h>
> -
> #include <linux/power/sbs-battery.h>
> +#include <linux/power_supply.h>
> +#include <linux/slab.h>
> +#include <linux/stat.h>
>
> enum {
> REG_MANUFACTURER_DATA,
> @@ -57,7 +56,7 @@ enum {
> #define BATTERY_MODE_MASK 0x8000
> enum sbs_battery_mode {
> BATTERY_MODE_AMPS = 0,
> - BATTERY_MODE_WATTS = 0x800
> + BATTERY_MODE_WATTS = 0x8000
> };
I guess the second chunk is in there by accident.
>
> /* manufacturer access defines */
next prev parent reply other threads:[~2017-07-11 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 6:23 [PATCH 0/4] power: supply: sbs-battery: Add delay when changing capacity mode Phil Reid
2017-07-10 6:23 ` [PATCH 1/4] power: supply: sbs-battery: Remove FSF mailing address from comments Phil Reid
2017-07-10 6:23 ` [PATCH 2/4] power: supply: sbs-battery: sort includes Phil Reid
2017-07-11 8:37 ` Michael Heinemann [this message]
2017-07-11 8:47 ` Phil Reid
2017-07-10 6:23 ` [PATCH 3/4] power: supply: sbs-battery: Add delay when changing capacity mode bit Phil Reid
2017-07-10 6:23 ` [PATCH 4/4] power: supply: sbs-battery: Don't reset mode in get_battery_capacity Phil Reid
2017-07-11 4:57 ` Phil Reid
2017-07-11 10:03 ` Michael Heinemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4bd4cfbbbb4e26b62bc78f3f4c40ad1@heine.so \
--to=posted@heine.so \
--cc=linux-pm@vger.kernel.org \
--cc=preid@electromag.com.au \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.