From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52D56C76186 for ; Wed, 17 Jul 2019 06:49:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09CF52173B for ; Wed, 17 Jul 2019 06:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727226AbfGQGtH (ORCPT ); Wed, 17 Jul 2019 02:49:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:58480 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725912AbfGQGtH (ORCPT ); Wed, 17 Jul 2019 02:49:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E867EACAE; Wed, 17 Jul 2019 06:49:05 +0000 (UTC) Subject: Re: [PATCH v8 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable To: Joe Perches , Zhenzhong Duan , linux-kernel@vger.kernel.org Cc: bp@alien8.de, sstabellini@kernel.org, x86@kernel.org, tglx@linutronix.de, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, mingo@redhat.com References: <1563251169-30740-1-git-send-email-zhenzhong.duan@oracle.com> <9791d12717bba784f24f35c29ddfaab9ccb78965.camel@perches.com> From: Juergen Gross Message-ID: Date: Wed, 17 Jul 2019 08:49:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <9791d12717bba784f24f35c29ddfaab9ccb78965.camel@perches.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.07.19 08:46, Joe Perches wrote: > On Tue, 2019-07-16 at 12:26 +0800, Zhenzhong Duan wrote: >> .. as "nopv" support needs it to be changeable at boot up stage. >> >> Checkpatch reports warning, so move variable declarations from >> hypervisor.c to hypervisor.h > [] >> diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c > [] >> @@ -259,7 +259,7 @@ static __init void xen_hvm_guest_late_init(void) >> #endif >> } >> >> -const __initconst struct hypervisor_x86 x86_hyper_xen_hvm = { >> +struct hypervisor_x86 x86_hyper_xen_hvm __initdata = { > > static? It is being referenced from arch/x86/kernel/cpu/hypervisor.c Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1021C76195 for ; Wed, 17 Jul 2019 06:49:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE30D2173B for ; Wed, 17 Jul 2019 06:49:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE30D2173B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hndkU-0006j3-1L; Wed, 17 Jul 2019 06:49:10 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hndkS-0006iv-99 for xen-devel@lists.xenproject.org; Wed, 17 Jul 2019 06:49:08 +0000 X-Inumbo-ID: f8c8eeba-a85e-11e9-8980-bc764e045a96 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id f8c8eeba-a85e-11e9-8980-bc764e045a96; Wed, 17 Jul 2019 06:49:07 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E867EACAE; Wed, 17 Jul 2019 06:49:05 +0000 (UTC) To: Joe Perches , Zhenzhong Duan , linux-kernel@vger.kernel.org References: <1563251169-30740-1-git-send-email-zhenzhong.duan@oracle.com> <9791d12717bba784f24f35c29ddfaab9ccb78965.camel@perches.com> From: Juergen Gross Message-ID: Date: Wed, 17 Jul 2019 08:49:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <9791d12717bba784f24f35c29ddfaab9ccb78965.camel@perches.com> Content-Language: de-DE Subject: Re: [Xen-devel] [PATCH v8 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, x86@kernel.org, mingo@redhat.com, bp@alien8.de, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, tglx@linutronix.de Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMTcuMDcuMTkgMDg6NDYsIEpvZSBQZXJjaGVzIHdyb3RlOgo+IE9uIFR1ZSwgMjAxOS0wNy0x NiBhdCAxMjoyNiArMDgwMCwgWmhlbnpob25nIER1YW4gd3JvdGU6Cj4+IC4uIGFzICJub3B2IiBz dXBwb3J0IG5lZWRzIGl0IHRvIGJlIGNoYW5nZWFibGUgYXQgYm9vdCB1cCBzdGFnZS4KPj4KPj4g Q2hlY2twYXRjaCByZXBvcnRzIHdhcm5pbmcsIHNvIG1vdmUgdmFyaWFibGUgZGVjbGFyYXRpb25z IGZyb20KPj4gaHlwZXJ2aXNvci5jIHRvIGh5cGVydmlzb3IuaAo+IFtdCj4+IGRpZmYgLS1naXQg YS9hcmNoL3g4Ni94ZW4vZW5saWdodGVuX2h2bS5jIGIvYXJjaC94ODYveGVuL2VubGlnaHRlbl9o dm0uYwo+IFtdCj4+IEBAIC0yNTksNyArMjU5LDcgQEAgc3RhdGljIF9faW5pdCB2b2lkIHhlbl9o dm1fZ3Vlc3RfbGF0ZV9pbml0KHZvaWQpCj4+ICAgI2VuZGlmCj4+ICAgfQo+PiAgIAo+PiAtY29u c3QgX19pbml0Y29uc3Qgc3RydWN0IGh5cGVydmlzb3JfeDg2IHg4Nl9oeXBlcl94ZW5faHZtID0g ewo+PiArc3RydWN0IGh5cGVydmlzb3JfeDg2IHg4Nl9oeXBlcl94ZW5faHZtIF9faW5pdGRhdGEg PSB7Cj4gCj4gc3RhdGljPwoKSXQgaXMgYmVpbmcgcmVmZXJlbmNlZCBmcm9tIGFyY2gveDg2L2tl cm5lbC9jcHUvaHlwZXJ2aXNvci5jCgoKSnVlcmdlbgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hlbi1kZXZlbA==