From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C8CC4332F for ; Tue, 29 Mar 2022 13:14:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237168AbiC2NQP (ORCPT ); Tue, 29 Mar 2022 09:16:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230181AbiC2NQM (ORCPT ); Tue, 29 Mar 2022 09:16:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09CAC639B; Tue, 29 Mar 2022 06:14:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 20FE86154F; Tue, 29 Mar 2022 13:14:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04873C2BBE4; Tue, 29 Mar 2022 13:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648559668; bh=BUiGfVpPE2VIxewXuuuW8TDfj0IZzmLt4jyDJzc1e4U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PFKK2Ka2bFipYV22HyUJrbCDmogkwW+lH79Dg+PzXreiSriWdCq93ecnnzo89S/dj zrr/xhohQhOTYaTGNu5Nx8Wpk2kt1d+jnvUn1MvV2Zi2XYSEqmaRWjCBrCpdMstBXV PvwwDvXA3xOk+a7K8ardNiyCNM9VHkz7UPuERDZ26bCknQk38AKdO9B8DNYDHqgTDR Z6Oah3FflPvUgl0WdZm4yfaUOkWyS+wiMQxbz9camg5juIzOmjLcBlpDiTUvEohMm0 sQsvTPlMTX2B4tIBJckvDK536G8BEDXT7wbXtc916DKWj6YsA0L3pWBaRiEpQEl2sE MqwS7XwTcSm4A== Message-ID: Date: Tue, 29 Mar 2022 15:14:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 2/2] dt-bindings: mmc: xenon: Convert to JSON schema Content-Language: en-US To: Rob Herring , Chris Packham Cc: andrew@lunn.ch, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk+dt@kernel.org, huziji@marvell.com, robh+dt@kernel.org, devicetree@vger.kernel.org References: <20220329000231.3544810-1-chris.packham@alliedtelesis.co.nz> <20220329000231.3544810-3-chris.packham@alliedtelesis.co.nz> <1648554629.870840.350362.nullmailer@robh.at.kernel.org> From: Krzysztof Kozlowski In-Reply-To: <1648554629.870840.350362.nullmailer@robh.at.kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/03/2022 13:50, Rob Herring wrote: > On Tue, 29 Mar 2022 13:02:31 +1300, Chris Packham wrote: >> Convert the marvell,xenon-sdhci binding to JSON schema. Currently the >> in-tree dts files don't validate because they use sdhci@ instead of mmc@ >> as required by the generic mmc-controller schema. >> >> The compatible "marvell,sdhci-xenon" was not documented in the old >> binding but it accompanies the of "marvell,armada-3700-sdhci" in the >> armada-37xx SoC dtsi so this combination is added to the new binding >> document. >> >> Signed-off-by: Chris Packham >> Reviewed-by: Krzysztof Kozlowski >> --- >> >> Notes: >> Changes in v4: >> - Add review from Krzysztof >> - Squash in addition of marvell,sdhci-xenon with an explanation in the >> commit message >> Changes in v3: >> - Don't accept ap807 without ap806 >> - Add ref: string for pad-type >> Changes in v2: >> - Update MAINTAINERS entry >> - Incorporate feedback from Krzysztof >> >> .../bindings/mmc/marvell,xenon-sdhci.txt | 173 ----------- >> .../bindings/mmc/marvell,xenon-sdhci.yaml | 275 ++++++++++++++++++ >> MAINTAINERS | 2 +- >> 3 files changed, 276 insertions(+), 174 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt >> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@aa0000: compatible: 'oneOf' conditional failed, one must be fixed: > ['marvell,armada-3700-sdhci'] is too short > 'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci'] > 'marvell,armada-ap807-sdhci' was expected > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@ab0000: compatible: 'oneOf' conditional failed, one must be fixed: > ['marvell,armada-3700-sdhci'] is too short > 'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci'] > 'marvell,armada-ap807-sdhci' was expected > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > > doc reference errors (make refcheckdocs): Chris, your own dt binding does not pass it's check (example)... After updating the compatibles, you need to check the example. The examples are anyway duplicating common stuff, so half of them could be removed. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D23DC433EF for ; Tue, 29 Mar 2022 13:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0gyPIJDLVCqZER+O3rKd+4Jhj+tfHMizKxXt6M5LN+I=; b=xe1JgkKAWEDlKH 1tSory0sbhhquwpSYYbogvVcvELJU8NfLYEBWQ2/TUFpLBIi2i/oPNuU+m1ivyD9I5NTnO2eC98dI QOrI0Jk+u7T3ke/0U7QRf1wxWei9jk+alXjee4yutgcRaPA1xT4g//8bkgnQaUTnT55sCleMk5G8o F7hyh/30tzJM1Kc9yZPfdBCpdJVGsFDJAvv1kO3GPv4wDOgwUl2p8t1Y+OFf3fJa6HIrH3Ax9kPWa C0kgGQhjQtEKxbSRz1POa01KBSbPHtKs7BNb3WToiKgs1XsnnxaI6l8NaODRlbtKCcAFsFYrrUpZB spNTnAf7fQEBtWqMekhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZBgC-00CJKX-2N; Tue, 29 Mar 2022 13:14:36 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZBg7-00CJIw-Pn for linux-arm-kernel@lists.infradead.org; Tue, 29 Mar 2022 13:14:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D2069B81751; Tue, 29 Mar 2022 13:14:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04873C2BBE4; Tue, 29 Mar 2022 13:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648559668; bh=BUiGfVpPE2VIxewXuuuW8TDfj0IZzmLt4jyDJzc1e4U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PFKK2Ka2bFipYV22HyUJrbCDmogkwW+lH79Dg+PzXreiSriWdCq93ecnnzo89S/dj zrr/xhohQhOTYaTGNu5Nx8Wpk2kt1d+jnvUn1MvV2Zi2XYSEqmaRWjCBrCpdMstBXV PvwwDvXA3xOk+a7K8ardNiyCNM9VHkz7UPuERDZ26bCknQk38AKdO9B8DNYDHqgTDR Z6Oah3FflPvUgl0WdZm4yfaUOkWyS+wiMQxbz9camg5juIzOmjLcBlpDiTUvEohMm0 sQsvTPlMTX2B4tIBJckvDK536G8BEDXT7wbXtc916DKWj6YsA0L3pWBaRiEpQEl2sE MqwS7XwTcSm4A== Message-ID: Date: Tue, 29 Mar 2022 15:14:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 2/2] dt-bindings: mmc: xenon: Convert to JSON schema Content-Language: en-US To: Rob Herring , Chris Packham Cc: andrew@lunn.ch, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk+dt@kernel.org, huziji@marvell.com, robh+dt@kernel.org, devicetree@vger.kernel.org References: <20220329000231.3544810-1-chris.packham@alliedtelesis.co.nz> <20220329000231.3544810-3-chris.packham@alliedtelesis.co.nz> <1648554629.870840.350362.nullmailer@robh.at.kernel.org> From: Krzysztof Kozlowski In-Reply-To: <1648554629.870840.350362.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220329_061432_163131_F6C60599 X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/03/2022 13:50, Rob Herring wrote: > On Tue, 29 Mar 2022 13:02:31 +1300, Chris Packham wrote: >> Convert the marvell,xenon-sdhci binding to JSON schema. Currently the >> in-tree dts files don't validate because they use sdhci@ instead of mmc@ >> as required by the generic mmc-controller schema. >> >> The compatible "marvell,sdhci-xenon" was not documented in the old >> binding but it accompanies the of "marvell,armada-3700-sdhci" in the >> armada-37xx SoC dtsi so this combination is added to the new binding >> document. >> >> Signed-off-by: Chris Packham >> Reviewed-by: Krzysztof Kozlowski >> --- >> >> Notes: >> Changes in v4: >> - Add review from Krzysztof >> - Squash in addition of marvell,sdhci-xenon with an explanation in the >> commit message >> Changes in v3: >> - Don't accept ap807 without ap806 >> - Add ref: string for pad-type >> Changes in v2: >> - Update MAINTAINERS entry >> - Incorporate feedback from Krzysztof >> >> .../bindings/mmc/marvell,xenon-sdhci.txt | 173 ----------- >> .../bindings/mmc/marvell,xenon-sdhci.yaml | 275 ++++++++++++++++++ >> MAINTAINERS | 2 +- >> 3 files changed, 276 insertions(+), 174 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt >> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@aa0000: compatible: 'oneOf' conditional failed, one must be fixed: > ['marvell,armada-3700-sdhci'] is too short > 'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci'] > 'marvell,armada-ap807-sdhci' was expected > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@ab0000: compatible: 'oneOf' conditional failed, one must be fixed: > ['marvell,armada-3700-sdhci'] is too short > 'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci'] > 'marvell,armada-ap807-sdhci' was expected > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > > doc reference errors (make refcheckdocs): Chris, your own dt binding does not pass it's check (example)... After updating the compatibles, you need to check the example. The examples are anyway duplicating common stuff, so half of them could be removed. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel