From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CDA8C433EF for ; Mon, 17 Jan 2022 09:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235713AbiAQJ2r (ORCPT ); Mon, 17 Jan 2022 04:28:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235696AbiAQJ2p (ORCPT ); Mon, 17 Jan 2022 04:28:45 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFCEBC06161C; Mon, 17 Jan 2022 01:28:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A061EB80E6C; Mon, 17 Jan 2022 09:28:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C524C36AE3; Mon, 17 Jan 2022 09:28:40 +0000 (UTC) Message-ID: Date: Mon, 17 Jan 2022 10:28:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v8 1/4] media: v4l: Add definition for the Aspeed JPEG format Content-Language: en-US To: Jammy Huang , Joel Stanley Cc: "sakari.ailus@linux.intel.com" , "gregkh@linuxfoundation.org" , "eajames@linux.ibm.com" , "mchehab@kernel.org" , "andrew@aj.id.au" , "linux-media@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20211224012738.1551-1-jammy_huang@aspeedtech.com> <20211224012738.1551-2-jammy_huang@aspeedtech.com> <703ff71e-c76a-9df1-c644-04efed0199ca@xs4all.nl> <609cfe9e-2fd8-b31a-9d71-b83d61693f84@aspeedtech.com> <98096e97-68cc-18fd-d2b6-3477f57f05bd@aspeedtech.com> From: Hans Verkuil In-Reply-To: <98096e97-68cc-18fd-d2b6-3477f57f05bd@aspeedtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jammy, On 1/17/22 08:18, Jammy Huang wrote: > On 2022/1/17 上午 10:24, Joel Stanley wrote: >> On Mon, 17 Jan 2022 at 02:00, Jammy Huang wrote: >>> Hi Hans, >>> >>> On 2022/1/14 下午 04:11, Hans Verkuil wrote: >>>> On 24/12/2021 02:27, Jammy Huang wrote: >>>>> This introduces support for the Aspeed JPEG format, where the new frame >>>>> can refer to previous frame to reduce the amount of compressed data. The >>>>> concept is similar to I/P frame of video compression. It will compare the >>>>> new frame with previous one to decide which macroblock's data is >>>>> changed, and only the changed macroblocks will be compressed. >>>>> >>>>> This Aspeed JPEG format is used by the video engine on Aspeed platforms, >>>>> which is generally adapted for remote KVM. >>>>> >>>>> Signed-off-by: Jammy Huang >>>>> --- >>>>> v8: >>>>>     - Add decoder information for aspeed-jpeg >>>>> v7: >>>>>     - Add more information for aspeed-jpeg >>>>> v6: >>>>>     - Update description for new format, aspeed-jpeg, in Documentation. >>>>> v5: >>>>>     - no update >>>>> v4: >>>>>     - new >>>>> --- >>>>>    .../media/uapi/v4l/pixfmt-reserved.rst          | 17 +++++++++++++++++ >>>>>    drivers/media/v4l2-core/v4l2-ioctl.c            |  1 + >>>>>    include/uapi/linux/videodev2.h                  |  1 + >>>>>    3 files changed, 19 insertions(+) >>>>> >>>>> diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/uapi/v4l/pixfmt-reserved.rst >>>> This is the wrong file! It should be: >>>> >>>> Documentation/userspace-api/media/v4l/pixfmt-reserved.rst >>> Thanks, I just used git format-patch to generate the cover-letter and >>> didn't notice this. >>> >>> It looks like the file, pixfmt-reserved.rst, has different path in >>> different Linux kernel, >>> >>> * 5.4:           Documentation/media/uapi/v4l/pixfmt-reserved.rst >>> >>> * 5.10/5.15: Documentation/userspace-api/media/v4l/pixfmt-reserved.rst >>> >>> 5.4 is the one I based to submit the patches. >>> >>> Could you suggest the kernel that I should based to submit these patches?? >> You should always submit based on the latest release. >> >> There are sometimes exceptions where you will base your patches on >> something even newer, but generally you should grab the latest. >> >> Be sure to re-test on the latest kernel before submitting. > OK, thank you. I recommend waiting until later this week. I hope to have a PR for other outstanding aspeed patches ready in a few days. It is easiest if you base your v9 on top of that series, this to avoid merge conflicts. Regards, Hans >> >> Cheers, >> >> Joel >> >>> I will need to change the number of V4L2_CID_USER_ASPEED_BASE per different >>> >>> linux kernel as well. >>> >>>> Regards, >>>> >>>>        Hans >>>> >>>>> index b2cd155e691b..1d0dc8d86ed7 100644 >>>>> --- a/Documentation/media/uapi/v4l/pixfmt-reserved.rst >>>>> +++ b/Documentation/media/uapi/v4l/pixfmt-reserved.rst >>>>> @@ -264,6 +264,23 @@ please make a proposal on the linux-media mailing list. >>>>>       of tiles, resulting in 32-aligned resolutions for the luminance plane >>>>>       and 16-aligned resolutions for the chrominance plane (with 2x2 >>>>>       subsampling). >>>>> +    * .. _V4L2-PIX-FMT-AJPG: >>>>> + >>>>> +      - ``V4L2_PIX_FMT_AJPG`` >>>>> +      - 'AJPG' >>>>> +      - ASPEED JPEG format used by the aspeed-video driver on Aspeed platforms, >>>>> +        which is generally adapted for remote KVM. >>>>> +        On each frame compression, I will compare the new frame with previous >>>>> +        one to decide which macroblock's data is changed, and only the changed >>>>> +        macroblocks will be compressed. >>>>> + >>>>> +        The implementation is based on AST2600 A3 datasheet, revision 0.9, which >>>>> +        is not publicly available. Or you can reference Video stream data format >>>>> +        – ASPEED mode compression of SDK_User_Guide which available on >>>>> +        AspeedTech-BMC/openbmc/releases. >>>>> + >>>>> +        Decoder's implementation can be found here, >>>>> +        `https://github.com/AspeedTech-BMC/aspeed_codec/ `__ >>>>> >>>>>    .. tabularcolumns:: |p{6.6cm}|p{2.2cm}|p{8.7cm}| >>>>> >>>>> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c >>>>> index 24db33f803c0..00dde01d2f97 100644 >>>>> --- a/drivers/media/v4l2-core/v4l2-ioctl.c >>>>> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c >>>>> @@ -1378,6 +1378,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) >>>>>               case V4L2_PIX_FMT_S5C_UYVY_JPG: descr = "S5C73MX interleaved UYVY/JPEG"; break; >>>>>               case V4L2_PIX_FMT_MT21C:        descr = "Mediatek Compressed Format"; break; >>>>>               case V4L2_PIX_FMT_SUNXI_TILED_NV12: descr = "Sunxi Tiled NV12 Format"; break; >>>>> +            case V4L2_PIX_FMT_AJPG:         descr = "Aspeed JPEG"; break; >>>>>               default: >>>>>                       if (fmt->description[0]) >>>>>                               return; >>>>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h >>>>> index 3210b3c82a4a..994eb6155ea9 100644 >>>>> --- a/include/uapi/linux/videodev2.h >>>>> +++ b/include/uapi/linux/videodev2.h >>>>> @@ -726,6 +726,7 @@ struct v4l2_pix_format { >>>>>    #define V4L2_PIX_FMT_INZI     v4l2_fourcc('I', 'N', 'Z', 'I') /* Intel Planar Greyscale 10-bit and Depth 16-bit */ >>>>>    #define V4L2_PIX_FMT_SUNXI_TILED_NV12 v4l2_fourcc('S', 'T', '1', '2') /* Sunxi Tiled NV12 Format */ >>>>>    #define V4L2_PIX_FMT_CNF4     v4l2_fourcc('C', 'N', 'F', '4') /* Intel 4-bit packed depth confidence information */ >>>>> +#define V4L2_PIX_FMT_AJPG     v4l2_fourcc('A', 'J', 'P', 'G') /* Aspeed JPEG */ >>>>> >>>>>    /* 10bit raw bayer packed, 32 bytes for every 25 pixels, last LSB 6 bits unused */ >>>>>    #define V4L2_PIX_FMT_IPU3_SBGGR10  v4l2_fourcc('i', 'p', '3', 'b') /* IPU3 packed 10-bit BGGR bayer */ >>> -- >>> Best Regards >>> Jammy >>> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DDA9C433EF for ; Mon, 17 Jan 2022 09:29:16 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JcmnQ6Bqjz30MQ for ; Mon, 17 Jan 2022 20:29:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=srs0=rstl=sb=xs4all.nl=hverkuil-cisco@kernel.org; receiver=) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Jcmmt2Vlsz2yJV; Mon, 17 Jan 2022 20:28:46 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 030AC61117; Mon, 17 Jan 2022 09:28:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C524C36AE3; Mon, 17 Jan 2022 09:28:40 +0000 (UTC) Message-ID: Date: Mon, 17 Jan 2022 10:28:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v8 1/4] media: v4l: Add definition for the Aspeed JPEG format Content-Language: en-US To: Jammy Huang , Joel Stanley References: <20211224012738.1551-1-jammy_huang@aspeedtech.com> <20211224012738.1551-2-jammy_huang@aspeedtech.com> <703ff71e-c76a-9df1-c644-04efed0199ca@xs4all.nl> <609cfe9e-2fd8-b31a-9d71-b83d61693f84@aspeedtech.com> <98096e97-68cc-18fd-d2b6-3477f57f05bd@aspeedtech.com> From: Hans Verkuil In-Reply-To: <98096e97-68cc-18fd-d2b6-3477f57f05bd@aspeedtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-aspeed@lists.ozlabs.org" , "andrew@aj.id.au" , "gregkh@linuxfoundation.org" , "openbmc@lists.ozlabs.org" , "eajames@linux.ibm.com" , "linux-kernel@vger.kernel.org" , "sakari.ailus@linux.intel.com" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Jammy, On 1/17/22 08:18, Jammy Huang wrote: > On 2022/1/17 上午 10:24, Joel Stanley wrote: >> On Mon, 17 Jan 2022 at 02:00, Jammy Huang wrote: >>> Hi Hans, >>> >>> On 2022/1/14 下午 04:11, Hans Verkuil wrote: >>>> On 24/12/2021 02:27, Jammy Huang wrote: >>>>> This introduces support for the Aspeed JPEG format, where the new frame >>>>> can refer to previous frame to reduce the amount of compressed data. The >>>>> concept is similar to I/P frame of video compression. It will compare the >>>>> new frame with previous one to decide which macroblock's data is >>>>> changed, and only the changed macroblocks will be compressed. >>>>> >>>>> This Aspeed JPEG format is used by the video engine on Aspeed platforms, >>>>> which is generally adapted for remote KVM. >>>>> >>>>> Signed-off-by: Jammy Huang >>>>> --- >>>>> v8: >>>>>     - Add decoder information for aspeed-jpeg >>>>> v7: >>>>>     - Add more information for aspeed-jpeg >>>>> v6: >>>>>     - Update description for new format, aspeed-jpeg, in Documentation. >>>>> v5: >>>>>     - no update >>>>> v4: >>>>>     - new >>>>> --- >>>>>    .../media/uapi/v4l/pixfmt-reserved.rst          | 17 +++++++++++++++++ >>>>>    drivers/media/v4l2-core/v4l2-ioctl.c            |  1 + >>>>>    include/uapi/linux/videodev2.h                  |  1 + >>>>>    3 files changed, 19 insertions(+) >>>>> >>>>> diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/uapi/v4l/pixfmt-reserved.rst >>>> This is the wrong file! It should be: >>>> >>>> Documentation/userspace-api/media/v4l/pixfmt-reserved.rst >>> Thanks, I just used git format-patch to generate the cover-letter and >>> didn't notice this. >>> >>> It looks like the file, pixfmt-reserved.rst, has different path in >>> different Linux kernel, >>> >>> * 5.4:           Documentation/media/uapi/v4l/pixfmt-reserved.rst >>> >>> * 5.10/5.15: Documentation/userspace-api/media/v4l/pixfmt-reserved.rst >>> >>> 5.4 is the one I based to submit the patches. >>> >>> Could you suggest the kernel that I should based to submit these patches?? >> You should always submit based on the latest release. >> >> There are sometimes exceptions where you will base your patches on >> something even newer, but generally you should grab the latest. >> >> Be sure to re-test on the latest kernel before submitting. > OK, thank you. I recommend waiting until later this week. I hope to have a PR for other outstanding aspeed patches ready in a few days. It is easiest if you base your v9 on top of that series, this to avoid merge conflicts. Regards, Hans >> >> Cheers, >> >> Joel >> >>> I will need to change the number of V4L2_CID_USER_ASPEED_BASE per different >>> >>> linux kernel as well. >>> >>>> Regards, >>>> >>>>        Hans >>>> >>>>> index b2cd155e691b..1d0dc8d86ed7 100644 >>>>> --- a/Documentation/media/uapi/v4l/pixfmt-reserved.rst >>>>> +++ b/Documentation/media/uapi/v4l/pixfmt-reserved.rst >>>>> @@ -264,6 +264,23 @@ please make a proposal on the linux-media mailing list. >>>>>       of tiles, resulting in 32-aligned resolutions for the luminance plane >>>>>       and 16-aligned resolutions for the chrominance plane (with 2x2 >>>>>       subsampling). >>>>> +    * .. _V4L2-PIX-FMT-AJPG: >>>>> + >>>>> +      - ``V4L2_PIX_FMT_AJPG`` >>>>> +      - 'AJPG' >>>>> +      - ASPEED JPEG format used by the aspeed-video driver on Aspeed platforms, >>>>> +        which is generally adapted for remote KVM. >>>>> +        On each frame compression, I will compare the new frame with previous >>>>> +        one to decide which macroblock's data is changed, and only the changed >>>>> +        macroblocks will be compressed. >>>>> + >>>>> +        The implementation is based on AST2600 A3 datasheet, revision 0.9, which >>>>> +        is not publicly available. Or you can reference Video stream data format >>>>> +        – ASPEED mode compression of SDK_User_Guide which available on >>>>> +        AspeedTech-BMC/openbmc/releases. >>>>> + >>>>> +        Decoder's implementation can be found here, >>>>> +        `https://github.com/AspeedTech-BMC/aspeed_codec/ `__ >>>>> >>>>>    .. tabularcolumns:: |p{6.6cm}|p{2.2cm}|p{8.7cm}| >>>>> >>>>> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c >>>>> index 24db33f803c0..00dde01d2f97 100644 >>>>> --- a/drivers/media/v4l2-core/v4l2-ioctl.c >>>>> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c >>>>> @@ -1378,6 +1378,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) >>>>>               case V4L2_PIX_FMT_S5C_UYVY_JPG: descr = "S5C73MX interleaved UYVY/JPEG"; break; >>>>>               case V4L2_PIX_FMT_MT21C:        descr = "Mediatek Compressed Format"; break; >>>>>               case V4L2_PIX_FMT_SUNXI_TILED_NV12: descr = "Sunxi Tiled NV12 Format"; break; >>>>> +            case V4L2_PIX_FMT_AJPG:         descr = "Aspeed JPEG"; break; >>>>>               default: >>>>>                       if (fmt->description[0]) >>>>>                               return; >>>>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h >>>>> index 3210b3c82a4a..994eb6155ea9 100644 >>>>> --- a/include/uapi/linux/videodev2.h >>>>> +++ b/include/uapi/linux/videodev2.h >>>>> @@ -726,6 +726,7 @@ struct v4l2_pix_format { >>>>>    #define V4L2_PIX_FMT_INZI     v4l2_fourcc('I', 'N', 'Z', 'I') /* Intel Planar Greyscale 10-bit and Depth 16-bit */ >>>>>    #define V4L2_PIX_FMT_SUNXI_TILED_NV12 v4l2_fourcc('S', 'T', '1', '2') /* Sunxi Tiled NV12 Format */ >>>>>    #define V4L2_PIX_FMT_CNF4     v4l2_fourcc('C', 'N', 'F', '4') /* Intel 4-bit packed depth confidence information */ >>>>> +#define V4L2_PIX_FMT_AJPG     v4l2_fourcc('A', 'J', 'P', 'G') /* Aspeed JPEG */ >>>>> >>>>>    /* 10bit raw bayer packed, 32 bytes for every 25 pixels, last LSB 6 bits unused */ >>>>>    #define V4L2_PIX_FMT_IPU3_SBGGR10  v4l2_fourcc('i', 'p', '3', 'b') /* IPU3 packed 10-bit BGGR bayer */ >>> -- >>> Best Regards >>> Jammy >>> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 129C7C433F5 for ; Mon, 17 Jan 2022 09:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ioBrMG2V/4VHDPlV+CNwgYCj0lmeXP1g2OXyrjP5DaY=; b=3dHW2vJ/zXO6ea Uh14JW9U4n2z3GPwDor1XYSZBFn+D6kM0oFMkzwF6fdUMUur76cTkA8Dk/zZ7mOh3XBvHJ6CCN5vM r7r7uTxmWQK9OirJQcnz50Pdp9rRvgcP0DkFLjxbN3Y64b1K5XuUHDvh6jFa+b7q/VWrTe96gLCVa CWtjZ8RzwRkg/H8Ws4hPzszVs/2erun1u6eR/lDQKVTSmuDCmKHQTHWS9WC1zzqD6t7VTxG9gj8Uz MW+nkM1FGgTbLbKb1887kWXjdqrmrjRyV2ARLzhkXPhn2itaqFZZQuIjauXuqVJitfSDwUVd8VQfp D165hzTCMiG7UsntyHMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9OJn-00EG5O-Js; Mon, 17 Jan 2022 09:28:51 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9OJg-00EG3u-28 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jan 2022 09:28:49 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 030AC61117; Mon, 17 Jan 2022 09:28:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C524C36AE3; Mon, 17 Jan 2022 09:28:40 +0000 (UTC) Message-ID: Date: Mon, 17 Jan 2022 10:28:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v8 1/4] media: v4l: Add definition for the Aspeed JPEG format Content-Language: en-US To: Jammy Huang , Joel Stanley Cc: "sakari.ailus@linux.intel.com" , "gregkh@linuxfoundation.org" , "eajames@linux.ibm.com" , "mchehab@kernel.org" , "andrew@aj.id.au" , "linux-media@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20211224012738.1551-1-jammy_huang@aspeedtech.com> <20211224012738.1551-2-jammy_huang@aspeedtech.com> <703ff71e-c76a-9df1-c644-04efed0199ca@xs4all.nl> <609cfe9e-2fd8-b31a-9d71-b83d61693f84@aspeedtech.com> <98096e97-68cc-18fd-d2b6-3477f57f05bd@aspeedtech.com> From: Hans Verkuil In-Reply-To: <98096e97-68cc-18fd-d2b6-3477f57f05bd@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_012844_227771_34A0E096 X-CRM114-Status: GOOD ( 23.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFtbXksCgpPbiAxLzE3LzIyIDA4OjE4LCBKYW1teSBIdWFuZyB3cm90ZToKPiBPbiAyMDIy LzEvMTcg5LiK5Y2IIDEwOjI0LCBKb2VsIFN0YW5sZXkgd3JvdGU6Cj4+IE9uIE1vbiwgMTcgSmFu IDIwMjIgYXQgMDI6MDAsIEphbW15IEh1YW5nIDxqYW1teV9odWFuZ0Bhc3BlZWR0ZWNoLmNvbT4g d3JvdGU6Cj4+PiBIaSBIYW5zLAo+Pj4KPj4+IE9uIDIwMjIvMS8xNCDkuIvljYggMDQ6MTEsIEhh bnMgVmVya3VpbCB3cm90ZToKPj4+PiBPbiAyNC8xMi8yMDIxIDAyOjI3LCBKYW1teSBIdWFuZyB3 cm90ZToKPj4+Pj4gVGhpcyBpbnRyb2R1Y2VzIHN1cHBvcnQgZm9yIHRoZSBBc3BlZWQgSlBFRyBm b3JtYXQsIHdoZXJlIHRoZSBuZXcgZnJhbWUKPj4+Pj4gY2FuIHJlZmVyIHRvIHByZXZpb3VzIGZy YW1lIHRvIHJlZHVjZSB0aGUgYW1vdW50IG9mIGNvbXByZXNzZWQgZGF0YS4gVGhlCj4+Pj4+IGNv bmNlcHQgaXMgc2ltaWxhciB0byBJL1AgZnJhbWUgb2YgdmlkZW8gY29tcHJlc3Npb24uIEl0IHdp bGwgY29tcGFyZSB0aGUKPj4+Pj4gbmV3IGZyYW1lIHdpdGggcHJldmlvdXMgb25lIHRvIGRlY2lk ZSB3aGljaCBtYWNyb2Jsb2NrJ3MgZGF0YSBpcwo+Pj4+PiBjaGFuZ2VkLCBhbmQgb25seSB0aGUg Y2hhbmdlZCBtYWNyb2Jsb2NrcyB3aWxsIGJlIGNvbXByZXNzZWQuCj4+Pj4+Cj4+Pj4+IFRoaXMg QXNwZWVkIEpQRUcgZm9ybWF0IGlzIHVzZWQgYnkgdGhlIHZpZGVvIGVuZ2luZSBvbiBBc3BlZWQg cGxhdGZvcm1zLAo+Pj4+PiB3aGljaCBpcyBnZW5lcmFsbHkgYWRhcHRlZCBmb3IgcmVtb3RlIEtW TS4KPj4+Pj4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogSmFtbXkgSHVhbmcgPGphbW15X2h1YW5nQGFz cGVlZHRlY2guY29tPgo+Pj4+PiAtLS0KPj4+Pj4gdjg6Cj4+Pj4+IMKgwqDCoCAtIEFkZCBkZWNv ZGVyIGluZm9ybWF0aW9uIGZvciBhc3BlZWQtanBlZwo+Pj4+PiB2NzoKPj4+Pj4gwqDCoMKgIC0g QWRkIG1vcmUgaW5mb3JtYXRpb24gZm9yIGFzcGVlZC1qcGVnCj4+Pj4+IHY2Ogo+Pj4+PiDCoMKg wqAgLSBVcGRhdGUgZGVzY3JpcHRpb24gZm9yIG5ldyBmb3JtYXQsIGFzcGVlZC1qcGVnLCBpbiBE b2N1bWVudGF0aW9uLgo+Pj4+PiB2NToKPj4+Pj4gwqDCoMKgIC0gbm8gdXBkYXRlCj4+Pj4+IHY0 Ogo+Pj4+PiDCoMKgwqAgLSBuZXcKPj4+Pj4gLS0tCj4+Pj4+IMKgwqAgLi4uL21lZGlhL3VhcGkv djRsL3BpeGZtdC1yZXNlcnZlZC5yc3TCoMKgwqDCoMKgwqDCoMKgwqAgfCAxNyArKysrKysrKysr KysrKysrKwo+Pj4+PiDCoMKgIGRyaXZlcnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDItaW9jdGwuY8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgIDEgKwo+Pj4+PiDCoMKgIGluY2x1ZGUvdWFwaS9saW51 eC92aWRlb2RldjIuaMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgIDEgKwo+ Pj4+PiDCoMKgIDMgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKQo+Pj4+Pgo+Pj4+PiBk aWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9tZWRpYS91YXBpL3Y0bC9waXhmbXQtcmVzZXJ2ZWQu cnN0IGIvRG9jdW1lbnRhdGlvbi9tZWRpYS91YXBpL3Y0bC9waXhmbXQtcmVzZXJ2ZWQucnN0Cj4+ Pj4gVGhpcyBpcyB0aGUgd3JvbmcgZmlsZSEgSXQgc2hvdWxkIGJlOgo+Pj4+Cj4+Pj4gRG9jdW1l bnRhdGlvbi91c2Vyc3BhY2UtYXBpL21lZGlhL3Y0bC9waXhmbXQtcmVzZXJ2ZWQucnN0Cj4+PiBU aGFua3MsIEkganVzdCB1c2VkIGdpdCBmb3JtYXQtcGF0Y2ggdG8gZ2VuZXJhdGUgdGhlIGNvdmVy LWxldHRlciBhbmQKPj4+IGRpZG4ndCBub3RpY2UgdGhpcy4KPj4+Cj4+PiBJdCBsb29rcyBsaWtl IHRoZSBmaWxlLCBwaXhmbXQtcmVzZXJ2ZWQucnN0LCBoYXMgZGlmZmVyZW50IHBhdGggaW4KPj4+ IGRpZmZlcmVudCBMaW51eCBrZXJuZWwsCj4+Pgo+Pj4gKiA1LjQ6wqDCoMKgwqDCoMKgwqDCoMKg wqAgRG9jdW1lbnRhdGlvbi9tZWRpYS91YXBpL3Y0bC9waXhmbXQtcmVzZXJ2ZWQucnN0Cj4+Pgo+ Pj4gKiA1LjEwLzUuMTU6IERvY3VtZW50YXRpb24vdXNlcnNwYWNlLWFwaS9tZWRpYS92NGwvcGl4 Zm10LXJlc2VydmVkLnJzdAo+Pj4KPj4+IDUuNCBpcyB0aGUgb25lIEkgYmFzZWQgdG8gc3VibWl0 IHRoZSBwYXRjaGVzLgo+Pj4KPj4+IENvdWxkIHlvdSBzdWdnZXN0IHRoZSBrZXJuZWwgdGhhdCBJ IHNob3VsZCBiYXNlZCB0byBzdWJtaXQgdGhlc2UgcGF0Y2hlcz8/Cj4+IFlvdSBzaG91bGQgYWx3 YXlzIHN1Ym1pdCBiYXNlZCBvbiB0aGUgbGF0ZXN0IHJlbGVhc2UuCj4+Cj4+IFRoZXJlIGFyZSBz b21ldGltZXMgZXhjZXB0aW9ucyB3aGVyZSB5b3Ugd2lsbCBiYXNlIHlvdXIgcGF0Y2hlcyBvbgo+ PiBzb21ldGhpbmcgZXZlbiBuZXdlciwgYnV0IGdlbmVyYWxseSB5b3Ugc2hvdWxkIGdyYWIgdGhl IGxhdGVzdC4KPj4KPj4gQmUgc3VyZSB0byByZS10ZXN0IG9uIHRoZSBsYXRlc3Qga2VybmVsIGJl Zm9yZSBzdWJtaXR0aW5nLgo+IE9LLCB0aGFuayB5b3UuCgpJIHJlY29tbWVuZCB3YWl0aW5nIHVu dGlsIGxhdGVyIHRoaXMgd2Vlay4gSSBob3BlIHRvIGhhdmUgYSBQUiBmb3Igb3RoZXIgb3V0c3Rh bmRpbmcKYXNwZWVkIHBhdGNoZXMgcmVhZHkgaW4gYSBmZXcgZGF5cy4gSXQgaXMgZWFzaWVzdCBp ZiB5b3UgYmFzZSB5b3VyIHY5IG9uIHRvcCBvZiB0aGF0CnNlcmllcywgdGhpcyB0byBhdm9pZCBt ZXJnZSBjb25mbGljdHMuCgpSZWdhcmRzLAoKCUhhbnMKCj4+Cj4+IENoZWVycywKPj4KPj4gSm9l bAo+Pgo+Pj4gSSB3aWxsIG5lZWQgdG8gY2hhbmdlIHRoZSBudW1iZXIgb2YgVjRMMl9DSURfVVNF Ul9BU1BFRURfQkFTRSBwZXIgZGlmZmVyZW50Cj4+Pgo+Pj4gbGludXgga2VybmVsIGFzIHdlbGwu Cj4+Pgo+Pj4+IFJlZ2FyZHMsCj4+Pj4KPj4+PiDCoMKgwqDCoMKgwqAgSGFucwo+Pj4+Cj4+Pj4+ IGluZGV4IGIyY2QxNTVlNjkxYi4uMWQwZGM4ZDg2ZWQ3IDEwMDY0NAo+Pj4+PiAtLS0gYS9Eb2N1 bWVudGF0aW9uL21lZGlhL3VhcGkvdjRsL3BpeGZtdC1yZXNlcnZlZC5yc3QKPj4+Pj4gKysrIGIv RG9jdW1lbnRhdGlvbi9tZWRpYS91YXBpL3Y0bC9waXhmbXQtcmVzZXJ2ZWQucnN0Cj4+Pj4+IEBA IC0yNjQsNiArMjY0LDIzIEBAIHBsZWFzZSBtYWtlIGEgcHJvcG9zYWwgb24gdGhlIGxpbnV4LW1l ZGlhIG1haWxpbmcgbGlzdC4KPj4+Pj4gwqDCoMKgwqDCoCBvZiB0aWxlcywgcmVzdWx0aW5nIGlu IDMyLWFsaWduZWQgcmVzb2x1dGlvbnMgZm9yIHRoZSBsdW1pbmFuY2UgcGxhbmUKPj4+Pj4gwqDC oMKgwqDCoCBhbmQgMTYtYWxpZ25lZCByZXNvbHV0aW9ucyBmb3IgdGhlIGNocm9taW5hbmNlIHBs YW5lICh3aXRoIDJ4Mgo+Pj4+PiDCoMKgwqDCoMKgIHN1YnNhbXBsaW5nKS4KPj4+Pj4gK8KgwqDC oCAqIC4uIF9WNEwyLVBJWC1GTVQtQUpQRzoKPj4+Pj4gKwo+Pj4+PiArwqDCoMKgwqDCoCAtIGBg VjRMMl9QSVhfRk1UX0FKUEdgYAo+Pj4+PiArwqDCoMKgwqDCoCAtICdBSlBHJwo+Pj4+PiArwqDC oMKgwqDCoCAtIEFTUEVFRCBKUEVHIGZvcm1hdCB1c2VkIGJ5IHRoZSBhc3BlZWQtdmlkZW8gZHJp dmVyIG9uIEFzcGVlZCBwbGF0Zm9ybXMsCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCB3aGljaCBpcyBn ZW5lcmFsbHkgYWRhcHRlZCBmb3IgcmVtb3RlIEtWTS4KPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIE9u IGVhY2ggZnJhbWUgY29tcHJlc3Npb24sIEkgd2lsbCBjb21wYXJlIHRoZSBuZXcgZnJhbWUgd2l0 aCBwcmV2aW91cwo+Pj4+PiArwqDCoMKgwqDCoMKgwqAgb25lIHRvIGRlY2lkZSB3aGljaCBtYWNy b2Jsb2NrJ3MgZGF0YSBpcyBjaGFuZ2VkLCBhbmQgb25seSB0aGUgY2hhbmdlZAo+Pj4+PiArwqDC oMKgwqDCoMKgwqAgbWFjcm9ibG9ja3Mgd2lsbCBiZSBjb21wcmVzc2VkLgo+Pj4+PiArCj4+Pj4+ ICvCoMKgwqDCoMKgwqDCoCBUaGUgaW1wbGVtZW50YXRpb24gaXMgYmFzZWQgb24gQVNUMjYwMCBB MyBkYXRhc2hlZXQsIHJldmlzaW9uIDAuOSwgd2hpY2gKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlz IG5vdCBwdWJsaWNseSBhdmFpbGFibGUuIE9yIHlvdSBjYW4gcmVmZXJlbmNlIFZpZGVvIHN0cmVh bSBkYXRhIGZvcm1hdAo+Pj4+PiArwqDCoMKgwqDCoMKgwqAg4oCTIEFTUEVFRCBtb2RlIGNvbXBy ZXNzaW9uIG9mIFNES19Vc2VyX0d1aWRlIHdoaWNoIGF2YWlsYWJsZSBvbgo+Pj4+PiArwqDCoMKg wqDCoMKgwqAgQXNwZWVkVGVjaC1CTUMvb3BlbmJtYy9yZWxlYXNlcy4KPj4+Pj4gKwo+Pj4+PiAr wqDCoMKgwqDCoMKgwqAgRGVjb2RlcidzIGltcGxlbWVudGF0aW9uIGNhbiBiZSBmb3VuZCBoZXJl LAo+Pj4+PiArwqDCoMKgwqDCoMKgwqAgYGh0dHBzOi8vZ2l0aHViLmNvbS9Bc3BlZWRUZWNoLUJN Qy9hc3BlZWRfY29kZWMvIDxodHRwczovL2dpdGh1Yi5jb20vQXNwZWVkVGVjaC1CTUMvYXNwZWVk X2NvZGVjLz5gX18KPj4+Pj4KPj4+Pj4gwqDCoCAuLiB0YWJ1bGFyY29sdW1uczo6IHxwezYuNmNt fXxwezIuMmNtfXxwezguN2NtfXwKPj4+Pj4KPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVk aWEvdjRsMi1jb3JlL3Y0bDItaW9jdGwuYyBiL2RyaXZlcnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDIt aW9jdGwuYwo+Pj4+PiBpbmRleCAyNGRiMzNmODAzYzAuLjAwZGRlMDFkMmY5NyAxMDA2NDQKPj4+ Pj4gLS0tIGEvZHJpdmVycy9tZWRpYS92NGwyLWNvcmUvdjRsMi1pb2N0bC5jCj4+Pj4+ICsrKyBi L2RyaXZlcnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDItaW9jdGwuYwo+Pj4+PiBAQCAtMTM3OCw2ICsx Mzc4LDcgQEAgc3RhdGljIHZvaWQgdjRsX2ZpbGxfZm10ZGVzYyhzdHJ1Y3QgdjRsMl9mbXRkZXNj ICpmbXQpCj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNhc2UgVjRMMl9QSVhfRk1U X1M1Q19VWVZZX0pQRzogZGVzY3IgPSAiUzVDNzNNWCBpbnRlcmxlYXZlZCBVWVZZL0pQRUciOyBi cmVhazsKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY2FzZSBWNEwyX1BJWF9GTVRf TVQyMUM6wqDCoMKgwqDCoMKgwqAgZGVzY3IgPSAiTWVkaWF0ZWsgQ29tcHJlc3NlZCBGb3JtYXQi OyBicmVhazsKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY2FzZSBWNEwyX1BJWF9G TVRfU1VOWElfVElMRURfTlYxMjogZGVzY3IgPSAiU3VueGkgVGlsZWQgTlYxMiBGb3JtYXQiOyBi cmVhazsKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY2FzZSBWNEwyX1BJWF9GTVRfQUpQ RzrCoMKgwqDCoMKgwqDCoMKgIGRlc2NyID0gIkFzcGVlZCBKUEVHIjsgYnJlYWs7Cj4+Pj4+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRlZmF1bHQ6Cj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoZm10LT5kZXNjcmlwdGlvblswXSkKPj4+Pj4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCByZXR1cm47Cj4+Pj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvbGludXgvdmlkZW9kZXYy LmggYi9pbmNsdWRlL3VhcGkvbGludXgvdmlkZW9kZXYyLmgKPj4+Pj4gaW5kZXggMzIxMGIzYzgy YTRhLi45OTRlYjYxNTVlYTkgMTAwNjQ0Cj4+Pj4+IC0tLSBhL2luY2x1ZGUvdWFwaS9saW51eC92 aWRlb2RldjIuaAo+Pj4+PiArKysgYi9pbmNsdWRlL3VhcGkvbGludXgvdmlkZW9kZXYyLmgKPj4+ Pj4gQEAgLTcyNiw2ICs3MjYsNyBAQCBzdHJ1Y3QgdjRsMl9waXhfZm9ybWF0IHsKPj4+Pj4gwqDC oCAjZGVmaW5lIFY0TDJfUElYX0ZNVF9JTlpJwqDCoMKgwqAgdjRsMl9mb3VyY2MoJ0knLCAnTics ICdaJywgJ0knKSAvKiBJbnRlbCBQbGFuYXIgR3JleXNjYWxlIDEwLWJpdCBhbmQgRGVwdGggMTYt Yml0ICovCj4+Pj4+IMKgwqAgI2RlZmluZSBWNEwyX1BJWF9GTVRfU1VOWElfVElMRURfTlYxMiB2 NGwyX2ZvdXJjYygnUycsICdUJywgJzEnLCAnMicpIC8qIFN1bnhpIFRpbGVkIE5WMTIgRm9ybWF0 ICovCj4+Pj4+IMKgwqAgI2RlZmluZSBWNEwyX1BJWF9GTVRfQ05GNMKgwqDCoMKgIHY0bDJfZm91 cmNjKCdDJywgJ04nLCAnRicsICc0JykgLyogSW50ZWwgNC1iaXQgcGFja2VkIGRlcHRoIGNvbmZp ZGVuY2UgaW5mb3JtYXRpb24gKi8KPj4+Pj4gKyNkZWZpbmUgVjRMMl9QSVhfRk1UX0FKUEfCoMKg wqDCoCB2NGwyX2ZvdXJjYygnQScsICdKJywgJ1AnLCAnRycpIC8qIEFzcGVlZCBKUEVHICovCj4+ Pj4+Cj4+Pj4+IMKgwqAgLyogMTBiaXQgcmF3IGJheWVyIHBhY2tlZCwgMzIgYnl0ZXMgZm9yIGV2 ZXJ5IDI1IHBpeGVscywgbGFzdCBMU0IgNiBiaXRzIHVudXNlZCAqLwo+Pj4+PiDCoMKgICNkZWZp bmUgVjRMMl9QSVhfRk1UX0lQVTNfU0JHR1IxMMKgIHY0bDJfZm91cmNjKCdpJywgJ3AnLCAnMycs ICdiJykgLyogSVBVMyBwYWNrZWQgMTAtYml0IEJHR1IgYmF5ZXIgKi8KPj4+IC0tIAo+Pj4gQmVz dCBSZWdhcmRzCj4+PiBKYW1teQo+Pj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK