From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Message-ID: Subject: Re: [OE-core] [hardknott][PATCH v2 ] mesa: Add patches for red label issues on video for VC4 and Freedreno From: "Pablo Saavedra Rodi?o" Date: Mon, 27 Sep 2021 11:26:31 +0200 In-Reply-To: <16A78CB146CA0532.15719@lists.openembedded.org> References: <20210923151723.3435155-1-psaavedra@igalia.com> <16A78CB146CA0532.15719@lists.openembedded.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-xna7LRz2B0kaEL2HNKUY" List-id: To: Alexander Kanavin Cc: OE-core --=-xna7LRz2B0kaEL2HNKUY Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit I got answer from Mesa with a new proposed fix in gallium for this problem: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13038 I just tested it over Mesa 21.0.3 (hardknott - without https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10524/commits ) in RPI4 and apparently this fix the issue for VC4 . Probably for Freedreno too. If this last commit is finally landed in Mesa and fix the problem for both drivers I will update this pull request with this single patch. On Thu, 2021-09-23 at 22:14 +0200, Pablo Saavedra Rodi?o wrote: > OK. Looks good to me. Let's wait for the acceptance of the patch > first. > > On Thu, 2021-09-23 at 21:00 +0200, Alexander Kanavin wrote: > > On Thu, 23 Sept 2021 at 20:44, Pablo Saavedra > > wrote: > > > I kindly accept your recommendation but could I make also a > > > question?: Couldn't it be enough just setting the 0001-freedreno- > > > YUV-formats-are-supported-as-external-only.patch with "Upstream- > > > status: Submitted" [1]. > > > > > > > > [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12991 > > > > > > > > > In this case I would like to be cautious and accept the patch into > > oe-core only after it has been accepted by upstream. There have > > been situations where submitted patches were never actually merged > > upstream for various reasons, and so we ended up with > > unmaintainable custom patches. > >   > > > > > > I assume this point affects only to the 0001-freedreno-YUV- > > > formats-are-supported-as-external-only.patch patch since the > > > other commits are already in Mesa 20.2 (version available in > > > Honister) and they are not required for Honister and next Am I > > > right? > > > > > > > > > That's right. > >   > > Alex > > > > > > --=-xna7LRz2B0kaEL2HNKUY Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
I got answer from Mesa with a new proposed fi= x in gallium for this problem:

I just tested i= t over Mesa 21.0.3 (hardknott - without https://gitlab.freedeskto= p.org/mesa/mesa/-/merge_requests/10524/commits) in RPI4 and apparently = this fix the issue for VC4 . Probably for Freedreno too.

If this last commit is finally landed in Mesa and fix the problem fo= r both drivers I will update this pull request with this single patch.

On Thu, 2021-09-23 at 22:14 +0200, Pablo Saavedra Rodi= ?o wrote:
OK. Looks good to me. Let's = wait for the acceptance of the patch first.

On Thu= , 2021-09-23 at 21:00 +0200, Alexander Kanavin wrote:
On Thu, 23 Sept 2021 at 20:44, Pablo Saavedra <psaavedra@igalia.com> wrote:
I kindly accept your recommendation but&= nbsp;could I make also a question?: Couldn't it be enough just setting the = 0001-freedreno-YUV-formats-are-supported-as-external-only.patch with "Upstr= eam-status: Submitted" [1].



In this= case I would like to be cautious and accept the patch into oe-core only af= ter it has been accepted by upstream. There have been situations where subm= itted patches were never actually merged upstream for various reasons, and = so we ended up with unmaintainable custom patches.
 

I assume this point a= ffects only to the 0001-freedreno-YUV-formats-are-supported-as-external-onl= y.patch patch since the other commits are already in Mesa 20.2 (version ava= ilable in Honister) and they are not required for Honister and next Am I ri= ght?


That's righ= t.
 
Alex




--=-xna7LRz2B0kaEL2HNKUY--