From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 446F6C38141 for ; Sat, 21 Jan 2023 03:08:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C59D1854DF; Sat, 21 Jan 2023 04:08:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=postmarketos.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=postmarketos.org header.i=@postmarketos.org header.b="YDxUCoDw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AC44A854F9; Sat, 21 Jan 2023 04:08:22 +0100 (CET) Received: from proxmox1.postmarketos.org (proxmox1.postmarketos.org [213.239.216.189]) by phobos.denx.de (Postfix) with ESMTP id 1B6D0854C5 for ; Sat, 21 Jan 2023 04:08:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=postmarketos.org Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=alexeymin@postmarketos.org Received: from [192.168.20.3] (unknown [77.239.252.99]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by proxmox1.postmarketos.org (Postfix) with ESMTPSA id 0305B1402F4; Sat, 21 Jan 2023 03:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=postmarketos.org; s=donut; t=1674270499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aEOQkNrSJTwy76ARY9C4mc+qN/yFQzW2kOrS71tysHU=; b=YDxUCoDwWsa10SaLWMrdzdfYm4xu+RcSqBGYu64BPrSCCZIdfO0ZWuy1fu74hQjC8o3f5v 0ouNCOMERExjjVVh/wCyMWkurahb643aRCjNykzofrhTQagxegLI7pTv6g/dxZnobzmDWl O0a7MFLMNgOzmrdFhRohmK6pNjQ5Cps= Message-ID: Date: Sat, 21 Jan 2023 06:08:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 4/5] arm64: dts: qcom: Fix SPMI arbiter regs and reg-names Content-Language: en-US To: Sumit Garg Cc: u-boot@lists.denx.de, Dzmitry Sankouski , Ramon Fried , Mateusz Kulikowski References: <20230116003315.2325575-1-alexeymin@postmarketos.org> <20230116003315.2325575-5-alexeymin@postmarketos.org> From: Alexey Minnekhanov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2023-01-19 11:47, Sumit Garg wrote: > On Mon, 16 Jan 2023 at 06:04, Alexey Minnekhanov > wrote: >> >> Now that reg-names is required, specify them, and use correct >> addresses for SPMI arbiter regs, taken from Linux dts [1] [2]. >> >> [1] https://elixir.bootlin.com/linux/v6.1.5/source/arch/arm64/boot/dts/qcom/qcs404.dtsi#L739 >> [2] https://elixir.bootlin.com/linux/v6.1.5/source/arch/arm64/boot/dts/qcom/sdm845.dtsi#L4896 >> > > Since you have already aligned the u-boot driver to work with Linux DT > binding, we should rather exactly match spmi DT nodes as in Linux dts > files. > > -Sumit > It can be done easier for sdm845, but there is no exact file named qcs404-evb.dts in Linux with spmi node in it. File structure in Linux is a bit different. There qcs404-evb.dtsi includes qcs404.dtsi. I can take spmi node from Linux's qcs404.dtsi and put it here in qcs404-evb.dts, but it won't be 1:1 match to Linux DT. If that would be OK, I can do it in v2? -- Alexey Minnekhanov