From: Hari Bathini <hbathini@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
"Michal Suchánek" <msuchanek@suse.de>,
"Mahesh J Salgaonkar" <mahesh@linux.vnet.ibm.com>
Subject: Re: [PATCH v3 1/2] powerpc/fadump: reduce memory consumption for capture kernel
Date: Wed, 26 Apr 2017 17:32:44 +0530 [thread overview]
Message-ID: <d4e1ab57-7512-8697-79c8-456fda5d5e97@linux.vnet.ibm.com> (raw)
In-Reply-To: <87o9vj1mso.fsf@concordia.ellerman.id.au>
On Wednesday 26 April 2017 04:02 PM, Michael Ellerman wrote:
> Hari Bathini <hbathini@linux.vnet.ibm.com> writes:
>
>> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
>> index 8ff0dd4..87edc7b 100644
>> --- a/arch/powerpc/kernel/fadump.c
>> +++ b/arch/powerpc/kernel/fadump.c
>> @@ -338,6 +343,36 @@ unsigned long __init arch_reserved_kernel_pages(void)
>> return memblock_reserved_size() / PAGE_SIZE;
>> }
>>
>> +static void __init parse_fadump_append_params(const char *p)
>> +{
>> + static char fadump_cmdline[COMMAND_LINE_SIZE] __initdata;
>> + char *token;
>> +
>> + strlcpy(fadump_cmdline, p, COMMAND_LINE_SIZE);
>> + token = strchr(fadump_cmdline, ',');
>> + while (token) {
>> + *token = ' ';
>> + token = strchr(token, ',');
>> + }
>> +
>> + pr_info("enforcing additional parameters (%s) passed through "
>> + "'fadump_append=' parameter\n", fadump_cmdline);
>> + parse_early_options(fadump_cmdline);
> Using parse_early_options() means it only works for parameters defined
> with early_param() or __setup() doesn't it?
Yeah. Actually, is it better to change commandline from "$params
fadump_append=nr_cpus=1,numa=off"
to "$params nr_cpus=1 numa=off" early in the boot process? That way,
parameters like udev.children-max=2 &
systemd.unit=kdump.service may also be specified in fadump_append=
parameter?
Thanks
Hari
next prev parent reply other threads:[~2017-04-26 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 7:35 [PATCH v3 1/2] powerpc/fadump: reduce memory consumption for capture kernel Hari Bathini
2017-04-26 7:35 ` [PATCH v3 2/2] powerpc/fadump: update documentation about 'fadump_append=' parameter Hari Bathini
2017-04-26 10:32 ` [PATCH v3 1/2] powerpc/fadump: reduce memory consumption for capture kernel Michael Ellerman
2017-04-26 12:02 ` Hari Bathini [this message]
2017-04-26 12:44 ` Michael Ellerman
2017-04-26 14:21 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4e1ab57-7512-8697-79c8-456fda5d5e97@linux.vnet.ibm.com \
--to=hbathini@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.