All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jerry Hoemann <jerry.hoemann@hpe.com>, wim@linux-watchdog.org
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] watchdog: hpwdt: Module paramerter alias.
Date: Tue, 14 Aug 2018 06:31:48 -0700	[thread overview]
Message-ID: <d4e2d7cc-77ea-36c7-ca1d-89803450cf2a@roeck-us.net> (raw)
In-Reply-To: <1533755607-71418-5-git-send-email-jerry.hoemann@hpe.com>

On 08/08/2018 12:13 PM, Jerry Hoemann wrote:
> Add module parameter "timeout" as an alias to "soft_margin."
> This aligns hpwdt usage more closely with other WDT while
> retaining backwards compatibility.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/hpwdt.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index 69a88b1..eb947bc 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -367,6 +367,9 @@ static void hpwdt_exit(struct pci_dev *dev)
>   module_param(soft_margin, int, 0);
>   MODULE_PARM_DESC(soft_margin, "Watchdog timeout in seconds");
>   
> +module_param_named(timeout, soft_margin, int, 0);
> +MODULE_PARM_DESC(timeout, "Alias of soft_margin");
> +
>   module_param(nowayout, bool, 0);
>   MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
>   		__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> 


  reply	other threads:[~2018-08-14 13:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08 19:13 [PATCH v2 0/5] watchdog: hpwdt: Bug Fixes/Enhancement Jerry Hoemann
2018-08-08 19:13 ` [PATCH v2 1/5] watchdog: hpwdt: Initialize pretimeout from module parameter Jerry Hoemann
2018-08-14 13:30   ` Guenter Roeck
2018-08-08 19:13 ` [PATCH v2 2/5] watchdog: hpwdt: Claim NMI from iLO Jerry Hoemann
2018-08-14 13:30   ` Guenter Roeck
2018-08-08 19:13 ` [PATCH v2 3/5] watchdog: hpwdt: Display module parameters Jerry Hoemann
2018-08-14 13:31   ` Guenter Roeck
2018-08-08 19:13 ` [PATCH v2 4/5] watchdog: hpwdt: Module paramerter alias Jerry Hoemann
2018-08-14 13:31   ` Guenter Roeck [this message]
2018-08-08 19:13 ` [PATCH v2 5/5] watchdog: hpwdt: Update version number Jerry Hoemann
2018-08-14 13:32   ` Guenter Roeck
2018-09-06  6:03 ` [PATCH v2 0/5] watchdog: hpwdt: Bug Fixes/Enhancement Jerry Hoemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4e2d7cc-77ea-36c7-ca1d-89803450cf2a@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jerry.hoemann@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.