From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B2BC4332F for ; Tue, 9 Nov 2021 16:51:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A812B6112F for ; Tue, 9 Nov 2021 16:51:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240588AbhKIQyF (ORCPT ); Tue, 9 Nov 2021 11:54:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240354AbhKIQyD (ORCPT ); Tue, 9 Nov 2021 11:54:03 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1234::107]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F417CC061764; Tue, 9 Nov 2021 08:51:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=XDU+9igmpCB85REE+/wNVC8TdK7iPyISbmV/9GyGl/0=; b=HQCp+aPWqoqcd+b68MG+H8KyYw 3c6plEJNlnVS3/4Ogml0JnIM822L3MIm8b+5SyCI2RdLmNz+bnzE2A56eSTJ2cvT81hw2EpufHUht 4aCky2r7Hsi+bsxjE6O2jrYCkIGYf3M/Y2RJ6KTBo8T+xiMR/rBklYEPChe3qXJzNVjNyXiXoxSup Xghqj0z+YAVwmZgSNrw+L2lJs9cLgLWsHermT9PjfuZ6LDhQgoSQ/CMke+sRt6KLt0zTtAd75Ap7H AdL83GRjdTtE+/U/wZeLFiWewFLXZTJ2SumfIyh1wnmVkUEND/HhCuf7EUkQW5Z+FGELolpImIvYO NyL+ZWgg==; Received: from [2601:1c0:6280:3f0::aa0b] by merlin.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkUL4-008o9f-78; Tue, 09 Nov 2021 16:51:14 +0000 Subject: Re: [PATCH] [RESEND] drm/rcar: stop using 'imply' for dependencies To: Arnd Bergmann , Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter Cc: Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210927142629.2016647-1-arnd@kernel.org> From: Randy Dunlap Message-ID: Date: Tue, 9 Nov 2021 08:51:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210927142629.2016647-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/27/21 7:26 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The meaning of the 'imply' keyword has changed recently, and neither the > old meaning (select the symbol if its dependencies are met) nor the new > meaning (enable it by default, but let the user set any other setting) > is what we want here. > > Work around this by adding two more Kconfig options that lead to > the correct behavior: if DRM_RCAR_USE_CMM and DRM_RCAR_USE_LVDS > are enabled, that portion of the driver becomes usable, and no > configuration results in a link error. > > This avoids a link failure: > > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_begin': > rcar_du_crtc.c:(.text+0x1444): undefined reference to `rcar_cmm_setup' > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_enable': > rcar_du_crtc.c:(.text+0x14d4): undefined reference to `rcar_cmm_enable' > arm-linux-gnueabi-ld: rcar_du_crtc.c:(.text+0x1548): undefined reference to `rcar_cmm_setup' > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_disable': > rcar_du_crtc.c:(.text+0x18b8): undefined reference to `rcar_cmm_disable' > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_kms.o: in function `rcar_du_modeset_init': > > Link: https://lore.kernel.org/all/20200417155553.675905-5-arnd@arndb.de/ > Signed-off-by: Arnd Bergmann > --- > This was last posted as part of a longer series to rework the > DRM dependencies in a more logical way. The rest of the series > is still open, but this one is needed as a bug fix regardless of > the rest. > --- > drivers/gpu/drm/rcar-du/Kconfig | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > Yes Yes Yes. Reviewed-by: Randy Dunlap Thanks. -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D40C433EF for ; Tue, 9 Nov 2021 16:51:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43F6D610CF for ; Tue, 9 Nov 2021 16:51:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 43F6D610CF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D81D89DD8; Tue, 9 Nov 2021 16:51:18 +0000 (UTC) X-Greylist: delayed 2745 seconds by postgrey-1.36 at gabe; Tue, 09 Nov 2021 16:51:16 UTC Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1234::107]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8E1B89D4A for ; Tue, 9 Nov 2021 16:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=XDU+9igmpCB85REE+/wNVC8TdK7iPyISbmV/9GyGl/0=; b=HQCp+aPWqoqcd+b68MG+H8KyYw 3c6plEJNlnVS3/4Ogml0JnIM822L3MIm8b+5SyCI2RdLmNz+bnzE2A56eSTJ2cvT81hw2EpufHUht 4aCky2r7Hsi+bsxjE6O2jrYCkIGYf3M/Y2RJ6KTBo8T+xiMR/rBklYEPChe3qXJzNVjNyXiXoxSup Xghqj0z+YAVwmZgSNrw+L2lJs9cLgLWsHermT9PjfuZ6LDhQgoSQ/CMke+sRt6KLt0zTtAd75Ap7H AdL83GRjdTtE+/U/wZeLFiWewFLXZTJ2SumfIyh1wnmVkUEND/HhCuf7EUkQW5Z+FGELolpImIvYO NyL+ZWgg==; Received: from [2601:1c0:6280:3f0::aa0b] by merlin.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkUL4-008o9f-78; Tue, 09 Nov 2021 16:51:14 +0000 Subject: Re: [PATCH] [RESEND] drm/rcar: stop using 'imply' for dependencies To: Arnd Bergmann , Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter References: <20210927142629.2016647-1-arnd@kernel.org> From: Randy Dunlap Message-ID: Date: Tue, 9 Nov 2021 08:51:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210927142629.2016647-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, Arnd Bergmann , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 9/27/21 7:26 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The meaning of the 'imply' keyword has changed recently, and neither the > old meaning (select the symbol if its dependencies are met) nor the new > meaning (enable it by default, but let the user set any other setting) > is what we want here. > > Work around this by adding two more Kconfig options that lead to > the correct behavior: if DRM_RCAR_USE_CMM and DRM_RCAR_USE_LVDS > are enabled, that portion of the driver becomes usable, and no > configuration results in a link error. > > This avoids a link failure: > > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_begin': > rcar_du_crtc.c:(.text+0x1444): undefined reference to `rcar_cmm_setup' > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_enable': > rcar_du_crtc.c:(.text+0x14d4): undefined reference to `rcar_cmm_enable' > arm-linux-gnueabi-ld: rcar_du_crtc.c:(.text+0x1548): undefined reference to `rcar_cmm_setup' > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_disable': > rcar_du_crtc.c:(.text+0x18b8): undefined reference to `rcar_cmm_disable' > arm-linux-gnueabi-ld: drivers/gpu/drm/rcar-du/rcar_du_kms.o: in function `rcar_du_modeset_init': > > Link: https://lore.kernel.org/all/20200417155553.675905-5-arnd@arndb.de/ > Signed-off-by: Arnd Bergmann > --- > This was last posted as part of a longer series to rework the > DRM dependencies in a more logical way. The rest of the series > is still open, but this one is needed as a bug fix regardless of > the rest. > --- > drivers/gpu/drm/rcar-du/Kconfig | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > Yes Yes Yes. Reviewed-by: Randy Dunlap Thanks. -- ~Randy