From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f174.google.com ([209.85.220.174]:34474 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753620AbcKVLk3 (ORCPT ); Tue, 22 Nov 2016 06:40:29 -0500 Received: by mail-qk0-f174.google.com with SMTP id q130so19183915qke.1 for ; Tue, 22 Nov 2016 03:40:28 -0800 (PST) Subject: Re: [PATCH 16/18] arm64: dts: h3ulcb: rename SDHI0 pins To: Vladimir Barinov , Simon Horman , linux-renesas-soc@vger.kernel.org References: <93373c309a703b57690216db4106a4a534929c15.1479726397.git.horms+renesas@verge.net.au> <45a251f6-ee0c-5eba-ffd1-3f61a1e7ccc7@cogentembedded.com> Cc: linux-arm-kernel@lists.infradead.org, Magnus Damm From: Sergei Shtylyov Message-ID: Date: Tue, 22 Nov 2016 14:40:25 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On 11/22/2016 2:22 PM, Vladimir Barinov wrote: >>> From: Vladimir Barinov >>> >>> This changes SDHI0 pin names for H3ULCB board >>> >>> Signed-off-by: Vladimir Barinov >>> Signed-off-by: Simon Horman >>> --- >>> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> index 8d0ac076d8e2..6ffb0517421a 100644 >>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> @@ -163,13 +163,13 @@ >>> function = "avb"; >>> }; >>> >>> - sdhi0_pins_3v3: sd0_3v3 { >>> + sdhi0_pins: sd0 { >>> groups = "sdhi0_data4", "sdhi0_ctrl"; >>> function = "sdhi0"; >>> power-source = <3300>; >>> }; >>> >>> - sdhi0_pins_1v8: sd0_1v8 { >>> + sdhi0_pins_uhs: sd0 { >> >> I'm afraid the following will just override the props of the node above >> which is not what we ant. > Thank you for pointing to this. > > This is my typo. > I will rework the patch to have different node names. The patch had been already merged by Simon and was posted a s apart of a pull request (if I don't mistake), so I guess an incremental patch needed now... > Regards, > Vladimir MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Tue, 22 Nov 2016 14:40:25 +0300 Subject: [PATCH 16/18] arm64: dts: h3ulcb: rename SDHI0 pins In-Reply-To: References: <93373c309a703b57690216db4106a4a534929c15.1479726397.git.horms+renesas@verge.net.au> <45a251f6-ee0c-5eba-ffd1-3f61a1e7ccc7@cogentembedded.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/22/2016 2:22 PM, Vladimir Barinov wrote: >>> From: Vladimir Barinov >>> >>> This changes SDHI0 pin names for H3ULCB board >>> >>> Signed-off-by: Vladimir Barinov >>> Signed-off-by: Simon Horman >>> --- >>> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> index 8d0ac076d8e2..6ffb0517421a 100644 >>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> @@ -163,13 +163,13 @@ >>> function = "avb"; >>> }; >>> >>> - sdhi0_pins_3v3: sd0_3v3 { >>> + sdhi0_pins: sd0 { >>> groups = "sdhi0_data4", "sdhi0_ctrl"; >>> function = "sdhi0"; >>> power-source = <3300>; >>> }; >>> >>> - sdhi0_pins_1v8: sd0_1v8 { >>> + sdhi0_pins_uhs: sd0 { >> >> I'm afraid the following will just override the props of the node above >> which is not what we ant. > Thank you for pointing to this. > > This is my typo. > I will rework the patch to have different node names. The patch had been already merged by Simon and was posted a s apart of a pull request (if I don't mistake), so I guess an incremental patch needed now... > Regards, > Vladimir MBR, Sergei