From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E527C4320A for ; Thu, 29 Jul 2021 21:23:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 289F960EFF for ; Thu, 29 Jul 2021 21:23:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233841AbhG2VXh (ORCPT ); Thu, 29 Jul 2021 17:23:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbhG2VXg (ORCPT ); Thu, 29 Jul 2021 17:23:36 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA38FC0613C1; Thu, 29 Jul 2021 14:23:31 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id ca5so12074967pjb.5; Thu, 29 Jul 2021 14:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DghCXD4NppA54luI4u5HZxhnCh8YT8EqcsXoMb7r7pI=; b=rcpUKHyIwogZ74v+SW0XAcz9dVgG1o0gg+sG1qZpWuBwYV/SuvQXjvfqpg+U0kFwPO xfB1rTjzPCU266k0RFUoFDleqyXSKrRUeLJX+tZhjfzsxsJXE9MNXr49WZO9+yU3XEno qKMwUbrl0gYgn5wBRwQJqapA7wwPPEhgxyllu2qp5fUZsGGMmcDc1SpBdil1Hqn83lXE TyMzwM6Nki7gFf1rdqslTG5PF1XgsyDtQx9bU77fQ1Pz1RssqySKgdaIYbci8G0OEu9c jj5aGEkiIdu8Lteyev1+io3tgv9Bbd/PikZXTCrx4sdMU2+T9T6HEAARbao07as5zl2A iy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DghCXD4NppA54luI4u5HZxhnCh8YT8EqcsXoMb7r7pI=; b=Zl4Oj/EVYrb7ZX9R2YM4jb4idL0hmWoNme3unwHH9Ty+j9q2sDh+9i6qf2SIiFmaVv 7M2suBnvLydgcvttjeoBY+6L7IqjenDE6kOOQkFZicAP2kzmELJhIpsKJnlEDFM8usHR CNleGdnxe3r+Mk8tIP1c13/WmhOUtNKmsxTxOnaNPVsHRUS+3e6n3FRQRvp7i2SzWmf0 mfWE+3pzc5U9FPc2MoVwiFKhcVzD17rqp1zgoVUExny3ZyXrv8gUwQOHrgLlgZf6/VTj rFw5bD6IzZbc8q/LyZTQvDgnA9EUyGlVVFLeT5m5Q0Ujd9E2btdkwzthr+d2O+Ix4YRI jxxw== X-Gm-Message-State: AOAM533CcXgwJjdgF1x/gvKj97A75gewR0U5rTBJSAt6Wg6YO8wi3lHR CHw0xCShnaAnnb2/DTvOXazuhF11mxY= X-Google-Smtp-Source: ABdhPJwsa78wu1RIAm2CGcCyrJU3hIpp/d2+mwgn2tgc/eVnmigLoImTdsS5fFGMWf2XaxIYzHX21Q== X-Received: by 2002:a63:154d:: with SMTP id 13mr5469047pgv.116.1627593810838; Thu, 29 Jul 2021 14:23:30 -0700 (PDT) Received: from [10.67.49.140] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id g2sm4788459pfv.91.2021.07.29.14.23.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 14:23:30 -0700 (PDT) Subject: Re: [PATCH] bcm63xx_enet: simplify the code in bcm_enet_open() To: Tang Bin , davem@davemloft.net, kuba@kernel.org, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210729070627.23776-1-tangbin@cmss.chinamobile.com> From: Florian Fainelli Message-ID: Date: Thu, 29 Jul 2021 14:23:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729070627.23776-1-tangbin@cmss.chinamobile.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/29/21 12:06 AM, Tang Bin wrote: > In the function bcm_enet_open(), 'ret = -ENOMEM' can be moved > outside the judgement statement, so redundant assignments can > be removed to simplify the code. > > Signed-off-by: Tang Bin Acked-by: Florian Fainelli -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1023C4320A for ; Thu, 29 Jul 2021 21:25:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BABC860EFF for ; Thu, 29 Jul 2021 21:25:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BABC860EFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=1Ic3l9sQ7wTV1isT7mOUrWKAzjlwgEGKOMWJl5WLyaA=; b=htOEEO8/rLaFH/2g9OFWztZXOO m2f+MpO4rY5hZQJLLpl02nA/Ieqww0vAM68qehM3TvQ6czqF0gHJyOh/HHz3up7ovRFkj6xKIfVfy fUYumcGhgWI0sZrFwotB4dYmJbGIISZZb25DCkTJZQvdKy2Zsglsdd5PjDGbz0B5kWriWNOd9k1Fh 1dllcM6YxLM7Mhb8O6BqW5ma7ZkrdPmEj6fbcelZpFf0p1ISCOxN3EF7Kr7qMghn8bYu33SIuR+HZ okMvSDBz0mams4NV9gnzPQ9Zqfe9iAVIRJgKEWh9qHYpGrAiF2cT1bYyF1jClKlydYQRCntiC/nWI k6f4604g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9DVA-0066Zk-E4; Thu, 29 Jul 2021 21:23:36 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9DV6-0066Z0-JU for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 21:23:33 +0000 Received: by mail-pl1-x62d.google.com with SMTP id u2so245050plg.10 for ; Thu, 29 Jul 2021 14:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DghCXD4NppA54luI4u5HZxhnCh8YT8EqcsXoMb7r7pI=; b=rcpUKHyIwogZ74v+SW0XAcz9dVgG1o0gg+sG1qZpWuBwYV/SuvQXjvfqpg+U0kFwPO xfB1rTjzPCU266k0RFUoFDleqyXSKrRUeLJX+tZhjfzsxsJXE9MNXr49WZO9+yU3XEno qKMwUbrl0gYgn5wBRwQJqapA7wwPPEhgxyllu2qp5fUZsGGMmcDc1SpBdil1Hqn83lXE TyMzwM6Nki7gFf1rdqslTG5PF1XgsyDtQx9bU77fQ1Pz1RssqySKgdaIYbci8G0OEu9c jj5aGEkiIdu8Lteyev1+io3tgv9Bbd/PikZXTCrx4sdMU2+T9T6HEAARbao07as5zl2A iy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DghCXD4NppA54luI4u5HZxhnCh8YT8EqcsXoMb7r7pI=; b=RFZbz/sxE9OUJOhBaGVSjhNvJn9VqM7un6BHzWVWCQeZAc08zaNgtEJrjCWckKmTFZ MIE8JEQMIz1xx5X/wokPZ/ZMaU5dc4Ca/oy+kvdGr0oTk5/D/tyYcXOXf++xt19Fn2pl XTNkDjxPSwv1MqY/wJYJVHi74xcgwaD+3wiEd6InQjLLM9ZkxRh/o7AY9HNdFNEJ8rWH Md3V8HsVueUxTpdh6MpwkbFCM2KLycvB6tcJ/MGRkI/SpyyOX0/+tfBhKVX6rTOWGGuy ZTvtrIZ5KWElJC4myABiKS0WJbOw40s1K0dBGZB4iP9jRlr4jB0u4jgydW9tmA/3jnJQ F1mg== X-Gm-Message-State: AOAM530we6zbgBBC8/Ab6hLrZYrAM/yk7Lw/OFm8zLaHbUsIcl7A1X7f QhnTaElzfEKUeA3vH3nEAVs= X-Google-Smtp-Source: ABdhPJwsa78wu1RIAm2CGcCyrJU3hIpp/d2+mwgn2tgc/eVnmigLoImTdsS5fFGMWf2XaxIYzHX21Q== X-Received: by 2002:a63:154d:: with SMTP id 13mr5469047pgv.116.1627593810838; Thu, 29 Jul 2021 14:23:30 -0700 (PDT) Received: from [10.67.49.140] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id g2sm4788459pfv.91.2021.07.29.14.23.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 14:23:30 -0700 (PDT) Subject: Re: [PATCH] bcm63xx_enet: simplify the code in bcm_enet_open() To: Tang Bin , davem@davemloft.net, kuba@kernel.org, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210729070627.23776-1-tangbin@cmss.chinamobile.com> From: Florian Fainelli Message-ID: Date: Thu, 29 Jul 2021 14:23:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729070627.23776-1-tangbin@cmss.chinamobile.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_142332_711493_DD46DC9F X-CRM114-Status: GOOD ( 11.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/29/21 12:06 AM, Tang Bin wrote: > In the function bcm_enet_open(), 'ret = -ENOMEM' can be moved > outside the judgement statement, so redundant assignments can > be removed to simplify the code. > > Signed-off-by: Tang Bin Acked-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel