From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79F3C4338F for ; Thu, 29 Jul 2021 05:56:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15CB160EB9 for ; Thu, 29 Jul 2021 05:56:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 15CB160EB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8z1g-0000gm-V0 for qemu-devel@archiver.kernel.org; Thu, 29 Jul 2021 01:56:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8z0w-0007uy-Tv for qemu-devel@nongnu.org; Thu, 29 Jul 2021 01:55:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8z0t-0000eD-FG for qemu-devel@nongnu.org; Thu, 29 Jul 2021 01:55:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627538121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sXCcSnt28rYcldvOSFVJrkOiixriNgVH3OWXvGOjMdo=; b=Tz6h/lgG6LHoMYcbCAZzuPP30THmogGpmvvZ1qTaP2YN+RkCFaOCNrkmgaOjUeG0lvkEjj sq8PazemvN4IfXMam2INiRUMiei+XF4kKziKCyoKq3u3NFrDqEWzOODeN7nXBiTBduXdmX 1Ng7QDVPJivLBQ1LmpQL/GhUfKDsC3A= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289-bMWuFHh9OvyAv5xTbYZu9A-1; Thu, 29 Jul 2021 01:55:19 -0400 X-MC-Unique: bMWuFHh9OvyAv5xTbYZu9A-1 Received: by mail-wr1-f72.google.com with SMTP id s22-20020adf97960000b02901535eae4100so1829149wrb.14 for ; Wed, 28 Jul 2021 22:55:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sXCcSnt28rYcldvOSFVJrkOiixriNgVH3OWXvGOjMdo=; b=XO+oZT/2mc1Tpft9BEyp/+aktx4OEbdGZMPNU7RTUtRo910qrakeQrH5rrxaBCJg7l j7UowcMmAgqOlamKQ6Lp+0ZI7XuCzhHNjhU21IkSO+3wps9+8oiL7lO8P+CG7MJMk0gU qaIUzT8U/vtDkTSneA6iayEck+ob+fW37Vy7z5aOuTjA8pMXRXXJULYmoXd+Cxl/wlWq W5KMY+DPFauv4xj0uWgyp61WAoec5lRq/h7AmEasuTDELY4vj/bk/nX0Ujpw1kdB7K4H GMdxf1KClg+N2T/PINX69TNxlfuGgeIJNFiFoL/udeufyEEUiKysXmSEBHRs6JGDbR0g 3MyA== X-Gm-Message-State: AOAM533frePrsgl+Ix63q1zADm9w3qbAhPFX8xpnIo6MDzl8rjtdW580 Zg5HE0Umj05TO4r0S7tBV+d2e15mbQ/7ylyLiy4Vb8lDUVcr2mxDDHhGHruMwTBLQbjeL5gklCV GDF88pDxq+lWiS9I= X-Received: by 2002:a05:6000:2a9:: with SMTP id l9mr2787809wry.75.1627538118303; Wed, 28 Jul 2021 22:55:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6OBg3+pQ4j6Ya2TzWVzrga3PiW669Kqy7V/lJDj9cOvMkSIUjXvGgWeHO2WwP7FeN3RLxCA== X-Received: by 2002:a05:6000:2a9:: with SMTP id l9mr2787789wry.75.1627538118098; Wed, 28 Jul 2021 22:55:18 -0700 (PDT) Received: from thuth.remote.csb (p5791d475.dip0.t-ipconnect.de. [87.145.212.117]) by smtp.gmail.com with ESMTPSA id u11sm1982149wrr.44.2021.07.28.22.55.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 22:55:17 -0700 (PDT) Subject: Re: [PATCH] tests: Fix migration-test build failure for sparc To: Peter Xu , qemu-devel@nongnu.org References: <20210728214128.206198-1-peterx@redhat.com> From: Thomas Huth Message-ID: Date: Thu, 29 Jul 2021 07:55:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210728214128.206198-1-peterx@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.719, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.277, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson , Leonardo Bras Soares Passos , "Dr . David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 28/07/2021 23.41, Peter Xu wrote: > Even if seems to exist for all archs on linux, however including > it with __linux__ defined seems to be not working yet as it'll try to include > asm/kvm.h and that can be missing for archs that do not support kvm. > > To fix this (instead of any attempt to fix linux headers..), we can mark the > header to be x86_64 only, because it's so far only service for adding the kvm > dirty ring test. > > No need to have "Fixes" as the issue is just introduced very recently. > > Reported-by: Richard Henderson > Signed-off-by: Peter Xu > --- > tests/qtest/migration-test.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 1e8b7784ef..cc5e83d98a 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -27,7 +27,8 @@ > #include "migration-helpers.h" > #include "tests/migration/migration-test.h" > > -#if defined(__linux__) > +/* For dirty ring test; so far only x86_64 is supported */ > +#if defined(__linux__) && defined(HOST_X86_64) > #include "linux/kvm.h" > #endif > > @@ -1395,7 +1396,7 @@ static void test_multifd_tcp_cancel(void) > > static bool kvm_dirty_ring_supported(void) > { > -#if defined(__linux__) > +#if defined(__linux__) && defined(HOST_X86_64) > int ret, kvm_fd = open("/dev/kvm", O_RDONLY); > > if (kvm_fd < 0) { > Acked-by: Thomas Huth Juan, Dave, if you don't mind I can take this through my testing branch - I'm planning to send a pull request today anyway. Thomas