All of lore.kernel.org
 help / color / mirror / Atom feed
From: Goffredo Baroncelli <kreijack@gmail.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH V2] Add support for BTRFS raid5/6 to GRUB
Date: Wed, 9 May 2018 21:36:55 +0200	[thread overview]
Message-ID: <d50a4ad0-8869-81b6-ff8b-8a45b9d5afb5@gmail.com> (raw)
In-Reply-To: <20180509170055.GI25320@router-fw-old.local.net-space.pl>

On 05/09/2018 07:00 PM, Daniel Kiper wrote:
> On Tue, Apr 24, 2018 at 09:13:09PM +0200, Goffredo Baroncelli wrote:
>>
>> Hi All,
>>
>> the aim of this patches set is to provide support for a BTRFS raid5/6
>>  filesystem in GRUB.
>>
>> The first patch, implements the basic support for raid5/6. I.e this works when
>>  all the disks
>> are present.
>>
>> The next 4 patches, are preparatory ones.
>>
>> The last two implements the support for raid5/6 recovery. It allow to read
>> from the filesystem even when 1 or 2 (for raid 6) disk(s) are missing.
>>
>> The last one is the more controversial. The code for the raid6 recovery is
>> copied from the GRUB file reaid6_recovery.c . I preferred this approach,
>> because the original code assumes that the read is GRUB_DISK_SECTOR_SIZE
>> bytes based (512 bytes). Instead the GRUB BTRFS implementation need to
>> read the disk with a granularity of the byte.
>> I tried to update the code (and the function which the code calls), but
>> the change was quite invasive. So for now I preferred to duplicating the
>> code, to get some feedback.
>>
>> I tested the code in grub-emu, and it works (for me) both with all the disks,
>>  and with some disks missing. I checked the sh1sums calculated from grub and
>> from linux and these matched.
>>
>> Comments are welcome.
> 
> Mostly nitpicks. However, if we can reuse reaid6_recovery.c somehow that
> will be great. Even if this require some more patches.

I liked the idea too. I am not sure to be able to tests all the cases. Do you know if it exists a list of tests about raid6_recovery and dm ?

Anyway, I update the patch. Tomorrow I will test these and then I issue the patch set.

BR

> 
> Daniel
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 


-- 
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5


  reply	other threads:[~2018-05-09 19:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 19:13 [PATCH V2] Add support for BTRFS raid5/6 to GRUB Goffredo Baroncelli
2018-04-24 19:13 ` [PATCH 1/7] Add support for reading a filesystem with a raid5 or raid6 profile Goffredo Baroncelli
2018-05-09 13:46   ` Daniel Kiper
2018-05-09 19:37     ` Goffredo Baroncelli
2018-04-24 19:13 ` [PATCH 2/7] Add helper to check the btrfs header Goffredo Baroncelli
2018-05-09 13:52   ` Daniel Kiper
2018-05-09 19:37     ` Goffredo Baroncelli
2018-04-24 19:13 ` [PATCH 3/7] Move from the find_device the error logging logic to the callee Goffredo Baroncelli
2018-05-09 14:00   ` Daniel Kiper
2018-05-09 19:37     ` Goffredo Baroncelli
2018-04-24 19:13 ` [PATCH 4/7] Avoiding scanning for an already not found device Goffredo Baroncelli
2018-05-09 14:07   ` Daniel Kiper
2018-05-09 19:37     ` Goffredo Baroncelli
2018-04-24 19:13 ` [PATCH 5/7] Refactor the code of read from disk Goffredo Baroncelli
2018-05-09 14:26   ` Daniel Kiper
2018-05-09 19:37     ` Goffredo Baroncelli
2018-04-24 19:13 ` [PATCH 6/7] Add support for recovery for a raid5 btrfs profiles Goffredo Baroncelli
2018-05-09 16:46   ` Daniel Kiper
2018-05-09 19:37     ` Goffredo Baroncelli
2018-04-24 19:13 ` [PATCH 7/7] Add raid6 recovery Goffredo Baroncelli
2018-05-09 16:58   ` Daniel Kiper
2018-05-09 19:40     ` Goffredo Baroncelli
2018-05-09 17:00 ` [PATCH V2] Add support for BTRFS raid5/6 to GRUB Daniel Kiper
2018-05-09 19:36   ` Goffredo Baroncelli [this message]
2018-05-10 16:17     ` Daniel Kiper
2018-05-11 19:24 Goffredo Baroncelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d50a4ad0-8869-81b6-ff8b-8a45b9d5afb5@gmail.com \
    --to=kreijack@gmail.com \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=kreijack@inwind.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.