From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995BCC48BE5 for ; Wed, 16 Jun 2021 17:25:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD08C613DB for ; Wed, 16 Jun 2021 17:25:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD08C613DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 500DC81D95; Wed, 16 Jun 2021 19:25:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LzGk5tBt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AF19882024; Wed, 16 Jun 2021 19:25:34 +0200 (CEST) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2FB5B80412 for ; Wed, 16 Jun 2021 19:25:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ivo.g.dimitrov.75@gmail.com Received: by mail-ej1-x62e.google.com with SMTP id hq2so5159077ejc.2 for ; Wed, 16 Jun 2021 10:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RYnH0iikZuBixQZ6Ma1gHoLbd4jyiLdW41dH8KPY8QU=; b=LzGk5tBtZ38JSDcq5tb71XB/wnvmKiz+0gG/vz0Z3eBm3COkFBP8zPnI5l7KuED5/Q 1OhwX83YsF2BXsKomifPo0yC5DogAKY5HhmBvVo1jZUyn5oD6cNuahkPxhTwGcX+djOO sBSzrnqyKBcOvNYStFw9As1pz6jOcDUW6RAdJgoVA+SPI40IAdiUpOn2p+sdKdJnRID4 RL7fCRofOyiRAYrjPmp5nNncyZljNUTV0CT8mLFEKzlVUIFoo7aNqhBnaZwjchshL1N/ twTEWFDlQcpOKWW7bk2ud5eHsAKSponOSgTUSKw715X8BG/rMKmFTpfzXBg/4A9BLQ7H SfvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RYnH0iikZuBixQZ6Ma1gHoLbd4jyiLdW41dH8KPY8QU=; b=j/NLclaVzjnsf0xoANuXIHmVPOpNPcXSBHpb8ZozUCwM1DZbu7ZESXiIL8ufAVCyE/ aOAHOYbzjcRuCSpwiks8pPaCzsU47dlWzbyW24zAISJ68qvNXuZwwAzOiNQ0PdVLQJZU C+ahCAYX9+nAdRTnZpCk+A3Nb7TxXG6LE/gpkSOHjP7XWjj85Kvt2fQaxlzFSJgT/1Ya rPOst70bcjUWXj3eYQ51nZh9cRYYaDa1IsYRikcSB8igPivUIjUDDFBiD6CSsDFb8t30 ZWxzoe8mDD9fSLworWOkeZveq9dRpMC5Zj7Rlq2ptgEayP+4m2IN2ufpiJbBN2ECsUt/ pOjg== X-Gm-Message-State: AOAM532gSi0Iu3nW41GPALIJqctQ6C56MOi7LXC1BezNL/sIy0KNn4Cj p84d1Whym+Vmbum6C4VmG9I= X-Google-Smtp-Source: ABdhPJwk6dZgQNGTuX8a3f6Fx/FxOwoipFIyUhV8VEec4Rw1VhOpBvTR9r6F/fWDK+nfP22ZxFmibw== X-Received: by 2002:a17:906:8688:: with SMTP id g8mr619372ejx.470.1623864330857; Wed, 16 Jun 2021 10:25:30 -0700 (PDT) Received: from [192.168.1.10] ([46.249.74.23]) by smtp.googlemail.com with ESMTPSA id qq26sm1958637ejb.6.2021.06.16.10.25.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jun 2021 10:25:30 -0700 (PDT) Subject: Re: [maemo-leste] [PATCH] arm: Remove nokia_rx51 board To: Tom Rini Cc: =?UTF-8?Q?Pali_Roh=c3=a1r?= , maemo-leste@lists.dyne.org, u-boot@lists.denx.de, Merlijn Wajer References: <20210519012640.5970-1-trini@konsulko.com> <20210519132748.mgzyukuvfmlx3uch@pali> <20210519155203.GZ17669@bill-the-cat> <20210521144418.GI17669@bill-the-cat> <20210521213645.2y5dawkvr6wfaymy@pali> <20210615123436.GH9516@bill-the-cat> <5848e9c9-4dab-00cc-07dc-ffa57b9417cd@gmail.com> <20210616121008.GR9516@bill-the-cat> <20210616121313.GS9516@bill-the-cat> From: Ivaylo Dimitrov Message-ID: Date: Wed, 16 Jun 2021 20:25:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20210616121313.GS9516@bill-the-cat> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, On 16.06.21 г. 15:13 ч., Tom Rini wrote: > On Wed, Jun 16, 2021 at 08:10:08AM -0400, Tom Rini wrote: >> On Wed, Jun 16, 2021 at 09:02:16AM +0300, Ivaylo Dimitrov wrote: >>> Hi, >>> >>> On 15.06.21 г. 15:34 ч., Tom Rini wrote: >>>> On Tue, Jun 15, 2021 at 08:40:30AM +0300, Ivaylo Dimitrov wrote: >>>>> Hi, >>>>> >>>>> On 22.05.21 г. 0:36 ч., Pali Rohár wrote: >>>>>> On Friday 21 May 2021 10:44:18 Tom Rini wrote: >>>>>>> On Wed, May 19, 2021 at 11:52:03AM -0400, Tom Rini wrote: >>>>>>>> On Wed, May 19, 2021 at 03:27:48PM +0200, Pali Rohár wrote: >>>>>>>> >>>>>>>>> On Tuesday 18 May 2021 21:26:40 Tom Rini wrote: >>>>>>>>>> This board has not been converted to CONFIG_DM_USB by the deadline. >>>>>>>>>> Remove it. >>>>>>>>> >>>>>>>>> I'm very disappointed that you want to remove Nokia N900 from U-Boot. >>>>>>>>> >>>>>>>>> I was waiting waiting half of year because other developers did not >>>>>>>>> react to issues which were introduced and neither to patches which I >>>>>>>>> sent (+ trying to remind open issues). And also I was waiting another >>>>>>>>> half of year until other N900 related patches were merged. So the whole >>>>>>>>> slowdown was not caused by me, why it is taking so long. >>>>>>>>> >>>>>>>>> Now there is still one N900 DM related patch waiting for review. I'm >>>>>>>>> converting code step by step. >>>>>>>>> >>>>>>>>> So the ball is not on my side. >>>>>>>> >>>>>>>> So, what patch(es) need to be applied to get DM_USB enabled? Thanks. >>>>>>> >>>>>>> I don't see any open patches from you that look related to enabling >>>>>>> DM_USB on the platform. If you want to disable USB on the platform for >>>>>>> now instead, that's fine too. >>>>>> >>>>> >>>>> I tried to migrate the latest master to DM_USB, but unfortunately the >>>>> results are pretty much sad - adding OF_CONTROL (which is a prerequisite to >>>>> have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the >>>>> size of the u-boot binary, so it becomes 370284 bytes. Given that we have >>>>> less than 256k of storage space for the u-boot, the produced binary cannot >>>>> be used on n900 the same way current (no DM_USB) binary is used. >>>>> >>>>> As I see it, there are not much options left - u-boot on N900 is not SPL, so >>>>> we can't use OF_PLATDATA, which in turn always links libfdt. >>>>> Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires >>>>> the board to be converted to DT and this is way bigger change. >>>>> >>>>> Please advice on how to proceed. >>>> >>>> Please post your WIP patches, thanks. >>>> >>> >>> Sorry, I am not sure I understand what patches you want me to post: >>> >>> WDT patch has already been sent couple of months ago - >>> https://lists.denx.de/pipermail/u-boot/2021-March/443868.html >>> Do you want it to be rebased and resend? >>> >>> DM_USB, I just started writing one and I immediately hit the OF_CONTROL >>> requirement. Enabling OF_CONTROL requires a full blown migration to DT, >>> which is a huge task and not really equal to "Please update the board to use >>> CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures: >>> >>> /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: >>> /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: >>> DWARF error: could not find abbrev number 3998 >>> /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind': >>> :(.text+0x5672): undefined reference to >>> `ofnode_read_u32_default' >>> /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: >>> :(.text+0x568c): undefined reference to >>> `ofnode_read_u32_default' >>> /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: >>> /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device': >>> :(.text+0x6c84): undefined reference to `ofnode_first_subnode' >>> /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: >>> :(.text+0x6c96): undefined reference to `ofnode_read_u32' >>> /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: >>> :(.text+0x6ca4): undefined reference to `ofnode_next_subnode' >>> /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: >>> /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8): >>> undefined reference to `dm_scan_fdt_dev' >>> /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: >>> /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8): >>> undefined reference to `dm_scan_fdt_dev' >>> >>> Fixing those requires enabling of OF_CONTROL and this in turn means the >>> board must be migrated to DT, unless I am missing something. That's why my >>> "please advice..." stance. >> >> Please post the patches that bring you to the above link errors, yes, >> thanks. > > To be clearer, finish up a patch that completes the migration but is too > large to install on the hardware so that others can take a look. > I am not sure I understand that - a patch that completes the migration to DM_USB cannot be done ATM as the binary does not link without OF_CONTROL. And I am not going to enable OF_CONTROL as this means I will have to migrate everything to DT. That's why I enable DM_USB only - see reply to the other mail. Thanks, Ivo