From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2] rdma: fix header files Date: Fri, 4 May 2018 16:13:07 -0600 Message-ID: References: <20180504215608.11305-1-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Stephen Hemminger , swise@opengridcomputing.com Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:47023 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbeEDWNK (ORCPT ); Fri, 4 May 2018 18:13:10 -0400 Received: by mail-pf0-f195.google.com with SMTP id p12so18432385pff.13 for ; Fri, 04 May 2018 15:13:09 -0700 (PDT) In-Reply-To: <20180504215608.11305-1-stephen@networkplumber.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/4/18 3:56 PM, Stephen Hemminger wrote: > All user api headers in iproute2 should be in include/uapi > so that script can be used to put correct sanitized kernel headers > there. And the header files for rdma must be a complete set; if one > header file includes another, all must be present. > > This fixes build on older distributions, and Windows Services > for Linux. > > Signed-off-by: Stephen Hemminger > --- > include/uapi/rdma/ib_user_sa.h | 77 ++ > include/uapi/rdma/ib_user_verbs.h | 1210 +++++++++++++++++ > .../uapi/rdma/rdma_netlink.h | 13 + > .../uapi/rdma/rdma_user_cm.h | 6 +- > 4 files changed, 1303 insertions(+), 3 deletions(-) > create mode 100644 include/uapi/rdma/ib_user_sa.h > create mode 100644 include/uapi/rdma/ib_user_verbs.h > rename {rdma/include => include}/uapi/rdma/rdma_netlink.h (95%) > rename {rdma/include => include}/uapi/rdma/rdma_user_cm.h (98%) > Stephen: Per a recent discussion the RDMA folks need to take ownership of the uapi files. RDMA features do not hit Dave's net-next tree so the rdma code can never hit iproute2-next during a dev cycle.