From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01DF1C433F5 for ; Mon, 7 Feb 2022 22:49:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245160AbiBGWtt (ORCPT ); Mon, 7 Feb 2022 17:49:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231463AbiBGWts (ORCPT ); Mon, 7 Feb 2022 17:49:48 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68F52C061355; Mon, 7 Feb 2022 14:49:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644274187; x=1675810187; h=message-id:date:mime-version:to:cc:references:from: subject:in-reply-to:content-transfer-encoding; bh=kCrDIOrEFsaqkXzsZbh8yWB/DwYaGsvCXUnA57EV60o=; b=WJXmPv2BjjL6DfXYwYsIBdAdfdhF9CFbHiMIAZtBYux70MVKmBgz83ZS Ny6HdO/W7RljLfbi5MYWYuMy/fdFBrjAjAoQl4LfchVXzWww7mRXUhyjd M6fEvyrtC/AHHYxKhC/aQb5YJQhyi+GKbyTrHW3JpOfZ1iRahdws+N4O3 9vmyP2MrFDsM3MITWnod+HZCKDdFpROaZaXcaD0kMPXJbxxh+RpZP6YwC 0THtEHQRgMlgp38sOg3abYKTfzn+3mzicF0R5KuP67Ldl225p7vg5Gmlb KkNgfyESWnAYd5OBXn5EyxMLJatP1v7M/WfvjPeRvJrFiE/4XtENEO65c A==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="248772691" X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="248772691" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 14:49:46 -0800 X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="525309179" Received: from hgrunes-mobl1.amr.corp.intel.com (HELO [10.251.3.57]) ([10.251.3.57]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 14:49:45 -0800 Message-ID: Date: Mon, 7 Feb 2022 14:49:45 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Dave Martin , Weijiang Yang , "Kirill A . Shutemov" , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com Cc: Yu-cheng Yu References: <20220130211838.8382-1-rick.p.edgecombe@intel.com> <20220130211838.8382-5-rick.p.edgecombe@intel.com> From: Dave Hansen Subject: Re: [PATCH 04/35] x86/cpufeatures: Introduce CPU setup and option parsing for CET In-Reply-To: <20220130211838.8382-5-rick.p.edgecombe@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > * Some CPU features depend on higher CPUID levels, which may not always > * be available due to CPUID level capping or broken virtualization > @@ -1261,6 +1269,9 @@ static void __init cpu_parse_early_param(void) > if (cmdline_find_option_bool(boot_command_line, "noxsaves")) > setup_clear_cpu_cap(X86_FEATURE_XSAVES); > > + if (cmdline_find_option_bool(boot_command_line, "no_user_shstk")) > + setup_clear_cpu_cap(X86_FEATURE_SHSTK); Given this: https://lore.kernel.org/all/20220127115626.14179-2-bp@alien8.de/ I'd probably yank the command-line option out of this series, or stick it in a separate patch that you tack on to the end.