All of lore.kernel.org
 help / color / mirror / Atom feed
From: 王贇 <yun.wang@linux.alibaba.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	open list <linux-kernel@vger.kernel.org>,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: [RESEND PATCH v2] trace: prevent preemption in perf_ftrace_function_call()
Date: Tue, 12 Oct 2021 13:51:13 +0800	[thread overview]
Message-ID: <d544af7d-60c2-bc3e-c7e4-eb26d5d7a836@linux.alibaba.com> (raw)
In-Reply-To: <20211011144510.GE174703@worktop.programming.kicks-ass.net>



On 2021/10/11 下午10:45, Peter Zijlstra wrote:
[snip]
>>>
>>> Oh, I might've gotten that wrong, I assumed regular trylock semantics,
>>> but it doesn't look like that's right.
>>
>> I will use bit instead ret and give some testing :-)
>>
>> BTW, would you prefer to merge these changes into this patch or maybe send
>> another patch with your suggested-by?
> 
> Yeah, please send another patch; once you've confirmed it actually works
> etc.. I did this before waking (as evidence per the above), who knows
> what else I did wrong :-)

I've send the:
  [PATCH 0/2] ftrace: make sure preemption disabled on recursion testing

should have taking care all the places, but only testing with x86 since I
got no machine for other arch... just by logically it should be fine.

Regards,
Michael Wang

> 

      reply	other threads:[~2021-10-12  5:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  3:12 [RESEND PATCH v2] trace: prevent preemption in perf_ftrace_function_call() 王贇
2021-10-09  0:03 ` Steven Rostedt
2021-10-11  2:38   ` 王贇
2021-10-11  8:32     ` Peter Zijlstra
2021-10-11  8:48       ` Peter Zijlstra
2021-10-11  9:39         ` 王贇
2021-10-11 14:45           ` Peter Zijlstra
2021-10-12  5:51             ` 王贇 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d544af7d-60c2-bc3e-c7e4-eb26d5d7a836@linux.alibaba.com \
    --to=yun.wang@linux.alibaba.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.