From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9262C433DB for ; Thu, 11 Feb 2021 20:18:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BC5B64E4A for ; Thu, 11 Feb 2021 20:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231727AbhBKUSg (ORCPT ); Thu, 11 Feb 2021 15:18:36 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:45450 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231743AbhBKUSV (ORCPT ); Thu, 11 Feb 2021 15:18:21 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 11BKGvU8006233; Thu, 11 Feb 2021 14:16:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1613074617; bh=kr2SCd91PPpyHaD2qofeEm2a8JukcuL1omeQb1kfYAY=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=gItRj/dhG56kIkp+3wnzTMbA3EdhiRuDOmVhfPKCs96JbqFwqbH/I3yis7UEUcjvH ZG5WILnk75vuyD0DSLqdauGsShgcv9plTyxCWM2pFi4iMUE22bGJMZHfp95ggOywyh Si9jHzYxVwu4IdUQJwLOLxDJgTeZ7mFeRU/387kQ= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 11BKGvwq105162 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 11 Feb 2021 14:16:57 -0600 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 11 Feb 2021 14:16:56 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 11 Feb 2021 14:16:56 -0600 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 11BKGrAU029198; Thu, 11 Feb 2021 14:16:54 -0600 Subject: Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler() To: Arnd Bergmann CC: Luo Jiaxing , Linus Walleij , Andy Shevchenko , Andy Shevchenko , Santosh Shilimkar , Kevin Hilman , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , References: <1612774577-55943-1-git-send-email-luojiaxing@huawei.com> <1612774577-55943-2-git-send-email-luojiaxing@huawei.com> From: Grygorii Strashko Message-ID: Date: Thu, 11 Feb 2021 22:16:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 11/02/2021 21:39, Arnd Bergmann wrote: > On Thu, Feb 11, 2021 at 7:25 PM Grygorii Strashko > wrote: >> On 08/02/2021 10:56, Luo Jiaxing wrote: >>> There is no need to use API with _irqsave in omap_gpio_irq_handler(), >>> because it already be in a irq-disabled context. >> >> NACK. >> Who said that this is always hard IRQ handler? >> What about RT-kernel or boot with "threadirqs"? > > In those cases, the interrupt handler is just a normal thread, so the > preempt_disable() that is implied by raw_spin_lock() is sufficient. > > Disabling interrupts inside of an interrupt handler is always incorrect, > the patch looks like a useful cleanup to me, if only for readability. Note. there is also generic_handle_irq() call inside. -- Best regards, grygorii