From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF8A8C07E99 for ; Thu, 8 Jul 2021 08:22:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D249961CE0 for ; Thu, 8 Jul 2021 08:22:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231175AbhGHIZj (ORCPT ); Thu, 8 Jul 2021 04:25:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230509AbhGHIZh (ORCPT ); Thu, 8 Jul 2021 04:25:37 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D466DC06175F for ; Thu, 8 Jul 2021 01:22:55 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m1PJ3-0005mQ-LG; Thu, 08 Jul 2021 10:22:49 +0200 Subject: Re: [PATCH] clk: imx8: Unified initcall function To: Rudy Lo Cc: Abel Vesa , Stephen Boyd , Fabio Estevam , Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org References: <20210708081543.186820-1-luhuadong@163.com> From: Ahmad Fatoum Message-ID: Date: Thu, 8 Jul 2021 10:22:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210708081543.186820-1-luhuadong@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Rudy, On 08.07.21 10:15, Rudy Lo wrote: > It is better to use builtin_platform_driver initcall for clk driver > rather then module_platform_driver, refer to clk-imx8qxp.c file. Commit messages should spell out why the change is needed, so why do you think it's better to revert 9a976cd278ea ("clk: imx8m: Support module build")? Cheers, Ahmad > > Signed-off-by: Rudy Lo > --- > drivers/clk/imx/clk-imx8mm.c | 2 +- > drivers/clk/imx/clk-imx8mn.c | 2 +- > drivers/clk/imx/clk-imx8mp.c | 2 +- > drivers/clk/imx/clk-imx8mq.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c > index f1919fafb124..fa20b08e64f1 100644 > --- a/drivers/clk/imx/clk-imx8mm.c > +++ b/drivers/clk/imx/clk-imx8mm.c > @@ -654,7 +654,7 @@ static struct platform_driver imx8mm_clk_driver = { > .of_match_table = imx8mm_clk_of_match, > }, > }; > -module_platform_driver(imx8mm_clk_driver); > +builtin_platform_driver(imx8mm_clk_driver); > > MODULE_AUTHOR("Bai Ping "); > MODULE_DESCRIPTION("NXP i.MX8MM clock driver"); > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c > index 88f6630cd472..67b9ded112e4 100644 > --- a/drivers/clk/imx/clk-imx8mn.c > +++ b/drivers/clk/imx/clk-imx8mn.c > @@ -605,7 +605,7 @@ static struct platform_driver imx8mn_clk_driver = { > .of_match_table = imx8mn_clk_of_match, > }, > }; > -module_platform_driver(imx8mn_clk_driver); > +builtin_platform_driver(imx8mn_clk_driver); > > MODULE_AUTHOR("Anson Huang "); > MODULE_DESCRIPTION("NXP i.MX8MN clock driver"); > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c > index 12837304545d..cdb40e61cef0 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -735,7 +735,7 @@ static struct platform_driver imx8mp_clk_driver = { > .of_match_table = imx8mp_clk_of_match, > }, > }; > -module_platform_driver(imx8mp_clk_driver); > +builtin_platform_driver(imx8mp_clk_driver); > > MODULE_AUTHOR("Anson Huang "); > MODULE_DESCRIPTION("NXP i.MX8MP clock driver"); > diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c > index c491bc9c61ce..54f17de30935 100644 > --- a/drivers/clk/imx/clk-imx8mq.c > +++ b/drivers/clk/imx/clk-imx8mq.c > @@ -630,7 +630,7 @@ static struct platform_driver imx8mq_clk_driver = { > .of_match_table = imx8mq_clk_of_match, > }, > }; > -module_platform_driver(imx8mq_clk_driver); > +builtin_platform_driver(imx8mq_clk_driver); > > MODULE_AUTHOR("Abel Vesa "); > MODULE_DESCRIPTION("NXP i.MX8MQ clock driver"); > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C28C07E96 for ; Thu, 8 Jul 2021 08:24:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCE9A61CE2 for ; Thu, 8 Jul 2021 08:24:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCE9A61CE2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=wQ5PMIyLDdGzVyDJvQ28bk+3FBXSOCyOZ1JpotPxVyQ=; b=Zvk4UfgOLDhLq0aC2BXONY8oRw e2ygLZQ9a2SkzWY7agtuQSvg5ojHS7BzxNgZebnCGL0YqBdXbB8I/WW3ltvxrsMmGVuPvJfYT6NUQ De7GHu27vgOyfiBE5zZCHp2Ldp31pqaQIuQkFkhZ3hsClPMXQg0g3pVWSoWQIowoYpz9Lpn4xgttL hmSfn5c37TTaYNcN7R6wrOjX0kBjxH+333QDHemVjDT1kpanRmpLgwYK2xn76yB7Doq2KqSTu0r3I 8S9O/V9h/1uEICEUJ1hnyuZGAEDMfWTA/3VkmEQfiBxh/VDdTZrkYB3WXIHVGEYcTwqDXwaAOYVho /Ona7xEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1PJ9-00GIjI-Dt; Thu, 08 Jul 2021 08:22:55 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1PJ6-00GIiY-0F for linux-arm-kernel@lists.infradead.org; Thu, 08 Jul 2021 08:22:53 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m1PJ3-0005mQ-LG; Thu, 08 Jul 2021 10:22:49 +0200 Subject: Re: [PATCH] clk: imx8: Unified initcall function To: Rudy Lo Cc: Abel Vesa , Stephen Boyd , Fabio Estevam , Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org References: <20210708081543.186820-1-luhuadong@163.com> From: Ahmad Fatoum Message-ID: Date: Thu, 8 Jul 2021 10:22:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210708081543.186820-1-luhuadong@163.com> Content-Language: en-US X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210708_012252_122005_5ECF8253 X-CRM114-Status: GOOD ( 21.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Rudy, On 08.07.21 10:15, Rudy Lo wrote: > It is better to use builtin_platform_driver initcall for clk driver > rather then module_platform_driver, refer to clk-imx8qxp.c file. Commit messages should spell out why the change is needed, so why do you think it's better to revert 9a976cd278ea ("clk: imx8m: Support module build")? Cheers, Ahmad > > Signed-off-by: Rudy Lo > --- > drivers/clk/imx/clk-imx8mm.c | 2 +- > drivers/clk/imx/clk-imx8mn.c | 2 +- > drivers/clk/imx/clk-imx8mp.c | 2 +- > drivers/clk/imx/clk-imx8mq.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c > index f1919fafb124..fa20b08e64f1 100644 > --- a/drivers/clk/imx/clk-imx8mm.c > +++ b/drivers/clk/imx/clk-imx8mm.c > @@ -654,7 +654,7 @@ static struct platform_driver imx8mm_clk_driver = { > .of_match_table = imx8mm_clk_of_match, > }, > }; > -module_platform_driver(imx8mm_clk_driver); > +builtin_platform_driver(imx8mm_clk_driver); > > MODULE_AUTHOR("Bai Ping "); > MODULE_DESCRIPTION("NXP i.MX8MM clock driver"); > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c > index 88f6630cd472..67b9ded112e4 100644 > --- a/drivers/clk/imx/clk-imx8mn.c > +++ b/drivers/clk/imx/clk-imx8mn.c > @@ -605,7 +605,7 @@ static struct platform_driver imx8mn_clk_driver = { > .of_match_table = imx8mn_clk_of_match, > }, > }; > -module_platform_driver(imx8mn_clk_driver); > +builtin_platform_driver(imx8mn_clk_driver); > > MODULE_AUTHOR("Anson Huang "); > MODULE_DESCRIPTION("NXP i.MX8MN clock driver"); > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c > index 12837304545d..cdb40e61cef0 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -735,7 +735,7 @@ static struct platform_driver imx8mp_clk_driver = { > .of_match_table = imx8mp_clk_of_match, > }, > }; > -module_platform_driver(imx8mp_clk_driver); > +builtin_platform_driver(imx8mp_clk_driver); > > MODULE_AUTHOR("Anson Huang "); > MODULE_DESCRIPTION("NXP i.MX8MP clock driver"); > diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c > index c491bc9c61ce..54f17de30935 100644 > --- a/drivers/clk/imx/clk-imx8mq.c > +++ b/drivers/clk/imx/clk-imx8mq.c > @@ -630,7 +630,7 @@ static struct platform_driver imx8mq_clk_driver = { > .of_match_table = imx8mq_clk_of_match, > }, > }; > -module_platform_driver(imx8mq_clk_driver); > +builtin_platform_driver(imx8mq_clk_driver); > > MODULE_AUTHOR("Abel Vesa "); > MODULE_DESCRIPTION("NXP i.MX8MQ clock driver"); > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel