From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [igt-dev] [PATCH i-g-t] tools/aubdump: Fix ISO C90 forbids mixed declarations and code warning Date: Tue, 10 Apr 2018 08:42:05 +0100 Message-ID: References: <20180409163539.13980-1-tvrtko.ursulin@linux.intel.com> <87fu441fdl.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87fu441fdl.fsf@intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Scott D Phillips , Tvrtko Ursulin , igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA5LzA0LzIwMTggMTg6MDMsIFNjb3R0IEQgUGhpbGxpcHMgd3JvdGU6Cj4gVHZydGtvIFVy c3VsaW4gPHR1cnN1bGluQHVyc3VsaW4ubmV0PiB3cml0ZXM6Cj4gCj4+IEZyb206IFR2cnRrbyBV cnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IEJhY2sgdG8gYSBjbGVhbiBi dWlsZCB3aXRoIG5vIHdhcm5pbmdzLCBhdCBsZWFzdCBmb3IgbWUuCj4gCj4gV2h5IGM5MD8gSWYg dGhhdCdzIHRoZSBsYW5ndWFnZSB3ZSBtZWFuIHRvIHRhcmdldCB0aGVuIHdlIHNob3VsZAo+IHBy b2JhYmx5IGFkZCBpdCB0byB0aGUgYnVpbGQgc3lzdGVtIHNvIHBlb3BsZSB3aXRoIGdjYyA1LjEg YW5kIGxhdGVyCj4gd2lsbCBzZWUgdGhlIHdhcm5pbmdzIHRvby4gZndpdywgbXkgYnVpbGQgd2l0 aCBjbGFuZyA2IGdpdmVzIGEgY291cGxlCj4gZG96ZW4gd2FybmluZ3MuCgpJIGFtIGJ1aWxkaW5n IHVuZGVyIFVidW50dSAxNy4xMCB3aXRoIEdDQyA3LjIuMC4gTm9ybWFsIGNvbmZpZ3VyZSAmJiAK bWFrZSwgYW5kIGdldCB0aGlzIHdhcm5pbmcuIEFuZCBzaW5jZSBJIGNhbid0IHNwb3QgdGhhdCBJ R1QgaXMgc2V0dGluZyAKdGhlIEMgc3RhbmRhcmQgZXhwbGljaXRseSwgSSBndWVzcyB0aGF0J3Mg dGhlIGRlZmF1bHQuCgpUaGlzIG9uZSBpcyB0aGUgb25seSB3YXJuaW5nIG9uIG15IGJ1aWxkIGJ0 dy4KClJlZ2FyZHMsCgpUdnJ0a28KCj4+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0 dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+IENjOiBKb3JkYW4gSnVzdGVuIDxqb3JkYW4ubC5q dXN0ZW5AaW50ZWwuY29tPgo+PiBDYzogU2NvdHQgRCBQaGlsbGlwcyA8c2NvdHQuZC5waGlsbGlw c0BpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIHRvb2xzL2F1YmR1bXAuYyB8IDcgKysrKy0tLQo+PiAg IDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4+Cj4+IGRp ZmYgLS1naXQgYS90b29scy9hdWJkdW1wLmMgYi90b29scy9hdWJkdW1wLmMKPj4gaW5kZXggMjY3 MDYxYjBmYzJiLi4yZDJiNmM2MDdhNDMgMTAwNjQ0Cj4+IC0tLSBhL3Rvb2xzL2F1YmR1bXAuYwo+ PiArKysgYi90b29scy9hdWJkdW1wLmMKPj4gQEAgLTM5NCwxMCArMzk0LDExIEBAIGdlbjhfZW1p dF9nZ3R0X3B0ZV9mb3JfcmFuZ2UodWludDY0X3Qgc3RhcnQsIHVpbnQ2NF90IGVuZCkKPj4gICAK Pj4gICAJZW50cnlfYWRkciA9IHN0YXJ0ICYgfig0MDk2IC0gMSk7Cj4+ICAgCWRvIHsKPj4gKwkJ dWludDY0X3QgbGFzdF9wYWdlX2VudHJ5LCBudW1fZW50cmllczsKPj4gKwo+PiAgIAkJcGFnZV9u dW0gPSBlbnRyeV9hZGRyID4+IDIxOwo+PiAtCQl1aW50NjRfdCBsYXN0X3BhZ2VfZW50cnkgPQo+ PiAtCQkJbWluKChwYWdlX251bSArIDEpIDw8IDIxLCBlbmRfYWxpZ25lZCk7Cj4+IC0JCXVpbnQ2 NF90IG51bV9lbnRyaWVzID0gKGxhc3RfcGFnZV9lbnRyeSAtIGVudHJ5X2FkZHIpID4+IDEyOwo+ PiArCQlsYXN0X3BhZ2VfZW50cnkgPSBtaW4oKHBhZ2VfbnVtICsgMSkgPDwgMjEsIGVuZF9hbGln bmVkKTsKPj4gKwkJbnVtX2VudHJpZXMgPSAobGFzdF9wYWdlX2VudHJ5IC0gZW50cnlfYWRkcikg Pj4gMTI7Cj4+ICAgCQltZW1fdHJhY2VfbWVtb3J5X3dyaXRlX2hlYWRlcl9vdXQoCj4+ICAgCQkJ ZW50cnlfYWRkciA+PiA5LCBudW1fZW50cmllcyAqIEdFTjhfUFRFX1NJWkUsCj4+ICAgCQkJQVVC X01FTV9UUkFDRV9NRU1PUllfQUREUkVTU19TUEFDRV9HR1RUX0VOVFJZKTsKPj4gLS0gCj4+IDIu MTQuMQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g aWd0LWRldiBtYWlsaW5nIGxpc3QKPiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo+IApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20180409163539.13980-1-tvrtko.ursulin@linux.intel.com> <87fu441fdl.fsf@intel.com> From: Tvrtko Ursulin Message-ID: Date: Tue, 10 Apr 2018 08:42:05 +0100 MIME-Version: 1.0 In-Reply-To: <87fu441fdl.fsf@intel.com> Content-Language: en-GB Subject: Re: [igt-dev] [PATCH i-g-t] tools/aubdump: Fix ISO C90 forbids mixed declarations and code warning List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Scott D Phillips , Tvrtko Ursulin , igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-ID: Ck9uIDA5LzA0LzIwMTggMTg6MDMsIFNjb3R0IEQgUGhpbGxpcHMgd3JvdGU6Cj4gVHZydGtvIFVy c3VsaW4gPHR1cnN1bGluQHVyc3VsaW4ubmV0PiB3cml0ZXM6Cj4gCj4+IEZyb206IFR2cnRrbyBV cnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IEJhY2sgdG8gYSBjbGVhbiBi dWlsZCB3aXRoIG5vIHdhcm5pbmdzLCBhdCBsZWFzdCBmb3IgbWUuCj4gCj4gV2h5IGM5MD8gSWYg dGhhdCdzIHRoZSBsYW5ndWFnZSB3ZSBtZWFuIHRvIHRhcmdldCB0aGVuIHdlIHNob3VsZAo+IHBy b2JhYmx5IGFkZCBpdCB0byB0aGUgYnVpbGQgc3lzdGVtIHNvIHBlb3BsZSB3aXRoIGdjYyA1LjEg YW5kIGxhdGVyCj4gd2lsbCBzZWUgdGhlIHdhcm5pbmdzIHRvby4gZndpdywgbXkgYnVpbGQgd2l0 aCBjbGFuZyA2IGdpdmVzIGEgY291cGxlCj4gZG96ZW4gd2FybmluZ3MuCgpJIGFtIGJ1aWxkaW5n IHVuZGVyIFVidW50dSAxNy4xMCB3aXRoIEdDQyA3LjIuMC4gTm9ybWFsIGNvbmZpZ3VyZSAmJiAK bWFrZSwgYW5kIGdldCB0aGlzIHdhcm5pbmcuIEFuZCBzaW5jZSBJIGNhbid0IHNwb3QgdGhhdCBJ R1QgaXMgc2V0dGluZyAKdGhlIEMgc3RhbmRhcmQgZXhwbGljaXRseSwgSSBndWVzcyB0aGF0J3Mg dGhlIGRlZmF1bHQuCgpUaGlzIG9uZSBpcyB0aGUgb25seSB3YXJuaW5nIG9uIG15IGJ1aWxkIGJ0 dy4KClJlZ2FyZHMsCgpUdnJ0a28KCj4+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0 dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+IENjOiBKb3JkYW4gSnVzdGVuIDxqb3JkYW4ubC5q dXN0ZW5AaW50ZWwuY29tPgo+PiBDYzogU2NvdHQgRCBQaGlsbGlwcyA8c2NvdHQuZC5waGlsbGlw c0BpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIHRvb2xzL2F1YmR1bXAuYyB8IDcgKysrKy0tLQo+PiAg IDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4+Cj4+IGRp ZmYgLS1naXQgYS90b29scy9hdWJkdW1wLmMgYi90b29scy9hdWJkdW1wLmMKPj4gaW5kZXggMjY3 MDYxYjBmYzJiLi4yZDJiNmM2MDdhNDMgMTAwNjQ0Cj4+IC0tLSBhL3Rvb2xzL2F1YmR1bXAuYwo+ PiArKysgYi90b29scy9hdWJkdW1wLmMKPj4gQEAgLTM5NCwxMCArMzk0LDExIEBAIGdlbjhfZW1p dF9nZ3R0X3B0ZV9mb3JfcmFuZ2UodWludDY0X3Qgc3RhcnQsIHVpbnQ2NF90IGVuZCkKPj4gICAK Pj4gICAJZW50cnlfYWRkciA9IHN0YXJ0ICYgfig0MDk2IC0gMSk7Cj4+ICAgCWRvIHsKPj4gKwkJ dWludDY0X3QgbGFzdF9wYWdlX2VudHJ5LCBudW1fZW50cmllczsKPj4gKwo+PiAgIAkJcGFnZV9u dW0gPSBlbnRyeV9hZGRyID4+IDIxOwo+PiAtCQl1aW50NjRfdCBsYXN0X3BhZ2VfZW50cnkgPQo+ PiAtCQkJbWluKChwYWdlX251bSArIDEpIDw8IDIxLCBlbmRfYWxpZ25lZCk7Cj4+IC0JCXVpbnQ2 NF90IG51bV9lbnRyaWVzID0gKGxhc3RfcGFnZV9lbnRyeSAtIGVudHJ5X2FkZHIpID4+IDEyOwo+ PiArCQlsYXN0X3BhZ2VfZW50cnkgPSBtaW4oKHBhZ2VfbnVtICsgMSkgPDwgMjEsIGVuZF9hbGln bmVkKTsKPj4gKwkJbnVtX2VudHJpZXMgPSAobGFzdF9wYWdlX2VudHJ5IC0gZW50cnlfYWRkcikg Pj4gMTI7Cj4+ICAgCQltZW1fdHJhY2VfbWVtb3J5X3dyaXRlX2hlYWRlcl9vdXQoCj4+ICAgCQkJ ZW50cnlfYWRkciA+PiA5LCBudW1fZW50cmllcyAqIEdFTjhfUFRFX1NJWkUsCj4+ICAgCQkJQVVC X01FTV9UUkFDRV9NRU1PUllfQUREUkVTU19TUEFDRV9HR1RUX0VOVFJZKTsKPj4gLS0gCj4+IDIu MTQuMQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g aWd0LWRldiBtYWlsaW5nIGxpc3QKPiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo+IApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1h aWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK