From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06EFDC433DB for ; Tue, 19 Jan 2021 06:41:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEB552311F for ; Tue, 19 Jan 2021 06:41:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726044AbhASFiS (ORCPT ); Tue, 19 Jan 2021 00:38:18 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:33491 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726991AbhASFRy (ORCPT ); Tue, 19 Jan 2021 00:17:54 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 7482C1208; Tue, 19 Jan 2021 00:16:34 -0500 (EST) Received: from imap5 ([10.202.2.55]) by compute2.internal (MEProxy); Tue, 19 Jan 2021 00:16:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mxxn.io; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type:content-transfer-encoding; s=fm1; bh=YDAKd F+AcV0IOYUFAl7UZNcNA1Tj/4JTP0p+Ir8b2cI=; b=KyenI5Z9EOV6MU2bX/LAY 72TWS8wH+xOQdwmizKtzF1TGQ3hDRuQVJqZ/H9KCv2XY1LD7GTKk02rpd0uPZZRC sbLiHsmNm3rAZximIWq0aILsQMX3vpgopoh1+ewtJCrK8zO4wu9i63Kde5m6Hvj+ FmKBiQTc/7q7oCmPBve+HLxR2uDC+TYqjBRRFuZCyB+u3c685efzzUGxOphgI500 Hx8Jw3BcWtzQ2sd/jpjrUa77TKmAFQIO01qrTkZHURW1hvU3SihCSNrXBaLtXUzA WfDnE5LUmdQPBt29tw/IJqLGVG2KVS/JNdGmkt/osBldvCjGKmyPHb0PB5wWAGkE g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=YDAKdF+AcV0IOYUFAl7UZNcNA1Tj/4JTP0p+Ir8b2 cI=; b=EjzOaPNGFlXNxVRpIHMZco6LNPt/pz+0eNp/ED+96YF9dpH/0/54jYWi8 uq9ISg6T4oZqsLc536ra6RMp6W2fZvnM4BMMvROmTBhkB05OBCE9M0mqx81gg34N w5J0Ca97Zv8WU5KbANilo8jM0YO9KY/SykVrmUHgOCBNRVqp7Q/EaekJ2U+EvTjK gvezJfwnutIM4hk3Xy3xYSSw/YBWAOyNurZLfqsoSUKzNv1eqhPgBCyzVotCQWnu H6/jTFuUa2gsDmiFlMAhXv2bozWIVWaaL0rk2bsH2LJqrhpgnBXj56Mry9RgIePU 9oow767GPjs1BL9vxbEDpZBuEUnLg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdelgdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtgfesthhqredtreerjeenucfhrhhomhepuehlrgkk pgfjrhgrshhtnhhikhcuoegslhgriiesmhiggihnrdhioheqnecuggftrfgrthhtvghrnh epueetveelffduheefgeeftdfgvedttefhgfekhfekgfdtvdffvefhieetvdefudevnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghlrgiise hmgiignhdrihho X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id B6CF25C0099; Tue, 19 Jan 2021 00:16:33 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-45-g4839256-fm-20210104.001-g48392560 Mime-Version: 1.0 Message-Id: In-Reply-To: References: Date: Tue, 19 Jan 2021 14:15:58 +0900 From: =?UTF-8?Q?Bla=C5=BE_Hrastnik?= To: "Jean Delvare" , "Guenter Roeck" , "Jonathan Corbet" , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, lkml Cc: "David Bartley" Subject: Re: hwmon: (nct6683) Support ASRock boards. Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org (cc-ing David Bartley, who wrote the MSI patch) I had a follow-up question: I noticed that support for MSI was added in December, but there's this conditional that wasn't changed: /* Only update pwm values for Mitac boards */ if (data->customer_id =3D=3D NCT6683_CUSTOMER_ID_MITAC) return attr->mode | S_IWUSR; Should this continue to only apply for Mitac boards, or should it be cha= nged to !=3D NCT6683_CUSTOMER_ID_INTEL? Bla=C5=BE