All of lore.kernel.org
 help / color / mirror / Atom feed
From: "chensong_2000@189.cn" <chensong_2000@189.cn>
To: Florian Bezdeka <florian.bezdeka@siemens.com>, xenomai@xenomai.org
Subject: Re: [PATCH v3 0/5] y2038: Adding support for mq_timed{send,recv}64
Date: Thu, 12 Aug 2021 14:52:46 +0800	[thread overview]
Message-ID: <d5688bef-5be8-9915-439d-691b64cbc70c@189.cn> (raw)
In-Reply-To: <20210810102451.49642-1-florian.bezdeka@siemens.com>



在 2021/8/10 下午6:24, Florian Bezdeka 写道:
> Hi all,
> 
> this is kind of a re-send of the patch series originall published by
> Song. There were some things that had to be addressed:
> 
>   - Code formattings
>   - Copy paste errors in the test suite
>   - Failing / incomplete tests, missing test cleanups
>   - Incorrect compat syscall declerations
> 
> @Song: Especially the missing test cleanups and the incorrect compat
> syscall declerations made me unhappy. Did you really test that once?
> Please make sure to send properly tested patches. There are many
> pitfalls in the game which makes the review process time consuming,
> especially when I have to assume that it was not tested till now

hi Florian,

Sorry about that.

In general, each patch has been built correctly and passed "sudo 
./testsuite/smokey/smokey --run=27" and checkpatch. I also followed your 
comments or your modification in the next version or next patch, even in 
commit message.

There might be something going wrong and i can't recall which and why, 
but it won't happen again.

Sorry again.

/Song
> 
> Changes in v3:
>    - Patch 3: Fix timespec validation
>    - Patch 5: Fix tests for mq_timedreceive64()
>    - Patch 5: Fixed typos
> 
> Florian Bezdeka (1):
>    y2038: testsuite/smokey/y2038: Adding tests for mq_timed{send,recv}64
> 
> Song Chen (4):
>    y2038: cobalt/posix/mqueue: Adding mq_timedsend64
>    y2038: lib/cobalt/mqueue: dispatch mq_timedsend
>    y2038: cobalt/posix/muqueue: Adding mq_timedreceive64
>    y2038: lib/cobalt/mqueue: dispatch mq_timedreceive
> 
>   include/cobalt/uapi/syscall.h          |   2 +
>   kernel/cobalt/posix/mqueue.c           |  51 ++++++-
>   kernel/cobalt/posix/mqueue.h           |  18 +++
>   kernel/cobalt/posix/syscall32.c        |  16 +++
>   kernel/cobalt/posix/syscall32.h        |  10 ++
>   kernel/cobalt/trace/cobalt-posix.h     |   4 +-
>   lib/cobalt/mq.c                        |  10 ++
>   testsuite/smokey/y2038/syscall-tests.c | 190 ++++++++++++++++++++++++-
>   8 files changed, 297 insertions(+), 4 deletions(-)
> 


      parent reply	other threads:[~2021-08-12  6:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 10:24 [PATCH v3 0/5] y2038: Adding support for mq_timed{send,recv}64 Florian Bezdeka
2021-08-10 10:24 ` [PATCH v3 1/5] y2038: cobalt/posix/mqueue: Adding mq_timedsend64 Florian Bezdeka
2021-08-10 10:24 ` [PATCH v3 2/5] y2038: lib/cobalt/mqueue: dispatch mq_timedsend Florian Bezdeka
2021-08-10 10:24 ` [PATCH v3 3/5] y2038: cobalt/posix/muqueue: Adding mq_timedreceive64 Florian Bezdeka
2021-08-10 10:24 ` [PATCH v3 4/5] y2038: lib/cobalt/mqueue: dispatch mq_timedreceive Florian Bezdeka
2021-08-10 10:24 ` [PATCH v3 5/5] y2038: testsuite/smokey/y2038: Adding tests for mq_timed{send, recv}64 Florian Bezdeka
2021-08-12  6:52 ` chensong_2000 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5688bef-5be8-9915-439d-691b64cbc70c@189.cn \
    --to=chensong_2000@189.cn \
    --cc=florian.bezdeka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.