From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 813E0C6FD1F for ; Tue, 14 Mar 2023 03:28:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E5F178613B; Tue, 14 Mar 2023 04:28:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 20BFD8613B; Tue, 14 Mar 2023 04:28:49 +0100 (CET) Received: from mail-m11874.qiye.163.com (mail-m11874.qiye.163.com [115.236.118.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3658685D7B for ; Tue, 14 Mar 2023 04:28:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11874.qiye.163.com (Hmail) with ESMTPA id 6F5963C01A3; Tue, 14 Mar 2023 11:28:33 +0800 (CST) Message-ID: Date: Tue, 14 Mar 2023 11:28:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 10/12] rockchip: include: configs: Remove dangling comments Content-Language: en-US To: Jonas Karlman , Simon Glass , Philipp Tomsich , Jagan Teki Cc: Jagan Teki , Eugen Hristev , u-boot@lists.denx.de References: <20230314003755.512696-1-jonas@kwiboo.se> <20230314003755.512696-11-jonas@kwiboo.se> From: Kever Yang In-Reply-To: <20230314003755.512696-11-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGhpCQlZJGEJMTE9LGUIaSk5VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSkpLSEpMVUpLS1VLWQ Y+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PD46HDo4Hz0LVi0fHk1NDCEf DQ8wCUJVSlVKTUxDTE1PTkpPSUhLVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFNS09ONwY+ X-HM-Tid: 0a86de2999ec2eb0kusn6f5963c01a3 X-HM-MType: 1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/3/14 08:38, Jonas Karlman wrote: > This removes dangling comments that no longer serve a purpose and has > been left after conversion of defines to Kconfig option. > > Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever > --- > include/configs/rk3128_common.h | 4 ---- > include/configs/rk3188_common.h | 5 ----- > include/configs/rk3288_common.h | 2 -- > include/configs/rk3328_common.h | 1 - > include/configs/rk3399_common.h | 1 - > include/configs/rockchip-common.h | 2 -- > include/configs/rv1108_common.h | 2 -- > include/configs/vyasa-rk3288.h | 6 ------ > 8 files changed, 23 deletions(-) > > diff --git a/include/configs/rk3128_common.h b/include/configs/rk3128_common.h > index 8aa17bfbd364..8736b14d1015 100644 > --- a/include/configs/rk3128_common.h > +++ b/include/configs/rk3128_common.h > @@ -12,13 +12,9 @@ > > #define CFG_IRAM_BASE 0x10080000 > > -/* RAW SD card / eMMC locations. */ > - > #define CFG_SYS_SDRAM_BASE 0x60000000 > #define SDRAM_MAX_SIZE 0x80000000 > > -/* usb mass storage */ > - > #define ENV_MEM_LAYOUT_SETTINGS \ > "scriptaddr=0x60500000\0" \ > "pxefile_addr_r=0x60600000\0" \ > diff --git a/include/configs/rk3188_common.h b/include/configs/rk3188_common.h > index ac9195672fb7..ebb421c69297 100644 > --- a/include/configs/rk3188_common.h > +++ b/include/configs/rk3188_common.h > @@ -11,15 +11,10 @@ > > #define CFG_IRAM_BASE 0x10080000 > > -/* spl size 32kb sram - 2kb bootrom */ > - > #define CFG_SYS_SDRAM_BASE 0x60000000 > #define SDRAM_BANK_SIZE (2UL << 30) > #define SDRAM_MAX_SIZE 0x80000000 > > -/* usb otg */ > - > -/* usb host support */ > #define ENV_MEM_LAYOUT_SETTINGS \ > "scriptaddr=0x60000000\0" \ > "pxefile_addr_r=0x60100000\0" \ > diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h > index 5f29432be10b..fa409c70c931 100644 > --- a/include/configs/rk3288_common.h > +++ b/include/configs/rk3288_common.h > @@ -13,8 +13,6 @@ > > #define CFG_IRAM_BASE 0xff700000 > > -/* RAW SD card / eMMC locations. */ > - > #define CFG_SYS_SDRAM_BASE 0 > #define SDRAM_BANK_SIZE (2UL << 30) > #define SDRAM_MAX_SIZE 0xfe000000 > diff --git a/include/configs/rk3328_common.h b/include/configs/rk3328_common.h > index 24b21c024dee..e565ccff8979 100644 > --- a/include/configs/rk3328_common.h > +++ b/include/configs/rk3328_common.h > @@ -10,7 +10,6 @@ > > #define CFG_IRAM_BASE 0xff090000 > > -/* FAT sd card locations. */ > #define CFG_SYS_SDRAM_BASE 0 > #define SDRAM_MAX_SIZE 0xff000000 > > diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h > index 3ef9ffa2e9c4..04dcbf20bcb5 100644 > --- a/include/configs/rk3399_common.h > +++ b/include/configs/rk3399_common.h > @@ -10,7 +10,6 @@ > > #define CFG_IRAM_BASE 0xff8c0000 > > -/* FAT sd card locations. */ > #define CFG_SYS_SDRAM_BASE 0 > #define SDRAM_MAX_SIZE 0xf8000000 > > diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h > index b7c5c6634394..18544d75acc6 100644 > --- a/include/configs/rockchip-common.h > +++ b/include/configs/rockchip-common.h > @@ -11,8 +11,6 @@ > #define CFG_CPUID_OFFSET 0x7 > #endif > > -/* ((CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR - 64) * 512) */ > - > #ifndef CONFIG_SPL_BUILD > > /* First try to boot from SD (index 1), then eMMC (index 0) */ > diff --git a/include/configs/rv1108_common.h b/include/configs/rv1108_common.h > index 63551b47e200..050d37bff0b5 100644 > --- a/include/configs/rv1108_common.h > +++ b/include/configs/rv1108_common.h > @@ -17,8 +17,6 @@ > > #define CFG_SYS_SDRAM_BASE 0x60000000 > > -/* rockchip ohci host driver */ > - > #define ENV_MEM_LAYOUT_SETTINGS \ > "scriptaddr=0x60000000\0" \ > "fdt_addr_r=0x61f00000\0" \ > diff --git a/include/configs/vyasa-rk3288.h b/include/configs/vyasa-rk3288.h > index e8c1013a71a3..81ff61bf7a6a 100644 > --- a/include/configs/vyasa-rk3288.h > +++ b/include/configs/vyasa-rk3288.h > @@ -20,10 +20,4 @@ > #define BOOT_TARGET_DEVICES(func) \ > func(MMC, mmc, 1) \ > > -#ifndef CONFIG_TPL_BUILD > -/* Falcon Mode */ > - > -/* Falcon Mode - MMC support: args@16MB kernel@17MB */ > -#endif > - > #endif