From: Hans de Goede <hdegoede@redhat.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bastien Nocera <hadess@hadess.net>,
Dmitry Mastykin <mastichi@gmail.com>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
Date: Wed, 1 Jan 2020 15:51:52 +0100 [thread overview]
Message-ID: <d56d3764-e82a-4969-6579-d4d3a17a1d3d@redhat.com> (raw)
In-Reply-To: <20191230100844.GC2628@lahna.fi.intel.com>
Hi,
On 30-12-2019 11:08, Mika Westerberg wrote:
> On Fri, Dec 27, 2019 at 11:47:38PM +0100, Hans de Goede wrote:
>> The problem is that we hit this path everytime we output a value on the
>> pin. I guess we can change the WARN to dev_info_once() if you prefer that.
>
> Yes, I think dev_info_once() would be fine.
Ok, version 3 replacing the WARN() with a dev_info_once coming up.
Regards,
Hans
prev parent reply other threads:[~2020-01-01 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 13:28 [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output Hans de Goede
2019-12-27 14:12 ` Mika Westerberg
2019-12-27 22:47 ` Hans de Goede
2019-12-30 10:08 ` Mika Westerberg
2020-01-01 14:51 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d56d3764-e82a-4969-6579-d4d3a17a1d3d@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hadess@hadess.net \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mastichi@gmail.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.