From mboxrd@z Thu Jan  1 00:00:00 1970
From: Faiz Abbas <faiz_abbas@ti.com>
Date: Wed, 1 Jul 2020 14:21:21 +0530
Subject: Bisected: omap_hsmmc 3.3V IO voltage incompatible with N900 (Was:
 Re: Bisected: mmc cause reboot loops on N900)
In-Reply-To: <20200701083209.pzjr7edgvanfwkz2@pali>
References: <20200425104217.pzp5zkhhft5a2he5@pali>
 <CAHCN7x+kVwAfm1HtxCEv8eRoW9AQWJLPkjiGRbz5+J4Ymb+Jnw@mail.gmail.com>
 <20200425115045.w45tb62cnwtq5umk@pali> <20200425212615.4wzs32p6pgvivsq6@pali>
 <20200425222007.5iasodfuu3jsjktt@pali> <20200425222932.rauirshrgi6qgdta@pali>
 <5ec5f853-ea6d-221a-5fe6-7e0aefff29c0@ti.com>
 <20200507151938.jq53mkum7cjldy42@pali> <20200526174954.u6xxdkvesy5kaerq@pali>
 <20200612130306.5qjfonf2kfkaervv@pali> <20200701083209.pzjr7edgvanfwkz2@pali>
Message-ID: <d5881660-435b-5552-6cbe-8c72165ded50@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Pali,

On 01/07/20 2:02 pm, Pali Roh?r wrote:
> On Friday 12 June 2020 15:03:06 Pali Roh?r wrote:
>> On Tuesday 26 May 2020 19:49:54 Pali Roh?r wrote:
>>> On Thursday 07 May 2020 17:19:38 Pali Roh?r wrote:
>>>> On Thursday 07 May 2020 19:10:14 Faiz Abbas wrote:
>>>>> On 26/04/20 3:59 am, Pali Roh?r wrote:
>>>>>> On Sunday 26 April 2020 00:20:07 Pali Roh?r wrote:
>>>>>>> On Saturday 25 April 2020 23:26:15 Pali Roh?r wrote:
>>>>>>>> Now I tried git bisect and here is problematic commit which caused whole
>>>>>>>> reboot loop:
>>>>>>>>
...
>>>
>>> Hello Faiz!
>>>
>>> Now I figured out what is the root cause of second 3.0V vs 3.3V problem.
>>>
>>> In commit d2c05f50e12f87128597a28146de7092aaa847c3 you forgot to replace
>>> one usage of 3.0V by 3.3V. Below is patch which changes also this last
>>> one usage. Applying it has same effect on Nokia N900 as reverting
>>> that problematic commit d2c05f50e12f87128597a28146de7092aaa847c3:
>>>
>>> diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
>>> index 8636cd713a..dc26e54795 100644
>>> --- a/drivers/mmc/omap_hsmmc.c
>>> +++ b/drivers/mmc/omap_hsmmc.c
>>> @@ -840,7 +840,7 @@ static int omap_hsmmc_init_setup(struct mmc *mmc)
>>>  	omap_hsmmc_conf_bus_power(mmc, (reg_val & VS33_3V3SUP) ?
>>>  			  MMC_SIGNAL_VOLTAGE_330 : MMC_SIGNAL_VOLTAGE_180);
>>>  #else
>>> -	writel(DTW_1_BITMODE | SDBP_PWROFF | SDVS_3V0, &mmc_base->hctl);
>>> +	writel(DTW_1_BITMODE | SDBP_PWROFF | SDVS_3V3, &mmc_base->hctl);
>>>  	writel(readl(&mmc_base->capa) | VS33_3V3SUP | VS18_1V8SUP,
>>>  		&mmc_base->capa);
>>>  #endif
>>>
>>> So eMMC on real N900 is working fine either with 3.0V or 3.3V. But 3.3V
>>> needs to be configured on all places.
>>
>> Hello! Could you please take a look at this issue and my above fix?
> 
> Ping. Any comment for above issue or my fix?
> 

Sorry I missed this earlier. The fix makes sense to me. I can give my reviewed
by to the your fix once you send the patch.

Thanks,
Faiz