All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Devendra Tewari <devendra.tewari@gmail.com>,
	Khem Raj <raj.khem@gmail.com>
Cc: Andre McCurdy <armccurdy@gmail.com>,
	OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] Use shutil.move when os.rename fails
Date: Wed, 21 Apr 2021 19:10:20 +0100	[thread overview]
Message-ID: <d59ab2e71f0115018fb1c957276ce71e3292cd95.camel@linuxfoundation.org> (raw)
In-Reply-To: <F23C2F80-7F48-4384-A946-34152D4FCBDD@gmail.com>

On Wed, 2021-04-21 at 11:43 -0300, Devendra Tewari wrote:
> I created an image for Raspberry Pi Zero W from code at  
> https://github.com/tewarid/docker-meta-raspberrypi/tree/sstate, using Docker for macOS, and on Ubuntu 20.04-
> LTS, and wrote it out to an SDCard using bmaptool. Booted and checked that busybox symlinks in rootfs look
> all right.
> 
> > Em 21 de abr. de 2021, à(s) 02:22, Khem Raj <raj.khem@gmail.com> escreveu:
> > 
> > None of my images are bootable when this patch is applied, because
> > symlinks that busybox should provide arent created in the image. This
> > patch should be looked into a bit further,  how was it tested ?

I think there is some element to this we're not understanding. I'm also
worried that the exception is quite generic, OSError covers a lot of things
and we probably need to make it more specific.

I'd suggest we add a patch changing all the call sites to use a new
wrapper function in bb.utils and then we can adjust that single site to
handle issues as they arise and as we understand them.

Cheers,

Richard


  parent reply	other threads:[~2021-04-21 18:10 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 15:14 [PATCH] Use shutil.move when os.rename fails devendra.tewari
2021-03-29 15:21 ` [OE-core] " Bruce Ashfield
2021-03-29 15:23   ` Konrad Weihmann
2021-03-29 15:35     ` Devendra Tewari
2021-03-29 15:37       ` Devendra Tewari
2021-03-30 21:59         ` Denys Dmytriyenko
2021-03-30 22:38           ` Devendra Tewari
2021-04-01 19:14             ` Devendra Tewari
2021-03-29 20:38 ` Richard Purdie
2021-03-29 22:45   ` Devendra Tewari
2021-03-29 23:00     ` Andre McCurdy
2021-03-29 23:07       ` Devendra Tewari
2021-03-29 23:10         ` Andre McCurdy
2021-03-29 23:13           ` Devendra Tewari
2021-03-30 10:16             ` Devendra Tewari
2021-03-30 11:10       ` Richard Purdie
2021-03-30 11:55         ` Devendra Tewari
2021-04-19 18:43           ` Devendra Tewari
2021-04-21  5:21             ` Khem Raj
2021-04-21 14:43               ` Devendra Tewari
2021-04-21 15:15                 ` Khem Raj
2021-04-21 18:10                 ` Richard Purdie [this message]
2021-04-21 19:15                   ` Devendra Tewari
2021-04-21 19:21                     ` Richard Purdie
2021-04-21 21:08                       ` Devendra Tewari
2021-04-27 11:57                         ` Devendra Tewari
2021-04-27 14:59                           ` Devendra Tewari
2021-04-27 22:39                             ` Richard Purdie
2021-04-27 22:44                               ` Devendra Tewari
2021-04-27 22:53                                 ` Devendra Tewari
2021-04-28 10:00                                   ` Devendra Tewari
2021-04-28 21:42                                     ` Richard Purdie
2021-04-28 23:02                                       ` Devendra Tewari
     [not found]                                       ` <90B42906-44DE-4D61-8210-669DC25BBD3F@gmail.com>
2022-08-22 12:25                                         ` Devendra Tewari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d59ab2e71f0115018fb1c957276ce71e3292cd95.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=armccurdy@gmail.com \
    --cc=devendra.tewari@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.