From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F34BC433F5 for ; Mon, 18 Apr 2022 03:40:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236086AbiDRDmx (ORCPT ); Sun, 17 Apr 2022 23:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiDRDmw (ORCPT ); Sun, 17 Apr 2022 23:42:52 -0400 Received: from mail-sz.amlogic.com (mail-sz.amlogic.com [211.162.65.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69B4CAE72; Sun, 17 Apr 2022 20:40:13 -0700 (PDT) Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 18 Apr 2022 11:40:10 +0800 Message-ID: Date: Mon, 18 Apr 2022 11:40:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Content-Language: en-US From: Liang Yang To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> In-Reply-To: <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, i have some confusion when i prepare the patches. for DT compatibility, it falls back to the old DT when failed to get resource by the new DT, but there is some points: a. old DT depends on MMC sub clock driver, but it never be merged, so it can't work. b. if it falls back to the old DT, beside the regmap lookup below, it seems that we have to preserve the code of the old clock setting in nfc_clk_init(). do we still need to avoid break DT compatibility? Thanks. On 2022/4/11 10:40, Liang Yang wrote: >>>       nfc->dev = dev; >>> -    res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> -    nfc->reg_base = devm_ioremap_resource(dev, res); >>> +    nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc"); >> >> This change seems unrelated. > > To be consistent with the following > devm_platform_ioremap_resource_byname(pdev, "emmc"). do you mean that we > don't need it?> >>>       if (IS_ERR(nfc->reg_base)) >>>           return PTR_ERR(nfc->reg_base); >>> -    nfc->reg_clk = >>> -        syscon_regmap_lookup_by_phandle(dev->of_node, >>> -                        "amlogic,mmc-syscon"); >>> -    if (IS_ERR(nfc->reg_clk)) { >>> -        dev_err(dev, "Failed to lookup clock base\n"); >>> -        return PTR_ERR(nfc->reg_clk); >>> -    } >>> +    nfc->sd_emmc_clock = devm_platform_ioremap_resource_byname(pdev, >>> "emmc"); >>> +    if (IS_ERR(nfc->sd_emmc_clock)) >>> +        return PTR_ERR(nfc->sd_emmc_clock); >> >> While I agree this is much better than the previous solution, we cannot >> break DT compatibility, so you need to try getting the emmc clock, but >> if it fails you should fallback to the regmap lookup. > > ok, i will fix it next version. thanks. > >> >>>       irq = platform_get_irq(pdev, 0); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E5F5C433F5 for ; Mon, 18 Apr 2022 03:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:CC:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UOf7Iu7pdNLMXDjOouoJPiUpEZe7fhS/Oe6mo4xGmfQ=; b=yhOik3LDZatYLH Fy5ZsZNdABqF6BaLrAfR03uDi9TII8rqkjgLAGpmtxN/9FySTAv8ie1haDwbW2C6gNj6Aq+60ehw4 R99k6mi9jcHQqthVpVIKlK+++q/ZAPX1N7wvkxPBHz4i6oklzeDsyMptCgKxskIwrvI4mFe2B6H/0 ceK6Hiz9IktxyGlL1noZQM5Zdqi2FQ13PZP2SUJF/Oi09nFzMKG23CpzdFpkPWrJNfX/6FD1TSE0I 6wJyYNwGiAi5VXKAZ8j7hK1Lha9+4CEVX7FeUw7DRcfuPGhRbq5uTi/g6ni6/HvmE7oUqzeoDjUYW I+ykVucT4VTj0MMjPA6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngIFR-00FSpD-FM; Mon, 18 Apr 2022 03:40:21 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngIFP-00FSnr-AL; Mon, 18 Apr 2022 03:40:20 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 18 Apr 2022 11:40:10 +0800 Message-ID: Date: Mon, 18 Apr 2022 11:40:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Content-Language: en-US From: Liang Yang To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> In-Reply-To: <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220417_204019_384654_135B7E4F X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgTWlxdWVsLAoKaSBoYXZlIHNvbWUgY29uZnVzaW9uIHdoZW4gaSBwcmVwYXJlIHRoZSBwYXRj aGVzLiBmb3IgRFQgY29tcGF0aWJpbGl0eSwgCml0IGZhbGxzIGJhY2sgdG8gdGhlIG9sZCBEVCB3 aGVuIGZhaWxlZCB0byBnZXQgcmVzb3VyY2UgYnkgdGhlIG5ldyBEVCwgCmJ1dCB0aGVyZSBpcyBz b21lIHBvaW50czoKYS4gb2xkIERUIGRlcGVuZHMgb24gTU1DIHN1YiBjbG9jayBkcml2ZXIsIGJ1 dCBpdCBuZXZlciBiZSBtZXJnZWQsIHNvIGl0IApjYW4ndCB3b3JrLgpiLiBpZiBpdCBmYWxscyBi YWNrIHRvIHRoZSBvbGQgRFQsIGJlc2lkZSB0aGUgcmVnbWFwIGxvb2t1cCBiZWxvdywgaXQgCnNl ZW1zIHRoYXQgd2UgaGF2ZSB0byBwcmVzZXJ2ZSB0aGUgY29kZSBvZiB0aGUgb2xkIGNsb2NrIHNl dHRpbmcgaW4gCm5mY19jbGtfaW5pdCgpLiBkbyB3ZSBzdGlsbCBuZWVkIHRvIGF2b2lkIGJyZWFr IERUIGNvbXBhdGliaWxpdHk/CgpUaGFua3MuCgpPbiAyMDIyLzQvMTEgMTA6NDAsIExpYW5nIFlh bmcgd3JvdGU6Cj4+PiDCoMKgwqDCoMKgIG5mYy0+ZGV2ID0gZGV2Owo+Pj4gLcKgwqDCoCByZXMg PSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UocGRldiwgSU9SRVNPVVJDRV9NRU0sIDApOwo+Pj4gLcKg wqDCoCBuZmMtPnJlZ19iYXNlID0gZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgcmVzKTsKPj4+ ICvCoMKgwqAgbmZjLT5yZWdfYmFzZSA9IGRldm1fcGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZV9i eW5hbWUocGRldiwgIm5mYyIpOwo+Pgo+PiBUaGlzIGNoYW5nZSBzZWVtcyB1bnJlbGF0ZWQuCj4g Cj4gVG8gYmUgY29uc2lzdGVudCB3aXRoIHRoZSBmb2xsb3dpbmcgCj4gZGV2bV9wbGF0Zm9ybV9p b3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCAiZW1tYyIpLiBkbyB5b3UgbWVhbiB0aGF0IHdl IAo+IGRvbid0IG5lZWQgaXQ/Pgo+Pj4gwqDCoMKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2Jh c2UpKQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBQVFJfRVJSKG5mYy0+cmVnX2Jhc2Up Owo+Pj4gLcKgwqDCoCBuZmMtPnJlZ19jbGsgPQo+Pj4gLcKgwqDCoMKgwqDCoMKgIHN5c2Nvbl9y ZWdtYXBfbG9va3VwX2J5X3BoYW5kbGUoZGV2LT5vZl9ub2RlLAo+Pj4gLcKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgImFtbG9naWMsbW1jLXN5c2NvbiIpOwo+ Pj4gLcKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2NsaykpIHsKPj4+IC3CoMKgwqDCoMKgwqDC oCBkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBsb29rdXAgY2xvY2sgYmFzZVxuIik7Cj4+PiAtwqDC oMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfY2xrKTsKPj4+IC3CoMKgwqAgfQo+ Pj4gK8KgwqDCoCBuZmMtPnNkX2VtbWNfY2xvY2sgPSBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVz b3VyY2VfYnluYW1lKHBkZXYsIAo+Pj4gImVtbWMiKTsKPj4+ICvCoMKgwqAgaWYgKElTX0VSUihu ZmMtPnNkX2VtbWNfY2xvY2spKQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiBQVFJfRVJSKG5m Yy0+c2RfZW1tY19jbG9jayk7Cj4+Cj4+IFdoaWxlIEkgYWdyZWUgdGhpcyBpcyBtdWNoIGJldHRl ciB0aGFuIHRoZSBwcmV2aW91cyBzb2x1dGlvbiwgd2UgY2Fubm90Cj4+IGJyZWFrIERUIGNvbXBh dGliaWxpdHksIHNvIHlvdSBuZWVkIHRvIHRyeSBnZXR0aW5nIHRoZSBlbW1jIGNsb2NrLCBidXQK Pj4gaWYgaXQgZmFpbHMgeW91IHNob3VsZCBmYWxsYmFjayB0byB0aGUgcmVnbWFwIGxvb2t1cC4K PiAKPiBvaywgaSB3aWxsIGZpeCBpdCBuZXh0IHZlcnNpb24uIHRoYW5rcy4KPiAKPj4KPj4+IMKg wqDCoMKgwqAgaXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsgCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcg bGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC278C433F5 for ; Mon, 18 Apr 2022 03:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:CC:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ynqs87e71Rem5YMwaLxDkkD+L36r9s+mUUn4xJTEsP0=; b=2XjlzJZ/beOkOB Sg3nuwncb+rScVHoHsAth40S+hjbBm9OWOUdQU7HjDzHwK6ij+c8qKszRYwIPa0gi0dcw2Xx0c2e/ RY69hvbSmoE2ZGNtwFS1x4b8FihcDdhk0b7JGFlCUwFLTrbB3t5rJDfT41FBr5M/PTDUnYx9kskcI nYOw+LDkoYg1hOlxOohRTTb2/L9KOG7ZftL9I7FH3obOsJz56CqVsMjLM80ZmNrCj6EJIKTNJUrDy DlZsqcqkwsw9Iesq2eGLDmYyp3bzjKAgMpiecCqqxBYrvfGUhTBJ5UlWgV5n0T7qA5rMqfUVx57ra qZ1oolBHOlrkCJ8fVBhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngIFS-00FSpI-Gv; Mon, 18 Apr 2022 03:40:22 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngIFP-00FSnr-AL; Mon, 18 Apr 2022 03:40:20 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 18 Apr 2022 11:40:10 +0800 Message-ID: Date: Mon, 18 Apr 2022 11:40:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Content-Language: en-US From: Liang Yang To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> In-Reply-To: <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220417_204019_384654_135B7E4F X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWlxdWVsLAoKaSBoYXZlIHNvbWUgY29uZnVzaW9uIHdoZW4gaSBwcmVwYXJlIHRoZSBwYXRj aGVzLiBmb3IgRFQgY29tcGF0aWJpbGl0eSwgCml0IGZhbGxzIGJhY2sgdG8gdGhlIG9sZCBEVCB3 aGVuIGZhaWxlZCB0byBnZXQgcmVzb3VyY2UgYnkgdGhlIG5ldyBEVCwgCmJ1dCB0aGVyZSBpcyBz b21lIHBvaW50czoKYS4gb2xkIERUIGRlcGVuZHMgb24gTU1DIHN1YiBjbG9jayBkcml2ZXIsIGJ1 dCBpdCBuZXZlciBiZSBtZXJnZWQsIHNvIGl0IApjYW4ndCB3b3JrLgpiLiBpZiBpdCBmYWxscyBi YWNrIHRvIHRoZSBvbGQgRFQsIGJlc2lkZSB0aGUgcmVnbWFwIGxvb2t1cCBiZWxvdywgaXQgCnNl ZW1zIHRoYXQgd2UgaGF2ZSB0byBwcmVzZXJ2ZSB0aGUgY29kZSBvZiB0aGUgb2xkIGNsb2NrIHNl dHRpbmcgaW4gCm5mY19jbGtfaW5pdCgpLiBkbyB3ZSBzdGlsbCBuZWVkIHRvIGF2b2lkIGJyZWFr IERUIGNvbXBhdGliaWxpdHk/CgpUaGFua3MuCgpPbiAyMDIyLzQvMTEgMTA6NDAsIExpYW5nIFlh bmcgd3JvdGU6Cj4+PiDCoMKgwqDCoMKgIG5mYy0+ZGV2ID0gZGV2Owo+Pj4gLcKgwqDCoCByZXMg PSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UocGRldiwgSU9SRVNPVVJDRV9NRU0sIDApOwo+Pj4gLcKg wqDCoCBuZmMtPnJlZ19iYXNlID0gZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgcmVzKTsKPj4+ ICvCoMKgwqAgbmZjLT5yZWdfYmFzZSA9IGRldm1fcGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZV9i eW5hbWUocGRldiwgIm5mYyIpOwo+Pgo+PiBUaGlzIGNoYW5nZSBzZWVtcyB1bnJlbGF0ZWQuCj4g Cj4gVG8gYmUgY29uc2lzdGVudCB3aXRoIHRoZSBmb2xsb3dpbmcgCj4gZGV2bV9wbGF0Zm9ybV9p b3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCAiZW1tYyIpLiBkbyB5b3UgbWVhbiB0aGF0IHdl IAo+IGRvbid0IG5lZWQgaXQ/Pgo+Pj4gwqDCoMKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2Jh c2UpKQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBQVFJfRVJSKG5mYy0+cmVnX2Jhc2Up Owo+Pj4gLcKgwqDCoCBuZmMtPnJlZ19jbGsgPQo+Pj4gLcKgwqDCoMKgwqDCoMKgIHN5c2Nvbl9y ZWdtYXBfbG9va3VwX2J5X3BoYW5kbGUoZGV2LT5vZl9ub2RlLAo+Pj4gLcKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgImFtbG9naWMsbW1jLXN5c2NvbiIpOwo+ Pj4gLcKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2NsaykpIHsKPj4+IC3CoMKgwqDCoMKgwqDC oCBkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBsb29rdXAgY2xvY2sgYmFzZVxuIik7Cj4+PiAtwqDC oMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfY2xrKTsKPj4+IC3CoMKgwqAgfQo+ Pj4gK8KgwqDCoCBuZmMtPnNkX2VtbWNfY2xvY2sgPSBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVz b3VyY2VfYnluYW1lKHBkZXYsIAo+Pj4gImVtbWMiKTsKPj4+ICvCoMKgwqAgaWYgKElTX0VSUihu ZmMtPnNkX2VtbWNfY2xvY2spKQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiBQVFJfRVJSKG5m Yy0+c2RfZW1tY19jbG9jayk7Cj4+Cj4+IFdoaWxlIEkgYWdyZWUgdGhpcyBpcyBtdWNoIGJldHRl ciB0aGFuIHRoZSBwcmV2aW91cyBzb2x1dGlvbiwgd2UgY2Fubm90Cj4+IGJyZWFrIERUIGNvbXBh dGliaWxpdHksIHNvIHlvdSBuZWVkIHRvIHRyeSBnZXR0aW5nIHRoZSBlbW1jIGNsb2NrLCBidXQK Pj4gaWYgaXQgZmFpbHMgeW91IHNob3VsZCBmYWxsYmFjayB0byB0aGUgcmVnbWFwIGxvb2t1cC4K PiAKPiBvaywgaSB3aWxsIGZpeCBpdCBuZXh0IHZlcnNpb24uIHRoYW5rcy4KPiAKPj4KPj4+IMKg wqDCoMKgwqAgaXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsgCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF4C8C433EF for ; Mon, 18 Apr 2022 03:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:CC:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gr4lwQ5b0PkqkWlwoV7BRS+/w9VOti6fIKe5mcxNzfc=; b=n1T68743/yi+9Y 1ixrIQE00dF3yxXcYfTW3qt0F6qTtHIgDV1x2Smhe2BvgPjGg7AORpdYiB8PhdYENQLBYxPp4yyY9 mZAGpNylTqG8PS7oWHQsUrr4zpwRvH6yQfl+v9ykueiQt5BPnb7sc9RQgbvDtlczMFzonEiHkjf31 /2QYMGn+OUrSTlEq5padg6zh6Xj7nTsiHUh6giFdZopTgdq1DCGoM56L++sQ/OeRWKR9MRwV+/yct 6/P3mE4gnEKvl1ao26dHJ/53thFO3otIGsSio8QYKGE7MBUktdVyoSwBnEFTJnj7q2d5DHnAU3rCQ aV3vm/XTRdGirvnPO7sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngIFa-00FSqC-B4; Mon, 18 Apr 2022 03:40:30 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngIFP-00FSnr-AL; Mon, 18 Apr 2022 03:40:20 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 18 Apr 2022 11:40:10 +0800 Message-ID: Date: Mon, 18 Apr 2022 11:40:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Content-Language: en-US From: Liang Yang To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> In-Reply-To: <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220417_204019_384654_135B7E4F X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWlxdWVsLAoKaSBoYXZlIHNvbWUgY29uZnVzaW9uIHdoZW4gaSBwcmVwYXJlIHRoZSBwYXRj aGVzLiBmb3IgRFQgY29tcGF0aWJpbGl0eSwgCml0IGZhbGxzIGJhY2sgdG8gdGhlIG9sZCBEVCB3 aGVuIGZhaWxlZCB0byBnZXQgcmVzb3VyY2UgYnkgdGhlIG5ldyBEVCwgCmJ1dCB0aGVyZSBpcyBz b21lIHBvaW50czoKYS4gb2xkIERUIGRlcGVuZHMgb24gTU1DIHN1YiBjbG9jayBkcml2ZXIsIGJ1 dCBpdCBuZXZlciBiZSBtZXJnZWQsIHNvIGl0IApjYW4ndCB3b3JrLgpiLiBpZiBpdCBmYWxscyBi YWNrIHRvIHRoZSBvbGQgRFQsIGJlc2lkZSB0aGUgcmVnbWFwIGxvb2t1cCBiZWxvdywgaXQgCnNl ZW1zIHRoYXQgd2UgaGF2ZSB0byBwcmVzZXJ2ZSB0aGUgY29kZSBvZiB0aGUgb2xkIGNsb2NrIHNl dHRpbmcgaW4gCm5mY19jbGtfaW5pdCgpLiBkbyB3ZSBzdGlsbCBuZWVkIHRvIGF2b2lkIGJyZWFr IERUIGNvbXBhdGliaWxpdHk/CgpUaGFua3MuCgpPbiAyMDIyLzQvMTEgMTA6NDAsIExpYW5nIFlh bmcgd3JvdGU6Cj4+PiDCoMKgwqDCoMKgIG5mYy0+ZGV2ID0gZGV2Owo+Pj4gLcKgwqDCoCByZXMg PSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UocGRldiwgSU9SRVNPVVJDRV9NRU0sIDApOwo+Pj4gLcKg wqDCoCBuZmMtPnJlZ19iYXNlID0gZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgcmVzKTsKPj4+ ICvCoMKgwqAgbmZjLT5yZWdfYmFzZSA9IGRldm1fcGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZV9i eW5hbWUocGRldiwgIm5mYyIpOwo+Pgo+PiBUaGlzIGNoYW5nZSBzZWVtcyB1bnJlbGF0ZWQuCj4g Cj4gVG8gYmUgY29uc2lzdGVudCB3aXRoIHRoZSBmb2xsb3dpbmcgCj4gZGV2bV9wbGF0Zm9ybV9p b3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCAiZW1tYyIpLiBkbyB5b3UgbWVhbiB0aGF0IHdl IAo+IGRvbid0IG5lZWQgaXQ/Pgo+Pj4gwqDCoMKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2Jh c2UpKQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBQVFJfRVJSKG5mYy0+cmVnX2Jhc2Up Owo+Pj4gLcKgwqDCoCBuZmMtPnJlZ19jbGsgPQo+Pj4gLcKgwqDCoMKgwqDCoMKgIHN5c2Nvbl9y ZWdtYXBfbG9va3VwX2J5X3BoYW5kbGUoZGV2LT5vZl9ub2RlLAo+Pj4gLcKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgImFtbG9naWMsbW1jLXN5c2NvbiIpOwo+ Pj4gLcKgwqDCoCBpZiAoSVNfRVJSKG5mYy0+cmVnX2NsaykpIHsKPj4+IC3CoMKgwqDCoMKgwqDC oCBkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBsb29rdXAgY2xvY2sgYmFzZVxuIik7Cj4+PiAtwqDC oMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfY2xrKTsKPj4+IC3CoMKgwqAgfQo+ Pj4gK8KgwqDCoCBuZmMtPnNkX2VtbWNfY2xvY2sgPSBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVz b3VyY2VfYnluYW1lKHBkZXYsIAo+Pj4gImVtbWMiKTsKPj4+ICvCoMKgwqAgaWYgKElTX0VSUihu ZmMtPnNkX2VtbWNfY2xvY2spKQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiBQVFJfRVJSKG5m Yy0+c2RfZW1tY19jbG9jayk7Cj4+Cj4+IFdoaWxlIEkgYWdyZWUgdGhpcyBpcyBtdWNoIGJldHRl ciB0aGFuIHRoZSBwcmV2aW91cyBzb2x1dGlvbiwgd2UgY2Fubm90Cj4+IGJyZWFrIERUIGNvbXBh dGliaWxpdHksIHNvIHlvdSBuZWVkIHRvIHRyeSBnZXR0aW5nIHRoZSBlbW1jIGNsb2NrLCBidXQK Pj4gaWYgaXQgZmFpbHMgeW91IHNob3VsZCBmYWxsYmFjayB0byB0aGUgcmVnbWFwIGxvb2t1cC4K PiAKPiBvaywgaSB3aWxsIGZpeCBpdCBuZXh0IHZlcnNpb24uIHRoYW5rcy4KPiAKPj4KPj4+IMKg wqDCoMKgwqAgaXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsgCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1 c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtbXRkLwo=