From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses To: Minchan Kim , Johannes Thumshirn References: <20170306102335.9180-1-jthumshirn@suse.de> <20170307052242.GA29458@bbox> <95c31a93-32cd-ad06-6cc0-e11b42ec2f68@suse.de> <20170307085545.GA538@bbox> <10a2335c-0ed0-43de-1cbd-625845301aef@suse.de> <20170308051118.GA11206@bbox> <1073055f-e71b-bb07-389a-53b60ccdee20@suse.de> <20170309052829.GA854@bbox> Cc: Hannes Reinecke , Nitin Gupta , Christoph Hellwig , Sergey Senozhatsky , yizhan@redhat.com, Linux Block Layer Mailinglist , Linux Kernel Mailinglist , Andrew Morton From: Jens Axboe Message-ID: Date: Thu, 30 Mar 2017 09:35:56 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 List-ID: On 03/30/2017 09:08 AM, Minchan Kim wrote: > Hi Jens, > > It seems you miss this. > Could you handle this? I can, but I'm a little confused. The comment talks about replacing the one I merged with this one, I can't do that. I'm assuming you are talking about this commit: commit 0bc315381fe9ed9fb91db8b0e82171b645ac008f Author: Johannes Thumshirn Date: Mon Mar 6 11:23:35 2017 +0100 zram: set physical queue limits to avoid array out of bounds accesses which is in mainline. The patch still applies, though. Do we really REALLY need this for 4.11, or can we queue for 4.12 and mark it stable? -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934625AbdC3Ph0 (ORCPT ); Thu, 30 Mar 2017 11:37:26 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:40640 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933852AbdC3Pgo (ORCPT ); Thu, 30 Mar 2017 11:36:44 -0400 Authentication-Results: linux-foundation.org; dkim=none (message not signed) header.d=none;linux-foundation.org; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses To: Minchan Kim , Johannes Thumshirn References: <20170306102335.9180-1-jthumshirn@suse.de> <20170307052242.GA29458@bbox> <95c31a93-32cd-ad06-6cc0-e11b42ec2f68@suse.de> <20170307085545.GA538@bbox> <10a2335c-0ed0-43de-1cbd-625845301aef@suse.de> <20170308051118.GA11206@bbox> <1073055f-e71b-bb07-389a-53b60ccdee20@suse.de> <20170309052829.GA854@bbox> CC: Hannes Reinecke , Nitin Gupta , "Christoph Hellwig" , Sergey Senozhatsky , , Linux Block Layer Mailinglist , Linux Kernel Mailinglist , Andrew Morton From: Jens Axboe Message-ID: Date: Thu, 30 Mar 2017 09:35:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BN6PR10CA0016.namprd10.prod.outlook.com (10.172.16.154) To DM5PR15MB1195.namprd15.prod.outlook.com (10.173.209.13) X-MS-Office365-Filtering-Correlation-Id: 84e912eb-58a6-4ab5-ca62-08d47782784c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DM5PR15MB1195; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;3:sgPM8aPxtpZmpS4nWu4vU4UFbhOZANqUbOwY5J35+SE8F7DZxftq8bf7HUxdI6jdRQ2LKFsccNgoTRYHX7IUlSDxlyghbTjjYiYURPYypn0Qv4mno4hPRNVSSdn8Tp1O7wYrY67dx3qeIhwMARxAKMhHhH+k/puoWLAjAP+0cGeha84LMsrKzMAdZhgtr/R3cDQFh0cEJafzMKj46AiIS5qUMmqgy/MPcAzk1vsSnKMi5ySnaqeBNtyN+hcYsoYXMUVTLiwMiLorsUzRQxdVtuMSrU1Ao9aRNEKU0uvwqbRPYUtBCYjSIoQlwvltjxgWLE9hYKBOlT8k3cHeqLuKNA==;25:vuTI0jGXE6TyBMOGTPVmG7QWeHz+0AbDwteveXgBEgsgPe6x9Lg6eK4ki2o3NqHQSykOfgSfsHAJdnCPmZiN3UQdwObPB0YL04Aac/Er//Wbwfaw9tGOIIpo8SpbRu8ZhJOJS10SMpln1uIVaS6gVBlOGgEwo9YAUlQuc/DKGfAMznzfTrwhsPoiIgO+c+2VEDc/HO9sDlDR+ZJTFxR2ex7ust0qpddm0zs0n8aS4AiwUZ8jfLh+XqjlzN8XZ6m0lHbfahsgRIOi99Qyq6A2IOZwQXKj0HeqAic6bdQClatTBn8sGNCilkBBms7g7Vo9xO16HAN+I00m4bk3HSZ6bUWzk73zh0L75rwRpKQuZ6bXfS9KsKTQu+keOeZgPVNocmhAobvDWFOy0hjPyKzOVs1u+VrllxJOUdXQosEnUdFMgT+JmLR5fFnNAaF6QtUdNgdaeo+zcUrOyNA7fFrmBw== X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;31://RGGZ77sgFZzcgtaG/u62x8hONgFSzjYafpqekHEpS1QkVSXyAdmKQgj2ePCwldNfngJmj7FhVKgfB2YQrTtvwi1/sxDTxb6FmTC5A3UkoemAkn7ez5OcBRg6mkM/1/pjq7N27LdvzWvyDXZVB2LTLj9ZRiVe+zDt7b329dWDBK2N2XE5YfTDGGD3mipR0lzTDMFWX+XaFO+S8/hGhoGpcbuFoT/3C387/s5XInXGv9lIfMERM6MS/x8GwjMtnp6+Z8POoa3VnRZhz6iloQO9WUOItP2c2zpxJqQ35KZZo=;20:oiWz63GwDpRx28bjnwKiEcHDu86I0SNhpzGJTa5UDxN1g/AknYN/M4V6qLT+taglEiDl4Buc4zFxq1yMXBe6yx/7vPU92L60I5G5jKKqzEQWm+5l9u2W2qrjsXaGf2mK16rAHMl+CJhLWj64hLa2dzUKPRRp9ks/eQNFKVZMT1woBc7c1ycRRPm/umUzYM2V91gcSFmPftMLUI9lFezZ54rEqDVyd6dGTjhj1ggpYTHgryuPehyxkqe6l1xunyI+hzqNDiajDSf4BTWEwIr3qp14VKU8kDZ821a37VQ4gyZzAeV7RvbfizSViCKRQzCZLozSqLdIe0emNHW3NzKlgyt/KYcVd+ekq4Tsdg688k5WU7ue36B6+Yvb27b1g9sarYwswcKywXoNjBXFfb2OFe9j3cOkXaBe7Ij8V3TAIpTcLVFyF7NST2iio9Fwfb14xijc+BfEOC8y3qEuxFocETu6Fdj+WAYVh0Slhec2syxhKL+gZXVoCUn1bjPMAeWj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006067)(93001067)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123564025)(6072148);SRVR:DM5PR15MB1195;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1195; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;4:iJ3k/K7VjSzHX0zEcDxbg7IAPTZQigGtiXCjF3UW8bRM5FrV5G+8sACSkaazAkCAy+fVZyPtvbk8SR40aLcIdZqReFOSs9kOXi7ck0XJ5m2Ed6ZofikPITaWwFQBv3OCfr+XknQIqAbcB+onyRM+nBpnLSzOuuCRm0eqRquJa7aPmkMWNNvu+BZGc9v2tgAkeaz45kjl4d3afCM2EjeWDbCZkAkkl7qmOJHcaUxQRcsJT2mfgrFsC7BvsI4SjCtYc3wei2an8D53WXArqH/2vXKTYMw00gEiA+YmJ2envBMWRiuc88ALdzwrCZT2wybVzkiFEvIFSaJFjFQgY6J6FA5arRKNa2FIYFB2mQX4uidxZU6RzTahzvgInNYfyyYBT5ZM3SxKypL0aU4Hcrz/Uu2kQbAG4fqTadlYJ3Gs30w043/CoiUmna8z1+tRqY95zC6kDWx737GjVIighrfuZUssNQE4RdaKooIQiMEiLpP/IYsLlWaC73O3vMVVxchl3hb5oH/lyq6+XxadjkWfQQ3A+cypMz5Vd1WW+WUYTdBe20uCG1fM6wga6EkSLyk1dpKn+n5hlDOxZAhL4I8q6nPCUQM0BkC7wXavg6v4KA2BhW44fpakcp0nsa5kOep9NwIyDk4Knb0rnaS7yO9OY55Lo8/HyCfLEQFjLJhpkFu+7MWFzLqusPxg3/gpGHuUFGuzPI0woJPcMSwd8pa32Q== X-Forefront-PRVS: 02622CEF0A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39450400003)(39410400002)(39400400002)(39850400002)(39840400002)(377454003)(24454002)(229853002)(6666003)(3846002)(65956001)(65806001)(66066001)(6116002)(2950100002)(81166006)(230700001)(53936002)(25786009)(47776003)(305945005)(53546009)(8676002)(2906002)(83506001)(189998001)(86362001)(4001350100001)(4326008)(54906002)(31696002)(117156002)(575784001)(7416002)(23746002)(5660300001)(77096006)(6486002)(42186005)(31686004)(7736002)(50466002)(93886004)(38730400002)(64126003)(50986999)(33646002)(6246003)(54356999)(90366009)(36756003)(76176999);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1195;H:[192.168.1.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR15MB1195;23:aDlWIv1yCgQDWRKmjJeE+yk2YaLkLm+Zq3i4H?= =?Windows-1252?Q?00tuXU01zc/7V32cKURgP/f7sw0jDswLNE12KKoAnTwZyxHXNRfLnY++?= =?Windows-1252?Q?gvfx/JThUrAMP7vTRcg/h24PRssvugtUxBLQr+MTlwDfyZc/2sT+tmcf?= =?Windows-1252?Q?TAmERZRc0p1FACqodgwIbuDny53wTERhtKg5jfamzgoj1eNiQMNJvd3r?= =?Windows-1252?Q?M6trMbuZ2MNqLLSV3WrTLikOOVZf+10XC5tz5NBhGnjYWpAU0Jl0qGVE?= =?Windows-1252?Q?i4aUuDBltmtnkwiOUsM5H+0y0xQyAEgBXCDTu7x2DjCZdCkVOhuvpA63?= =?Windows-1252?Q?ILfz5TY/m9jhi/v1EPC5JXO8ojnCYEIroqcMqTZXJ3togmODWkwepK4t?= =?Windows-1252?Q?h5vGIOlsM6JVkcHPKod0G1TCFOvB7EpL2+KoyjoaQLmDTpjCGgn+QHx6?= =?Windows-1252?Q?Kozhfn0s5Z4kqy5DXJWBbJ5qtJrIPXhQMFmZUq3jgxq9hAt8bSbdmDvj?= =?Windows-1252?Q?77jV057GnA8xn8QJALrDE6MDJSFQjftOpFKiWbZeCQ0iTNwU98XzB5Oj?= =?Windows-1252?Q?8IZpffyeonFmS8j7+fvP6Si7uifwLGzP6NDVQNTL/domhET75xQIbGgg?= =?Windows-1252?Q?A0Hr1K9aXMQ4S4qhYnQY63VIIJoh91ybtQXp76LAICq5JbHfOibSj81r?= =?Windows-1252?Q?2ERutSKKDua8JjaLzd9CwS+dtMVoHTvbft/qu5bIOQ9DXV4xdwOXYcOY?= =?Windows-1252?Q?F4kE9FWmmHE5eWoBRF+n+he7HqOo3ORa1bl21fEn5uRcfdchlUqUQaFR?= =?Windows-1252?Q?rTWBGd1cvXhFxBPBOh0n61Y/EWwmL0dteeoEM8YYnWh26Qp9B76luARO?= =?Windows-1252?Q?bOMRcAVu5dct8hIfnwY6LBBefZiOHXf63mFNbymGuzJ0/0/wgPJCVEtC?= =?Windows-1252?Q?tOeVDUKyUK0hL0aJj9x6Ebz2CldWHUho75PmfrOGLIfpMCXLRk8w7GaZ?= =?Windows-1252?Q?kjrzeZXsvoMmfMyK+ciACUr5zPAKV13ugFrMbdjarOK+aJg3tY1GRa4a?= =?Windows-1252?Q?1dP2jGxLCx5Jg3ea0KH7JVyEezpmAQmIgTcNqSaXolIrLryuH0MRXS5n?= =?Windows-1252?Q?9k1P/2couzVO6T7Wpqm5B4FpBxiQDYRNPM+iNb4smFO3kztIq7qQky7e?= =?Windows-1252?Q?RsfdGy00CLJVRwZc6l6nlIz1y6RzuIKY+tHmL66H+KcIKu7Cj8WvF/pP?= =?Windows-1252?Q?HQBc/n7l5u2wfI4b9nmFzv9bm/WCPUheuC9x7gGMHf2lya0GQs93yJTk?= =?Windows-1252?Q?Q+yRXL8QVvNuSw0AeiDM0Soel6mc+zkXrhO2xvoiSYYCRXTkeYXvcKor?= =?Windows-1252?Q?iSCwYk28A17+KzsqkTGr790+41njfpZh2ZVhaPA2cXelK0lcdYLBB7Zk?= =?Windows-1252?Q?SIMD0QOyf4VXhHw+SviznzOLg/wao99xFTvQ/CPnQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;6:xJgjvkHruXMip7XGs29Trcgy9kqSvNg214oyHaP5+Ub3Iyy4Q+SdI/EybMKzSjPo7RX38qz1YjNFZb3o85lDNBQ80mhVuGkc8/7bLoOsQ4BLD0DI3acaTi4ZJ3baONoYNQYY4dCDW/Ck1BtWGN3d4mZ0528rkwgJMcb2fviWSTkWKDdSiAUv8ywCr/F314+RHROnXj4Z+i/dFQDpAg3MfEIqsFdHazFMwFCA7pGF4yicJm3GtRVMbYZRgR3aVGOTFZYDzuGIXGXcjmSKrn8rfksJ/1lzjqjVyQk04woG0TDu5+nVZAslvEeMv8LtCdYOnBJ748c8kJcFd1lBY1jpiodcpyJfOpiDb8y95LzAQXYBol1pBFru8NPeSOg2lkmFIs/e9ey170BKem9M2rbk7A==;5:WbRQPOqQZmMKPaCKCFQrD1JAdAC1q84mvlkRq3s93ZLy0+RLHeDp/1eXTSXa9bgvbcUhx3vU7VkthA0kZ++Hsnct9ZBDpI4Cib+3LDU078SfhAhHfY13yBTqEyiJ8DfIo+p7aOPfGlxNpymmolN7Gw==;24:OvEDtft404jKmJMq1Eko354FlzyLPpCtZwt3wOjaQxi+BG8l1xOYRj7bnygyQ/KHV796kpFfcE7JxLNisBLtBQp0dcW34yiXgKa7ibIJews= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;7:Gs3kkvQAppI+K+Llc/d0sTKg/cuV5Vejpwx8bKM20fVOsmMtfdVAuGLCqaz+pCyK+LKV6eI97XIz9v1CS1QSA8f2ZEU48KfmmAATmZESbPPhpYBald/p4IfR6NkxFV41W0JKNB28/9PXNyXeeQ758gfHzOfhkMaQ1ty8Y5KlNZh9J88fz4ye8YlldRokHd7XPy/UvcPTg4h/Pl1fNQM7Vi9xrwLYnw9KTlz2jvasovPeROCEIJZ65oO7qWhVY1k4qHvS0j3MXIH9yrPqykQilmbYjFB1mYPcLu1Hl+R1kMRf7Yj9yzrRf5iGYyr42hpTi7DM7VfrRg+qcrFKjewHiQ==;20:8/CvzMWPMqru/J0xSEFHpHyHuOn0Sp27K6GKr8DwhFBgh6wU/dHXcTRDVanPGHBtyrGdvxsdc9G8GEhWpPCluueajc9XENFNZg3mMGJ/q++TBDuq7FjM/3z+YkiwJa02L7svhQCYk8xg5m97qp6hwsIFdb2+5GUG/nrn485WSEo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2017 15:36:00.1594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1195 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-30_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/30/2017 09:08 AM, Minchan Kim wrote: > Hi Jens, > > It seems you miss this. > Could you handle this? I can, but I'm a little confused. The comment talks about replacing the one I merged with this one, I can't do that. I'm assuming you are talking about this commit: commit 0bc315381fe9ed9fb91db8b0e82171b645ac008f Author: Johannes Thumshirn Date: Mon Mar 6 11:23:35 2017 +0100 zram: set physical queue limits to avoid array out of bounds accesses which is in mainline. The patch still applies, though. Do we really REALLY need this for 4.11, or can we queue for 4.12 and mark it stable? -- Jens Axboe