[PATCH] Use the built-in options for removing pack tools

[PATCH] Use the built-in options for removing pack tools

[ed]

From: Ed Tanous <ed@tanous.net>

For distros that want to use the ENABLE_LIB_ONLY option, the rm call
will fail, because ENABLE_HPACK_TOOLS (set implicitly as part of
ENABLE_LIB_ONLY) removes those two binaries from the build, so they then
can't be removed again.  This commit sets ENABLE_HPACK_TOOLS=OFF, which not
only allows for the option to be overridden in other meta layers, also
allows a simplified use of ENABLE_LIB_ONLY in meta layers that don't
want to ship the binaries.

Signed-off-by: Ed Tanous <ed@tanous.net>
---
 meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb b/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb
index 959cccf35..08b855262 100644
--- a/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb
+++ b/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb
@@ -18,11 +18,7 @@ PACKAGECONFIG[manpages] = ""
 
 # examples are never installed, and don't need to be built in the
 # first place
-EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=ON"
-
-do_install_append() {
-	rm ${D}${bindir}/deflatehd ${D}${bindir}/inflatehd
-}
+EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=ON -DENABLE_HPACK_TOOLS=OFF"
 
 PACKAGES =+ "lib${PN} ${PN}-client ${PN}-proxy ${PN}-server"
 
-- 
2.32.0.272.g935e593368-goog

Re: [OE-core] [PATCH] Use the built-in options for removing pack tools

[Khem Raj]

On 6/16/21 11:19 AM, ed@tanous.net wrote:
> From: Ed Tanous <ed@tanous.net>
> 
> For distros that want to use the ENABLE_LIB_ONLY option, the rm call
> will fail, because ENABLE_HPACK_TOOLS (set implicitly as part of
> ENABLE_LIB_ONLY) removes those two binaries from the build, so they then
> can't be removed again.  This commit sets ENABLE_HPACK_TOOLS=OFF, which not
> only allows for the option to be overridden in other meta layers, also
> allows a simplified use of ENABLE_LIB_ONLY in meta layers that don't
> want to ship the binaries.
> 
> Signed-off-by: Ed Tanous <ed@tanous.net>
> ---
>   meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)

Thanks for this patch, this is wrong list for meta-openembedded patches, 
please send meta-openembedded patches to 
openembedded-devel@lists.openembedded.org ml

> 
> diff --git a/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb b/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb
> index 959cccf35..08b855262 100644
> --- a/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb
> +++ b/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb
> @@ -18,11 +18,7 @@ PACKAGECONFIG[manpages] = ""
>   
>   # examples are never installed, and don't need to be built in the
>   # first place
> -EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=ON"
> -
> -do_install_append() {
> -	rm ${D}${bindir}/deflatehd ${D}${bindir}/inflatehd
> -}
> +EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=ON -DENABLE_HPACK_TOOLS=OFF"
>   
>   PACKAGES =+ "lib${PN} ${PN}-client ${PN}-proxy ${PN}-server"
>   
> 
> 
> 
> 
>