From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_ADSP_DISCARD, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE52BC11F68 for ; Fri, 2 Jul 2021 07:56:18 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 97F57613E7 for ; Fri, 2 Jul 2021 07:56:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97F57613E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=oktetlabs.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83A2940141; Fri, 2 Jul 2021 09:56:16 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 8A4F74003E for ; Fri, 2 Jul 2021 09:56:15 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 154A07F502; Fri, 2 Jul 2021 10:56:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 154A07F502 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625212575; bh=K7wJZne6eMvNdDwL8vGMLD1w9SDljmrD4WvvukUpwhg=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=CuhXjsLKH6g62NGwmevBLYEzPgbD/IAVKfgRkrZQFnjplWegwD9OzVJMRoMrWar9K qWJeLJ4FoVHIKLRCRp4zkJunpjjx9eWIJwTbXp8Hh7lkKgzvzGRxE6FdL8XyZueZH2 31fZG9HW+jF6iWhZ2GBGqaD7cVGDW/ZT7R3F9GgA= To: "Wiles, Keith" , Stephen Hemminger Cc: "dev@dpdk.org" References: <20210616041528.4229-1-stephen@networkplumber.org> <20210616041528.4229-2-stephen@networkplumber.org> <9f02b218-62e4-f40e-f8ce-c77395164a89@oktetlabs.ru> <20210701101812.5a380b36@hermes.local> <95B1B538-E0EC-4C7A-B7C2-C4512CBA6446@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Fri, 2 Jul 2021 10:56:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <95B1B538-E0EC-4C7A-B7C2-C4512CBA6446@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/1/21 10:19 PM, Wiles, Keith wrote: > > >> On Jul 1, 2021, at 12:18 PM, Stephen Hemminger wrote: >> >> On Thu, 1 Jul 2021 17:16:21 +0300 >> Andrew Rybchenko wrote: >> >>> On 6/16/21 7:15 AM, Stephen Hemminger wrote: >>>> Since these always return 0, they were doing nothing useful. >>>> >>>> Signed-off-by: Stephen Hemminger >>> >>> I have no strong opinion on the patch, but sometimes even >>> empty functions with comments add value. So, I see no point >>> to touch it. So, I'll wait for maintainer reply. >> >> There are always many ways to write more obscure and technically correct >> code. It is best if the code is the smallest correct way. >> >> “I apologize for such a long letter - I didn't have time to write a short one.” >> ― Mark Twain > > I agree with Stephen, the extra functions provide no useful feature or even the comments are not very useful IMO. > It is a bit different here. You're changing the code in an absolutely equivalent way. IMHO complexity of the code before and after the patch is absolutely the same. Anyway, it does not matter a lot. If it think it would be better in a new way - no problem. @Keith, could you ack the patch series and I'll happily apply it.