From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758427AbcHYPum (ORCPT ); Thu, 25 Aug 2016 11:50:42 -0400 Received: from www381.your-server.de ([78.46.137.84]:44909 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757548AbcHYPuk (ORCPT ); Thu, 25 Aug 2016 11:50:40 -0400 Subject: Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit To: =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Zach Brown References: <1472080984-17373-1-git-send-email-zach.brown@ni.com> <20160825151047.GO16583@xsjsorenbubuntu> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org From: Lars-Peter Clausen Message-ID: Date: Thu, 25 Aug 2016 17:23:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160825151047.GO16583@xsjsorenbubuntu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Authenticated-Sender: lars@metafoo.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/25/2016 05:10 PM, Sören Brinkmann wrote: > On Wed, 2016-08-24 at 18:23:03 -0500, Zach Brown wrote: >> The sdhci controller on xilinx zynq devices will not function unless >> the cd bit is provided. http://www.xilinx.com/support/answers/61064.html >> In cases where it is impossible to provide the cd bit in hardware, >> setting the controller to test mode and then setting inserted to true >> will get the controller to function with out the cd bit. >> >> The device property "fake-cd" will let the arasan driver know it needs >> to fake the cd bit for the controller inorder for the controller to >> function with a SD card that does not provide the CD bit. > > I thought the CD is, if not pinned out, tied off to some valid logic > level. Isn't it enough to specify cd-inverted if needed to make it work > in those cases? It is always brought out to some pin, that is the problem on the Zynq. This means you'd have to set at least one pin aside as dummy CD or WP pin. Which is not always possible when you are tight on available pins. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit Date: Thu, 25 Aug 2016 17:23:47 +0200 Message-ID: References: <1472080984-17373-1-git-send-email-zach.brown@ni.com> <20160825151047.GO16583@xsjsorenbubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160825151047.GO16583@xsjsorenbubuntu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Zach Brown Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gMDgvMjUvMjAxNiAwNToxMCBQTSwgU8O2cmVuIEJyaW5rbWFubiB3cm90ZToKPiBPbiBXZWQs IDIwMTYtMDgtMjQgYXQgMTg6MjM6MDMgLTA1MDAsIFphY2ggQnJvd24gd3JvdGU6Cj4+IFRoZSBz ZGhjaSBjb250cm9sbGVyIG9uIHhpbGlueCB6eW5xIGRldmljZXMgd2lsbCBub3QgZnVuY3Rpb24g dW5sZXNzCj4+IHRoZSBjZCBiaXQgaXMgcHJvdmlkZWQuIGh0dHA6Ly93d3cueGlsaW54LmNvbS9z dXBwb3J0L2Fuc3dlcnMvNjEwNjQuaHRtbAo+PiBJbiBjYXNlcyB3aGVyZSBpdCBpcyBpbXBvc3Np YmxlIHRvIHByb3ZpZGUgdGhlIGNkIGJpdCBpbiBoYXJkd2FyZSwKPj4gc2V0dGluZyB0aGUgY29u dHJvbGxlciB0byB0ZXN0IG1vZGUgYW5kIHRoZW4gc2V0dGluZyBpbnNlcnRlZCB0byB0cnVlCj4+ IHdpbGwgZ2V0IHRoZSBjb250cm9sbGVyIHRvIGZ1bmN0aW9uIHdpdGggb3V0IHRoZSBjZCBiaXQu Cj4+Cj4+IFRoZSBkZXZpY2UgcHJvcGVydHkgImZha2UtY2QiIHdpbGwgbGV0IHRoZSBhcmFzYW4g ZHJpdmVyIGtub3cgaXQgbmVlZHMKPj4gdG8gZmFrZSB0aGUgY2QgYml0IGZvciB0aGUgY29udHJv bGxlciBpbm9yZGVyIGZvciB0aGUgY29udHJvbGxlciB0bwo+PiBmdW5jdGlvbiB3aXRoIGEgU0Qg Y2FyZCB0aGF0IGRvZXMgbm90IHByb3ZpZGUgdGhlIENEIGJpdC4KPiAKPiBJIHRob3VnaHQgdGhl IENEIGlzLCBpZiBub3QgcGlubmVkIG91dCwgdGllZCBvZmYgdG8gc29tZSB2YWxpZCBsb2dpYwo+ IGxldmVsLiBJc24ndCBpdCBlbm91Z2ggdG8gc3BlY2lmeSBjZC1pbnZlcnRlZCBpZiBuZWVkZWQg dG8gbWFrZSBpdCB3b3JrCj4gaW4gdGhvc2UgY2FzZXM/CgpJdCBpcyBhbHdheXMgYnJvdWdodCBv dXQgdG8gc29tZSBwaW4sIHRoYXQgaXMgdGhlIHByb2JsZW0gb24gdGhlIFp5bnEuIFRoaXMKbWVh bnMgeW91J2QgaGF2ZSB0byBzZXQgYXQgbGVhc3Qgb25lIHBpbiBhc2lkZSBhcyBkdW1teSBDRCBv ciBXUCBwaW4uIFdoaWNoCmlzIG5vdCBhbHdheXMgcG9zc2libGUgd2hlbiB5b3UgYXJlIHRpZ2h0 IG9uIGF2YWlsYWJsZSBwaW5zLgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Thu, 25 Aug 2016 17:23:47 +0200 Subject: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit In-Reply-To: <20160825151047.GO16583@xsjsorenbubuntu> References: <1472080984-17373-1-git-send-email-zach.brown@ni.com> <20160825151047.GO16583@xsjsorenbubuntu> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/25/2016 05:10 PM, S?ren Brinkmann wrote: > On Wed, 2016-08-24 at 18:23:03 -0500, Zach Brown wrote: >> The sdhci controller on xilinx zynq devices will not function unless >> the cd bit is provided. http://www.xilinx.com/support/answers/61064.html >> In cases where it is impossible to provide the cd bit in hardware, >> setting the controller to test mode and then setting inserted to true >> will get the controller to function with out the cd bit. >> >> The device property "fake-cd" will let the arasan driver know it needs >> to fake the cd bit for the controller inorder for the controller to >> function with a SD card that does not provide the CD bit. > > I thought the CD is, if not pinned out, tied off to some valid logic > level. Isn't it enough to specify cd-inverted if needed to make it work > in those cases? It is always brought out to some pin, that is the problem on the Zynq. This means you'd have to set at least one pin aside as dummy CD or WP pin. Which is not always possible when you are tight on available pins.