From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bafdF-0002j2-9t for qemu-devel@nongnu.org; Fri, 19 Aug 2016 04:58:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bafdC-00051r-69 for qemu-devel@nongnu.org; Fri, 19 Aug 2016 04:58:29 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bafdB-00050p-Ui for qemu-devel@nongnu.org; Fri, 19 Aug 2016 04:58:26 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7J8s0gx023496 for ; Fri, 19 Aug 2016 04:58:23 -0400 Received: from e06smtp09.uk.ibm.com (e06smtp09.uk.ibm.com [195.75.94.105]) by mx0a-001b2d01.pphosted.com with ESMTP id 24wweb3gsa-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 19 Aug 2016 04:58:23 -0400 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Aug 2016 09:58:21 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 801BD17D8056 for ; Fri, 19 Aug 2016 10:00:01 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7J8wHtx5112276 for ; Fri, 19 Aug 2016 08:58:17 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u7J8wHAe014525 for ; Fri, 19 Aug 2016 04:58:17 -0400 References: <1471551152-26107-1-git-send-email-silbe@linux.vnet.ibm.com> <1471551152-26107-2-git-send-email-silbe@linux.vnet.ibm.com> From: Janosch Frank Date: Fri, 19 Aug 2016 10:58:14 +0200 MIME-Version: 1.0 In-Reply-To: <1471551152-26107-2-git-send-email-silbe@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [PATCH 1/3] docker.py: don't hang on large docker output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sascha Silbe Cc: qemu-devel@nongnu.org, Fam Zheng On 08/18/2016 10:12 PM, Sascha Silbe wrote: > Unlike Popen.communicate(), subprocess.call() doesn't read from the > stdout file descriptor. If the child process produces more output than > fits into the pipe buffer, it will block indefinitely. > > If we don't intend to consume the output, just send it straight to > /dev/null to avoid this issue. > > Signed-off-by: Sascha Silbe Reviewed-by: Janosch Frank