From: Dario Faggioli <dfaggioli@suse.com>
To: Juergen Gross <jgross@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "julien@xen.org" <julien@xen.org>,
Jan Beulich <jbeulich@suse.com>,
"bertrand.marquis@arm.com" <bertrand.marquis@arm.com>,
"wl@xen.org" <wl@xen.org>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"george.dunlap@citrix.com" <george.dunlap@citrix.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] xen/notifier: simplify using notifier_[to|from]_errno()
Date: Fri, 4 Nov 2022 07:50:41 +0000 [thread overview]
Message-ID: <d5e54846ab18512d8baa0d7baa4ec77fb2cf26bd.camel@suse.com> (raw)
In-Reply-To: <20221028114111.8150-1-jgross@suse.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Fri, 2022-10-28 at 13:41 +0200, Juergen Gross wrote:
> Today all users of notifier_from_errno() and notifier_to_errno() are
> Handling the success case the same way, by using
>
> !rc ? NOTIFY_DONE : notifier_from_errno(rc)
>
> or
>
> (notifier_rc == NOTIFY_DONE) ? 0 : notifier_to_errno(notifier_rc);
>
> Simplify the use cases by moving the handling of the success case
> into
> the functions.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> ...
> xen/common/sched/core.c | 2 +-
> xen/common/sched/cpupool.c | 2 +-
>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-04 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 11:41 [PATCH] xen/notifier: simplify using notifier_[to|from]_errno() Juergen Gross
2022-11-04 7:50 ` Dario Faggioli [this message]
2022-11-10 15:37 ` Jan Beulich
2022-11-15 22:56 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5e54846ab18512d8baa0d7baa4ec77fb2cf26bd.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.