From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D4DEC54EAA for ; Fri, 27 Jan 2023 15:37:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233710AbjA0Phg (ORCPT ); Fri, 27 Jan 2023 10:37:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231991AbjA0Phf (ORCPT ); Fri, 27 Jan 2023 10:37:35 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 299E280009; Fri, 27 Jan 2023 07:37:35 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9F5341F381; Fri, 27 Jan 2023 15:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674833853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5cRXg2B8iBaH+A8rz4+PgHRwmqFEqyY3Pob7elU6WeY=; b=JWlgP6jxKiFA65iqYo9yH2aOPRjzeFzJifB6f1zeCN2cCXdvjDMy6KHyw3wQ/RoSKQEAHP 37iEPAa+8GUz7TuHaba2fTZ4x7NbnkYO4DMygUqmh2rmEdcKDJEICEmolbDem2GBgFLqC8 cMsgVifK7zr9+ZhEXYfAzjkIKIL/4Ik= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674833853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5cRXg2B8iBaH+A8rz4+PgHRwmqFEqyY3Pob7elU6WeY=; b=DDdye+W1Zfc6v7wp4G7koZRczLjVBwydNdnoXLoIp/V+ItmIUyw0fcZy66RkotjgBMR7r1 xmmSV4bM4BO9ocAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8E5D9138E3; Fri, 27 Jan 2023 15:37:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rxFwIr3v02MpawAAMHmgww (envelope-from ); Fri, 27 Jan 2023 15:37:33 +0000 Message-ID: Date: Fri, 27 Jan 2023 16:37:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 13/18] ata: libata-scsi: handle CDL bits in ata_scsiop_maint_in() Content-Language: en-US To: Niklas Cassel , Damien Le Moal Cc: Christoph Hellwig , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, linux-block@vger.kernel.org References: <20230124190308.127318-1-niklas.cassel@wdc.com> <20230124190308.127318-14-niklas.cassel@wdc.com> From: Hannes Reinecke In-Reply-To: <20230124190308.127318-14-niklas.cassel@wdc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 1/24/23 20:02, Niklas Cassel wrote: > From: Damien Le Moal > > For a scsi MAINTENANCE_IN/MI_REPORT_SUPPORTED_OPERATION_CODES operation, > add the translation of the rwcdlp and cdlp bits for the READ16 and > WRITE16 commands. If the ATA device does not support command duration > limits, these bits are always 0. If the ATA device supports command > duration limits, the rwcdlp bit is set to 1 for READ16 and WRITE16 and > the cdlp bits are set to 0x1 for READ16 and 0x2 for WRITE16. These > correspond to the T2A mode page containing the read descriptors and > to the T2B mode page containing the write descriptors, as defined in > SAT-5. > > Signed-off-by: Damien Le Moal > Signed-off-by: Niklas Cassel > --- > drivers/ata/libata-scsi.c | 30 ++++++++++++++++++++++++++---- > 1 file changed, 26 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes