From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3C5C4320A for ; Sat, 31 Jul 2021 08:45:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B69C1601FF for ; Sat, 31 Jul 2021 08:45:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232767AbhGaIpk (ORCPT ); Sat, 31 Jul 2021 04:45:40 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:58046 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232728AbhGaIpj (ORCPT ); Sat, 31 Jul 2021 04:45:39 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 3E1FD3F22C for ; Sat, 31 Jul 2021 08:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627721133; bh=HpikimZJ3+N1KHx4n97v9ZY8Mpfh1GCJC1kFvVvcZrc=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=J+0iscnl1f6Nl4fBHx4PEW1tQPMRyYzHoTWEkk4Jy1d4iVZdW3weCOtU/cJHd0ocs FvYvakymOh9rOjpPkMH586APFgSCSKGddk63TADY6ombqOnCGDdMK1dePNo3x7xhoW hJ5qr0z98uGy/z6GB9yCGQhAGfhREqVNT0jLgaEjT1KmdvwKYDe/vVdYMJ5iefXrls g0qoklNvrqbXHBv1JmHqAOrtbF6+S7tTq1ddbvNgaIOXJsvyJGvgVqakEUsJL4hdBI ONeSSOubIzQO1XRoe6MxZ25E1rY3au60JHFxW8nmFmOLZCnQmsppFSgO7dWwnUrQ73 lwuE0+8psTjKg== Received: by mail-ed1-f71.google.com with SMTP id h16-20020aa7de100000b02903a6620f87feso5875360edv.18 for ; Sat, 31 Jul 2021 01:45:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HpikimZJ3+N1KHx4n97v9ZY8Mpfh1GCJC1kFvVvcZrc=; b=i6O0jHjnB3KYydmfyFcjJi+KS7GX0Vt3krxRb0ncCVTLs+gyF4X9c24QAQwkd68oqg rFMxrFvbNy2GH8A2L+uHPHs99tZTSjvLHJezUcrOZPy5JUILl0kPd5nQ2DhpU9J6tNAq Uv7gsxcifUJWJXRkQCzc+M8gFs8aKgQCKUIxeuxC/aUpeaH+6d6AeioI0ta+ON2GcnkG XlaAhV45Dl3TU9mXPnn9W0OPtB3TiInp56mJaAMbN8YYDEU7ZRBM3m3GalBQxfrGCby6 J0dkjP1NNxmwHUNkjYZyxCv0w0lDzJltXkzQ8nqLGKwOiZoUVcOXsYJ7hHKubPYg0w0d +Tow== X-Gm-Message-State: AOAM5314qXJYpGZwBLwrs5kLl7frDLqclR8S7NA84uPg/TZrwuutIPqh VDM3CLCHAq39xhy408fv8WbvRoV0s4kOGB4B1QoMgtYCQu1cxbaEnks56oFJle94fU/XX2f+qSx qBPG2G4iipBNUMB8O9jbuhDyte4HLqJKqSfcP3WI= X-Received: by 2002:a17:906:1f82:: with SMTP id t2mr6494555ejr.499.1627721132521; Sat, 31 Jul 2021 01:45:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhfyQHtQpkTYQbl8JV0BuJ0MetHqfQ6fFXdNuJCV2ubWaz/d0aGWkgl0x0n4Bo8PaJzjHcCQ== X-Received: by 2002:a17:906:1f82:: with SMTP id t2mr6494542ejr.499.1627721132370; Sat, 31 Jul 2021 01:45:32 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id i10sm1888409edf.12.2021.07.31.01.45.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jul 2021 01:45:31 -0700 (PDT) To: Sam Protsenko , Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa Cc: Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-12-semen.protsenko@linaro.org> From: Krzysztof Kozlowski Subject: Re: [PATCH 11/12] dt-bindings: interrupt-controller: Add IRQ constants for Exynos850 Message-ID: Date: Sat, 31 Jul 2021 10:45:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210730144922.29111-12-semen.protsenko@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 30/07/2021 16:49, Sam Protsenko wrote: > Add external GIC interrupt constants for SPI[479:0] for Exynos850 SoC. > Interrupt names were taken from TRM without change, hence double > underscore in const namings. I am not sure what is the benefit of defining these in header. Unlike other DT consts (e.g. clock IDs) drivers do not us them at all. Using them in DT does not reduce chance of mistakes in numbers - instead of in DTS you can make a mistake here in header file. In the same time, they grow the interrupt property in DTS making it more difficult to read. I also did not see anyone else using this approach, so it's not only me (Marc also find it confusing). If vendor kernel did similar, it's not an argument. Samsung LSI /. vendor kernel has terrible code quality so usually it is not a good example. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44291C4338F for ; Sat, 31 Jul 2021 08:48:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A4466101C for ; Sat, 31 Jul 2021 08:48:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0A4466101C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:Subject:From:References:Cc:To:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=SEWBbcx4qdia44ZqMGVBvt39t9SlJXL08aHrlkfa20k=; b=Fj+cPIKUOZw253lAixRG/aKa/n 2UQFXu3l4ZgBLtX6rDyMvgpKQ1OjQAThWsrr0K+pL2P0DyP6Pr6eljC/bdh6Msr0KygGQnXoYuNVy Yf5dnkMY8DplQaHUBv3ykAhpmQg9y4OgoJnSreCHcvlKmd+kHGw1qBWvhYWIv/C/Cc7KFGszB6+iN El1h+4t/YTcjAxID3eVp3q6orbzNHzozkv5LgqqoDmbiUABOoXcx4e7HUOxeyxxwskK63L1EdVy0j TUL991isrK2i+T3A6BL8jGqYwk50fX1lPn0fFWSHnC/nRMZQnNt7OwsZbbB340a9TQwnONZBKBAxD 9IdVv6+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9kcl-00BHoN-Ik; Sat, 31 Jul 2021 08:45:39 +0000 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9kch-00BHnl-3s for linux-arm-kernel@lists.infradead.org; Sat, 31 Jul 2021 08:45:36 +0000 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 0DA5F3F239 for ; Sat, 31 Jul 2021 08:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627721133; bh=HpikimZJ3+N1KHx4n97v9ZY8Mpfh1GCJC1kFvVvcZrc=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=J+0iscnl1f6Nl4fBHx4PEW1tQPMRyYzHoTWEkk4Jy1d4iVZdW3weCOtU/cJHd0ocs FvYvakymOh9rOjpPkMH586APFgSCSKGddk63TADY6ombqOnCGDdMK1dePNo3x7xhoW hJ5qr0z98uGy/z6GB9yCGQhAGfhREqVNT0jLgaEjT1KmdvwKYDe/vVdYMJ5iefXrls g0qoklNvrqbXHBv1JmHqAOrtbF6+S7tTq1ddbvNgaIOXJsvyJGvgVqakEUsJL4hdBI ONeSSOubIzQO1XRoe6MxZ25E1rY3au60JHFxW8nmFmOLZCnQmsppFSgO7dWwnUrQ73 lwuE0+8psTjKg== Received: by mail-ed1-f72.google.com with SMTP id de5-20020a0564023085b02903bb92fd182eso5896338edb.8 for ; Sat, 31 Jul 2021 01:45:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HpikimZJ3+N1KHx4n97v9ZY8Mpfh1GCJC1kFvVvcZrc=; b=isXJzUusYryzo1XgxG1yPUXxrJhsxsSxDXDyFAY3Yjov0rZlrIg9EEsrDsPmnyfk+D 0l3bEcld4vOidxOEBYnrcEK3M+S4rbg6C2IEswcgN8pelhwvVQyWUmCNs+k3s4MsohBe gq9ywkV0Y5/Qr5AFdsiq/dENOh8DGmbjl4c58gOTrpPhdNIk+svfGu0Vhj5ZSGjxQKjz 2rVHwdU7K7FhH4canK9rfypCaQkoyQe8f6HRplXjkIg4SAWsxV+LYG0eV6JiCKGgB6Es PLyqadiXe/H/FTqI4eOYnFUKWqVYJkzjqFcL964Leku2GOT7fCsoobBl2Ju1SINbKtZV Zcfg== X-Gm-Message-State: AOAM530RQkdZgUGdnci7aG9p6w31/MPpUNjlt/bMqlaetl3TdvjMEFLJ Sw709K1g8pY/tjdXRtCP/D0S6mEYpY3t5DMc8+BMHeU/+AScRUV9jOZhrxjvA0m6y2gfJS9iYWy LIS9OoFW2cC/1/QkFPIMvGOJ3S8xuX29nVsvCyWZ6CQMcxPDL1GDS X-Received: by 2002:a17:906:1f82:: with SMTP id t2mr6494547ejr.499.1627721132520; Sat, 31 Jul 2021 01:45:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhfyQHtQpkTYQbl8JV0BuJ0MetHqfQ6fFXdNuJCV2ubWaz/d0aGWkgl0x0n4Bo8PaJzjHcCQ== X-Received: by 2002:a17:906:1f82:: with SMTP id t2mr6494542ejr.499.1627721132370; Sat, 31 Jul 2021 01:45:32 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id i10sm1888409edf.12.2021.07.31.01.45.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jul 2021 01:45:31 -0700 (PDT) To: Sam Protsenko , Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa Cc: Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-12-semen.protsenko@linaro.org> From: Krzysztof Kozlowski Subject: Re: [PATCH 11/12] dt-bindings: interrupt-controller: Add IRQ constants for Exynos850 Message-ID: Date: Sat, 31 Jul 2021 10:45:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210730144922.29111-12-semen.protsenko@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210731_014535_405482_B2A70EA3 X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/07/2021 16:49, Sam Protsenko wrote: > Add external GIC interrupt constants for SPI[479:0] for Exynos850 SoC. > Interrupt names were taken from TRM without change, hence double > underscore in const namings. I am not sure what is the benefit of defining these in header. Unlike other DT consts (e.g. clock IDs) drivers do not us them at all. Using them in DT does not reduce chance of mistakes in numbers - instead of in DTS you can make a mistake here in header file. In the same time, they grow the interrupt property in DTS making it more difficult to read. I also did not see anyone else using this approach, so it's not only me (Marc also find it confusing). If vendor kernel did similar, it's not an argument. Samsung LSI /. vendor kernel has terrible code quality so usually it is not a good example. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel